Commit 1f3cdb70 authored by Yang Guo's avatar Yang Guo Committed by Commit Bot

Enable --build-v8-with-gn for Node.js bots.

Bug: v8:6105
Change-Id: Idfc10bdab9c69d2d5f751197e3df068406bd521a
Reviewed-on: https://chromium-review.googlesource.com/868131
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50638}
parent c090806f
......@@ -61,12 +61,6 @@ def EnsureGit(v8_path):
return True
def FetchDeps(v8_path):
# TODO(v8:6105):
# The return value gates whether Node's configure script actually
# uses GN. Change this to true once everything is ready so that
# the change to enable the GN build on the bots comes from V8.
return False;
# Verify path.
v8_path = os.path.abspath(v8_path)
assert os.path.isdir(v8_path)
......@@ -94,6 +88,8 @@ def FetchDeps(v8_path):
os.path.join(v8_path, os.pardir, ".gclient_entries"))
if os.path.isfile(gclient_entries):
os.remove(gclient_entries)
# Enable building with GN for configure script.
return True
if __name__ == "__main__":
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment