Commit 1e82da4b authored by machenbach's avatar machenbach Committed by Commit bot

[test] Make try-perf script more convenient to use.

Warn if unknown benchmark configurations are triggered.

NOTRY=true

Review URL: https://codereview.chromium.org/1479483003

Cr-Commit-Position: refs/heads/master@{#32274}
parent 2732a6ad
......@@ -27,6 +27,25 @@ DEFAULT_BOTS = [
'v8_nexus10_perf_try',
]
PUBLIC_BENCHMARKS = [
'arewefastyet',
'embenchen',
'emscripten',
'compile',
'jetstream',
'jsbench',
'jstests',
'kraken_orig',
'massive',
'memory',
'octane',
'octane-pr',
'octane-tf',
'octane-tf-pr',
'simdjs',
'sunspider',
]
V8_BASE = os.path.abspath(os.path.dirname(os.path.dirname(__file__)))
def main():
......@@ -47,6 +66,16 @@ def main():
print 'Please specify the benchmarks to run as arguments.'
return 1
for benchmark in options.benchmarks:
if benchmark not in PUBLIC_BENCHMARKS:
print ('%s not found in our benchmark list. The respective trybot might '
'fail, unless you run something this script isn\'t aware of. '
'Available public benchmarks: %s' % (benchmark, PUBLIC_BENCHMARKS))
print 'Proceed anyways? [Y/n] ',
answer = sys.stdin.readline().strip()
if answer != "" and answer != "Y" and answer != "y":
return 1
assert '"' not in options.extra_flags and '\'' not in options.extra_flags, (
'Invalid flag specification.')
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment