Commit 1dfcc4b6 authored by Michael Achenbach's avatar Michael Achenbach Committed by Commit Bot

[foozzie] Remove obsolete suppressions

Most of these suppressions were for the old asm-validator or for the old compiler pipeline. Some more are just optimistically removed.

Bug: chromium:681088, chromium:681241, chromium:681806, chromium:662840
NOTRY=true

Change-Id: I4c6851a72d22070026eeaca90ad3394cfce10f90
Reviewed-on: https://chromium-review.googlesource.com/488641
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#44942}
parent 3f73fecb
......@@ -18,7 +18,7 @@ class UnitTest(unittest.TestCase):
def testDiff(self):
# TODO(machenbach): Mock out suppression configuration.
suppress = v8_suppressions.get_suppression(
'x64', 'fullcode', 'x64', 'default')
'x64', 'ignition', 'x64', 'ignition_turbo')
one = ''
two = ''
diff = None, None
......@@ -29,15 +29,12 @@ class UnitTest(unittest.TestCase):
diff = None, None
self.assertEquals(diff, suppress.diff(one, two))
# Ignore line before caret, caret position, stack trace char numbers
# error message and validator output.
# Ignore line before caret, caret position and error message.
one = """
undefined
weird stuff
^
Validation of asm.js module failed: foo bar
somefile.js: TypeError: undefined is not a function
stack line :15: foo
undefined
"""
two = """
......@@ -45,8 +42,6 @@ undefined
other weird stuff
^
somefile.js: TypeError: baz is not a function
stack line :2: foo
Validation of asm.js module failed: baz
undefined
"""
diff = None, None
......
......@@ -46,25 +46,6 @@ IGNORE_SOURCES = {
'/v8/test/mjsunit/regress/regress-2989.js',
],
'crbug.com/681088': [
'/v8/test/mjsunit/asm/asm-validation.js',
'/v8/test/mjsunit/asm/b5528-comma.js',
'/v8/test/mjsunit/asm/pointer-masking.js',
'/v8/test/mjsunit/compiler/regress-443744.js',
'/v8/test/mjsunit/regress/regress-599719.js',
'/v8/test/mjsunit/regress/wasm/regression-647649.js',
'/v8/test/mjsunit/wasm/asm-wasm.js',
'/v8/test/mjsunit/wasm/asm-wasm-deopt.js',
'/v8/test/mjsunit/wasm/asm-wasm-heap.js',
'/v8/test/mjsunit/wasm/asm-wasm-literals.js',
'/v8/test/mjsunit/wasm/asm-wasm-stack.js',
],
'crbug.com/681241': [
'/v8/test/mjsunit/regress/regress-617526.js',
'/v8/test/mjsunit/regress/wasm/regression-02862.js',
],
'crbug.com/688159': [
'/v8/test/mjsunit/es7/exponentiation-operator.js',
],
......@@ -107,17 +88,9 @@ IGNORE_OUTPUT = {
re.compile(r'RangeError(?!: byte length)', re.S),
'crbug.com/667678':
re.compile(r'\[native code\]', re.S),
'crbug.com/681806':
re.compile(r'WebAssembly\.Instance', re.S),
'crbug.com/681088':
re.compile(r'TypeError: Cannot read property \w+ of undefined', re.S),
'crbug.com/689877':
re.compile(r'^.*SyntaxError: .*Stack overflow$', re.M),
},
'validate_asm': {
'validate_asm':
re.compile(r'TypeError'),
},
}
# Lines matching any of the following regular expressions will be ignored
......@@ -143,10 +116,6 @@ ALLOWED_LINE_DIFFS = [
r'^.* is not a function(.*)$',
r'^(.*) is not a .*$',
# crbug.com/662840
r"^.*(?:Trying to access ')?(\w*)(?:(?:' through proxy)|"
r"(?: is not defined))$",
# crbug.com/680064. This subsumes one of the above expressions.
r'^(.*)TypeError: .* function$',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment