Commit 1ce039e1 authored by Seth Brenith's avatar Seth Brenith Committed by V8 LUCI CQ

Reland "Build cctest while building V8"

This is a reland of commit 7787ed20

Updates since original: specified that cctest sources depend on
generated files from the inspector.

Original change's description:
> Build cctest while building V8
>
> I noticed in a recent build that C++ files from cctest didn't start
> compiling until after several slow non-parallel tasks such as running
> mksnapshot and linking v8_for_testing. I don't see any reason that
> cctest sources should wait for those tasks, so in this change I propose
> adjusting the build dependencies for more parallelism.
>
> Change-Id: I2472117c8555ac397fa1232954c8b699d6429d38
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3690170
> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
> Cr-Commit-Position: refs/heads/main@{#80976}

Change-Id: I9f507c3c07bda1638b81de4b1ac82afda1168999
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3699405Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81112}
parent f9dd6f1f
...@@ -42,7 +42,6 @@ action("protocol_compatibility") { ...@@ -42,7 +42,6 @@ action("protocol_compatibility") {
} }
inspector_protocol_generate("protocol_generated_sources") { inspector_protocol_generate("protocol_generated_sources") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
deps = [ ":protocol_compatibility" ] deps = [ ":protocol_compatibility" ]
inspector_protocol_dir = _inspector_protocol inspector_protocol_dir = _inspector_protocol
......
...@@ -16,7 +16,13 @@ v8_executable("cctest") { ...@@ -16,7 +16,13 @@ v8_executable("cctest") {
sources = [ "cctest.cc" ] sources = [ "cctest.cc" ]
deps = [ ":cctest_sources" ] deps = [
":cctest_sources",
"../..:v8_for_testing",
"../..:v8_libbase",
"../..:v8_libplatform",
"../../tools/debug_helper:v8_debug_helper",
]
data_deps = [ "../../tools:v8_testrunner" ] data_deps = [ "../../tools:v8_testrunner" ]
...@@ -325,10 +331,7 @@ v8_source_set("cctest_sources") { ...@@ -325,10 +331,7 @@ v8_source_set("cctest_sources") {
public_deps = [ public_deps = [
":cctest_headers", ":cctest_headers",
"..:common_test_headers", "..:common_test_headers",
"../..:v8_for_testing", "../../src/inspector:protocol_generated_sources",
"../..:v8_libbase",
"../..:v8_libplatform",
"../../tools/debug_helper:v8_debug_helper",
"//build/win:default_exe_manifest", "//build/win:default_exe_manifest",
] ]
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment