Commit 1c39586a authored by mstarzinger's avatar mstarzinger Committed by Commit bot

[runtime] Deprecate RUNTIME_ASSERT from WASM methods.

This removes explicit uses of the RUNTIME_ASSERT macro from some runtime
methods. The implicit ones in CONVERT_FOO_ARG_CHECKED will be addressed
in a separate CL for all runtime modules at once.

R=titzer@chromium.org
BUG=v8:5066

Review-Url: https://codereview.chromium.org/2125793002
Cr-Commit-Position: refs/heads/master@{#37547}
parent ab4d8fc0
......@@ -21,7 +21,7 @@ RUNTIME_FUNCTION(Runtime_WasmGrowMemory) {
HandleScope scope(isolate);
DCHECK_EQ(1, args.length());
uint32_t delta_pages = 0;
RUNTIME_ASSERT(args[0]->ToUint32(&delta_pages));
CHECK(args[0]->ToUint32(&delta_pages));
Handle<JSObject> module_object;
{
......@@ -35,7 +35,7 @@ RUNTIME_FUNCTION(Runtime_WasmGrowMemory) {
FixedArray* deopt_data = code->deoptimization_data();
DCHECK(deopt_data->length() == 2);
module_object = Handle<JSObject>::cast(handle(deopt_data->get(0), isolate));
RUNTIME_ASSERT(!module_object->IsNull(isolate));
CHECK(!module_object->IsNull(isolate));
}
Address old_mem_start, new_mem_start;
......@@ -103,8 +103,8 @@ RUNTIME_FUNCTION(Runtime_WasmGrowMemory) {
// Set new buffer to be wasm memory
module_object->SetInternalField(kWasmMemArrayBuffer, *buffer);
RUNTIME_ASSERT(wasm::UpdateWasmModuleMemory(
module_object, old_mem_start, new_mem_start, old_size, new_size));
CHECK(wasm::UpdateWasmModuleMemory(module_object, old_mem_start,
new_mem_start, old_size, new_size));
return *isolate->factory()->NewNumberFromUint(old_size /
wasm::WasmModule::kPageSize);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment