Commit 1c32d326 authored by Georg Neis's avatar Georg Neis Committed by Commit Bot

[compiler] Strengthen a DCHECK

A PropertyCell holding the_hole can't have cell type Undefined when the
compiler sees it.

Change-Id: Idcfe6c57c669a65a4ffbe522803bf25efc8bee5f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2531785
Auto-Submit: Georg Neis <neis@chromium.org>
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71143}
parent 0367cc89
......@@ -270,10 +270,8 @@ class GlobalPropertyDependency final : public CompilationDependency {
// The dependency is never valid if the cell is 'invalidated'. This is
// marked by setting the value to the hole.
if (cell->value() == *(cell_.isolate()->factory()->the_hole_value())) {
DCHECK(cell->property_details().cell_type() ==
PropertyCellType::kInvalidated ||
cell->property_details().cell_type() ==
PropertyCellType::kUninitialized);
DCHECK_EQ(cell->property_details().cell_type(),
PropertyCellType::kInvalidated);
return false;
}
return type_ == cell->property_details().cell_type() &&
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment