Make ICU a public dep of v8_base when building with i18n support

That's cleaner than having every target depending on v8 include icu
itself.

BUG=none
R=machenbach@chromium.org

Change-Id: Icaa9e8670718664041a6efe2622366c89b733f81
Reviewed-on: https://chromium-review.googlesource.com/500127Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45196}

BUILD.gn

@@ -2400,7 +2400,9 @@ v8_source_set("v8_base") {
   ]
 
   if (v8_enable_i18n_support) {
-    deps += [ "//third_party/icu" ]
+    public_deps = [
+      "//third_party/icu",
+    ]
     if (is_win) {
       deps += [ "//third_party/icu:icudata" ]
     }
@@ -2624,10 +2626,6 @@ v8_source_set("fuzzer_support") {
     ":v8_libbase",
     ":v8_libplatform",
   ]
-
-  if (v8_enable_i18n_support) {
-    deps += [ "//third_party/icu" ]
-  }
 }
 
 ###############################################################################
@@ -2833,10 +2831,6 @@ v8_executable("d8") {
     sources += [ "src/d8-windows.cc" ]
   }
 
-  if (v8_enable_i18n_support) {
-    deps += [ "//third_party/icu" ]
-  }
-
   if (v8_correctness_fuzzer) {
     deps += [ "tools/foozzie:v8_correctness_fuzzer_resources" ]
   }
@@ -2875,10 +2869,6 @@ v8_executable("v8_hello_world") {
     "//build/config/sanitizers:deps",
     "//build/win:default_exe_manifest",
   ]
-
-  if (v8_enable_i18n_support) {
-    deps += [ "//third_party/icu" ]
-  }
 }
 
 v8_executable("v8_sample_process") {
@@ -2900,10 +2890,6 @@ v8_executable("v8_sample_process") {
     "//build/config/sanitizers:deps",
     "//build/win:default_exe_manifest",
   ]
-
-  if (v8_enable_i18n_support) {
-    deps += [ "//third_party/icu" ]
-  }
 }
 
 v8_executable("v8_parser_shell") {
@@ -2924,10 +2910,6 @@ v8_executable("v8_parser_shell") {
     "//build/config/sanitizers:deps",
     "//build/win:default_exe_manifest",
   ]
-
-  if (v8_enable_i18n_support) {
-    deps += [ "//third_party/icu" ]
-  }
 }
 
 if (want_v8_shell) {
@@ -2950,10 +2932,6 @@ if (want_v8_shell) {
       "//build/config/sanitizers:deps",
       "//build/win:default_exe_manifest",
     ]
-
-    if (v8_enable_i18n_support) {
-      deps += [ "//third_party/icu" ]
-    }
   }
 }
 

test/inspector/BUILD.gn

@@ -28,10 +28,6 @@ v8_executable("inspector-test") {
     "//build/win:default_exe_manifest",
   ]
 
-  if (v8_enable_i18n_support) {
-    deps += [ "//third_party/icu" ]
-  }
-
   cflags = []
   ldflags = []
 }

test/unittests/BUILD.gn

@@ -196,10 +196,6 @@ v8_executable("unittests") {
     "//testing/gtest",
   ]
 
-  if (v8_enable_i18n_support) {
-    deps += [ "//third_party/icu" ]
-  }
-
   if (is_win) {
     # This warning is benignly triggered by the U16 and U32 macros in
     # bytecode-utils.h.