Commit 1bff5728 authored by Almothana Athamneh's avatar Almothana Athamneh Committed by Commit Bot

Skip tests that fail on Fuchsia

Bug: chromium:934932
Change-Id: I9e7940b645cfad8da40950de86c2a5a7feedccff
Cq-Include-Trybots: luci.v8.try:v8_fuchsia_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2846894Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Almothana Athamneh <almuthanna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74160}
parent ae23bc45
...@@ -89,6 +89,7 @@ TEST(StackTest, GetCurrentStackPosition) { ...@@ -89,6 +89,7 @@ TEST(StackTest, GetCurrentStackPosition) {
EXPECT_NE(nullptr, Stack::GetCurrentStackPosition()); EXPECT_NE(nullptr, Stack::GetCurrentStackPosition());
} }
#if !V8_OS_FUCHSIA
TEST(StackTest, StackVariableInBounds) { TEST(StackTest, StackVariableInBounds) {
void* dummy; void* dummy;
ASSERT_GT(static_cast<void*>(Stack::GetStackStart()), ASSERT_GT(static_cast<void*>(Stack::GetStackStart()),
...@@ -98,6 +99,7 @@ TEST(StackTest, StackVariableInBounds) { ...@@ -98,6 +99,7 @@ TEST(StackTest, StackVariableInBounds) {
EXPECT_LT(static_cast<void*>(Stack::GetCurrentStackPosition()), EXPECT_LT(static_cast<void*>(Stack::GetCurrentStackPosition()),
Stack::GetRealStackAddressForSlot(&dummy)); Stack::GetRealStackAddressForSlot(&dummy));
} }
#endif // !V8_OS_FUCHSIA
} // namespace base } // namespace base
} // namespace v8 } // namespace v8
...@@ -39,10 +39,12 @@ class GCStackTest : public ::testing::Test { ...@@ -39,10 +39,12 @@ class GCStackTest : public ::testing::Test {
} // namespace } // namespace
#if !V8_OS_FUCHSIA
TEST_F(GCStackTest, IsOnStackForStackValue) { TEST_F(GCStackTest, IsOnStackForStackValue) {
void* dummy; void* dummy;
EXPECT_TRUE(GetStack()->IsOnStack(&dummy)); EXPECT_TRUE(GetStack()->IsOnStack(&dummy));
} }
#endif // !V8_OS_FUCHSIA
TEST_F(GCStackTest, IsOnStackForHeapValue) { TEST_F(GCStackTest, IsOnStackForHeapValue) {
auto dummy = std::make_unique<int>(); auto dummy = std::make_unique<int>();
......
...@@ -897,6 +897,7 @@ TEST_F(WasmModuleVerifyTest, GlobalRttSubOfGlobalTypeError) { ...@@ -897,6 +897,7 @@ TEST_F(WasmModuleVerifyTest, GlobalRttSubOfGlobalTypeError) {
EXPECT_NOT_OK(result, "rtt.sub requires a supertype rtt on stack"); EXPECT_NOT_OK(result, "rtt.sub requires a supertype rtt on stack");
} }
#if !V8_OS_FUCHSIA
TEST_F(WasmModuleVerifyTest, GlobalRttSubIllegalParent) { TEST_F(WasmModuleVerifyTest, GlobalRttSubIllegalParent) {
WASM_FEATURE_SCOPE(reftypes); WASM_FEATURE_SCOPE(reftypes);
WASM_FEATURE_SCOPE(typed_funcref); WASM_FEATURE_SCOPE(typed_funcref);
...@@ -910,6 +911,7 @@ TEST_F(WasmModuleVerifyTest, GlobalRttSubIllegalParent) { ...@@ -910,6 +911,7 @@ TEST_F(WasmModuleVerifyTest, GlobalRttSubIllegalParent) {
ModuleResult result = DecodeModule(data, data + sizeof(data)); ModuleResult result = DecodeModule(data, data + sizeof(data));
EXPECT_NOT_OK(result, "rtt.sub requires a supertype rtt on stack"); EXPECT_NOT_OK(result, "rtt.sub requires a supertype rtt on stack");
} }
#endif // !V8_OS_FUCHSIA
TEST_F(WasmModuleVerifyTest, RttSubGlobalTypeError) { TEST_F(WasmModuleVerifyTest, RttSubGlobalTypeError) {
WASM_FEATURE_SCOPE(reftypes); WASM_FEATURE_SCOPE(reftypes);
......
...@@ -468,9 +468,11 @@ TEST_P(TrapHandlerTest, TestCrashInOtherThread) { ...@@ -468,9 +468,11 @@ TEST_P(TrapHandlerTest, TestCrashInOtherThread) {
} }
#endif #endif
#if !V8_OS_FUCHSIA
INSTANTIATE_TEST_SUITE_P(Traps, TrapHandlerTest, INSTANTIATE_TEST_SUITE_P(Traps, TrapHandlerTest,
::testing::Values(kDefault, kCallback), ::testing::Values(kDefault, kCallback),
PrintTrapHandlerTestParam); PrintTrapHandlerTestParam);
#endif // !V8_OS_FUCHSIA
#undef __ #undef __
} // namespace wasm } // namespace wasm
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment