Commit 1b526cc7 authored by whesse@chromium.org's avatar whesse@chromium.org

Remove obsolete bug TODO

Review URL: http://codereview.chromium.org/618006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3888 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent a3466441
...@@ -4411,7 +4411,6 @@ void Reference::SetValue(InitState init_state) { ...@@ -4411,7 +4411,6 @@ void Reference::SetValue(InitState init_state) {
// Call IC code. // Call IC code.
Handle<Code> ic(Builtins::builtin(Builtins::KeyedStoreIC_Initialize)); Handle<Code> ic(Builtins::builtin(Builtins::KeyedStoreIC_Initialize));
// TODO(1222589): Make the IC grab the values from the stack.
frame->EmitPop(r0); // value frame->EmitPop(r0); // value
frame->CallCodeObject(ic, RelocInfo::CODE_TARGET, 0); frame->CallCodeObject(ic, RelocInfo::CODE_TARGET, 0);
frame->EmitPush(r0); frame->EmitPush(r0);
......
...@@ -5790,7 +5790,6 @@ void CodeGenerator::VisitUnaryOperation(UnaryOperation* node) { ...@@ -5790,7 +5790,6 @@ void CodeGenerator::VisitUnaryOperation(UnaryOperation* node) {
switch (op) { switch (op) {
case Token::SUB: { case Token::SUB: {
GenericUnaryOpStub stub(Token::SUB, overwrite); GenericUnaryOpStub stub(Token::SUB, overwrite);
// TODO(1222589): remove dependency of TOS being cached inside stub
Result operand = frame_->Pop(); Result operand = frame_->Pop();
Result answer = frame_->CallStub(&stub, &operand); Result answer = frame_->CallStub(&stub, &operand);
frame_->Push(&answer); frame_->Push(&answer);
......
...@@ -982,7 +982,6 @@ Result VirtualFrame::CallKeyedStoreIC() { ...@@ -982,7 +982,6 @@ Result VirtualFrame::CallKeyedStoreIC() {
// expects value in eax and key and receiver on the stack. It does // expects value in eax and key and receiver on the stack. It does
// not drop the key and receiver. // not drop the key and receiver.
Handle<Code> ic(Builtins::builtin(Builtins::KeyedStoreIC_Initialize)); Handle<Code> ic(Builtins::builtin(Builtins::KeyedStoreIC_Initialize));
// TODO(1222589): Make the IC grab the values from the stack.
Result value = Pop(); Result value = Pop();
PrepareForCall(2, 0); // Two stack args, neither callee-dropped. PrepareForCall(2, 0); // Two stack args, neither callee-dropped.
value.ToRegister(eax); value.ToRegister(eax);
......
...@@ -3071,7 +3071,6 @@ void CodeGenerator::VisitUnaryOperation(UnaryOperation* node) { ...@@ -3071,7 +3071,6 @@ void CodeGenerator::VisitUnaryOperation(UnaryOperation* node) {
case Token::SUB: { case Token::SUB: {
GenericUnaryOpStub stub(Token::SUB, overwrite); GenericUnaryOpStub stub(Token::SUB, overwrite);
// TODO(1222589): remove dependency of TOS being cached inside stub
Result operand = frame_->Pop(); Result operand = frame_->Pop();
Result answer = frame_->CallStub(&stub, &operand); Result answer = frame_->CallStub(&stub, &operand);
frame_->Push(&answer); frame_->Push(&answer);
......
...@@ -1033,7 +1033,6 @@ Result VirtualFrame::CallKeyedStoreIC() { ...@@ -1033,7 +1033,6 @@ Result VirtualFrame::CallKeyedStoreIC() {
// expects value in rax and key and receiver on the stack. It does // expects value in rax and key and receiver on the stack. It does
// not drop the key and receiver. // not drop the key and receiver.
Handle<Code> ic(Builtins::builtin(Builtins::KeyedStoreIC_Initialize)); Handle<Code> ic(Builtins::builtin(Builtins::KeyedStoreIC_Initialize));
// TODO(1222589): Make the IC grab the values from the stack.
Result value = Pop(); Result value = Pop();
PrepareForCall(2, 0); // Two stack args, neither callee-dropped. PrepareForCall(2, 0); // Two stack args, neither callee-dropped.
value.ToRegister(rax); value.ToRegister(rax);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment