[runtime] Remove unnecessary instance types

LAST_FUNCTION_TYPE, FIRST_FUNCTION_TYPE are no longer necessary.

TBR: tebbi@chromium.org
Bug: v8:11256
Change-Id: I37b1396eca8f89a287e04f2ef6b642dad248ae67
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2599745
Commit-Queue: Sathya Gunasekaran  <gsathya@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71852}

src/compiler/js-call-reducer.cc

@@ -2615,8 +2615,8 @@ Reduction JSCallReducer::ReduceFunctionPrototypeBind(Node* node) {
     // Check for consistency among the {receiver_maps}.
     if (!receiver_map.prototype().equals(prototype) ||
         receiver_map.is_constructor() != is_constructor ||
-        !base::IsInRange(receiver_map.instance_type(), FIRST_FUNCTION_TYPE,
-                         LAST_FUNCTION_TYPE)) {
+        !InstanceTypeChecker::IsJSFunctionOrBoundFunction(
+            receiver_map.instance_type())) {
       return inference.NoChange();
     }
 

src/objects/instance-type.h

@@ -143,8 +143,6 @@ enum InstanceType : uint16_t {
   // Convenient names for things where the generated name is awkward:
   FIRST_TYPE = FIRST_HEAP_OBJECT_TYPE,
   LAST_TYPE = LAST_HEAP_OBJECT_TYPE,
-  FIRST_FUNCTION_TYPE = FIRST_JS_FUNCTION_OR_BOUND_FUNCTION_TYPE,
-  LAST_FUNCTION_TYPE = LAST_JS_FUNCTION_OR_BOUND_FUNCTION_TYPE,
   BIGINT_TYPE = BIG_INT_BASE_TYPE,
 };
 

src/objects/objects-inl.h

@@ -154,8 +154,7 @@ DEF_GETTER(HeapObject, IsUniqueName, bool) {
 }
 
 DEF_GETTER(HeapObject, IsFunction, bool) {
-  return base::IsInRange(map(isolate).instance_type(), FIRST_FUNCTION_TYPE,
-                         LAST_FUNCTION_TYPE);
+  return IsJSFunctionOrBoundFunction();
 }
 
 DEF_GETTER(HeapObject, IsCallable, bool) { return map(isolate).is_callable(); }