api: Remove deprecated RegisterEmbedderReference method

Change-Id: I5889da6b5bb916639d00c450d06c35040c34a9a0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1997130
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65752}

include/v8.h

@@ -7879,8 +7879,6 @@ class V8_EXPORT EmbedderHeapTracer {
   virtual void RegisterV8References(
       const std::vector<std::pair<void*, void*> >& embedder_fields) = 0;
 
-  V8_DEPRECATED("Use version taking TracedReferenceBase<v8::Data> argument")
-  void RegisterEmbedderReference(const TracedReferenceBase<v8::Value>& ref);
   void RegisterEmbedderReference(const TracedReferenceBase<v8::Data>& ref);
 
   /**
@@ -7964,9 +7962,6 @@ class V8_EXPORT EmbedderHeapTracer {
    */
   virtual void ResetHandleInNonTracingGC(
       const v8::TracedReference<v8::Value>& handle);
-  V8_DEPRECATED("Use TracedReference version when not requiring destructors.")
-  virtual void ResetHandleInNonTracingGC(
-      const v8::TracedGlobal<v8::Value>& handle);
 
   /*
    * Called by the embedder to immediately perform a full garbage collection.

src/api/api.cc

@@ -10802,15 +10802,6 @@ void EmbedderHeapTracer::RegisterEmbedderReference(
       reinterpret_cast<i::Address*>(ref.val_));
 }
 
-void EmbedderHeapTracer::RegisterEmbedderReference(
-    const TracedReferenceBase<v8::Value>& ref) {
-  if (ref.IsEmpty()) return;
-
-  i::Heap* const heap = reinterpret_cast<i::Isolate*>(isolate_)->heap();
-  heap->RegisterExternallyReferencedObject(
-      reinterpret_cast<i::Address*>(ref.val_));
-}
-
 void EmbedderHeapTracer::IterateTracedGlobalHandles(
     TracedGlobalHandleVisitor* visitor) {
   i::Isolate* isolate = reinterpret_cast<i::Isolate*>(isolate_);
@@ -10833,11 +10824,6 @@ void EmbedderHeapTracer::ResetHandleInNonTracingGC(
   UNREACHABLE();
 }
 
-void EmbedderHeapTracer::ResetHandleInNonTracingGC(
-    const v8::TracedGlobal<v8::Value>& handle) {
-  UNREACHABLE();
-}
-
 namespace internal {
 
 const size_t HandleScopeImplementer::kEnteredContextsOffset =

test/cctest/heap/test-embedder-tracing.cc

@@ -798,12 +798,6 @@ class EmbedderHeapTracerDestructorNonTracingClearing final
     return handle.WrapperClassId() != class_id_to_optimize_;
   }
 
-  void ResetHandleInNonTracingGC(
-      const v8::TracedGlobal<v8::Value>& handle) final {
-    // Not called when used with handles that have destructors.
-    CHECK(false);
-  }
-
  private:
   uint16_t class_id_to_optimize_;
 };