Commit 196d6aee authored by binji's avatar binji Committed by Commit bot

Remove harmony-atomics flag and collapse it into sharedarraybuffer flag

Having both flags is tedious, and it is unlikely you'd ever want them
separately.

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/1304163010

Cr-Commit-Position: refs/heads/master@{#30523}
parent 6184f1fe
...@@ -1845,7 +1845,6 @@ EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_destructuring) ...@@ -1845,7 +1845,6 @@ EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_destructuring)
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_object) EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_object)
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_object_observe) EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_object_observe)
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_spread_arrays) EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_spread_arrays)
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_atomics)
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_new_target) EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_new_target)
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_concat_spreadable) EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_concat_spreadable)
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_regexps) EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_regexps)
...@@ -2491,9 +2490,7 @@ bool Genesis::InstallExperimentalNatives() { ...@@ -2491,9 +2490,7 @@ bool Genesis::InstallExperimentalNatives() {
"native harmony-object-observe.js", nullptr}; "native harmony-object-observe.js", nullptr};
static const char* harmony_spread_arrays_natives[] = {nullptr}; static const char* harmony_spread_arrays_natives[] = {nullptr};
static const char* harmony_sharedarraybuffer_natives[] = { static const char* harmony_sharedarraybuffer_natives[] = {
"native harmony-sharedarraybuffer.js", NULL}; "native harmony-sharedarraybuffer.js", "native harmony-atomics.js", NULL};
static const char* harmony_atomics_natives[] = {"native harmony-atomics.js",
nullptr};
static const char* harmony_new_target_natives[] = {nullptr}; static const char* harmony_new_target_natives[] = {nullptr};
static const char* harmony_concat_spreadable_natives[] = { static const char* harmony_concat_spreadable_natives[] = {
"native harmony-concat-spreadable.js", nullptr}; "native harmony-concat-spreadable.js", nullptr};
...@@ -2610,7 +2607,7 @@ void Genesis::InstallBuiltinFunctionIds() { ...@@ -2610,7 +2607,7 @@ void Genesis::InstallBuiltinFunctionIds() {
void Genesis::InstallExperimentalBuiltinFunctionIds() { void Genesis::InstallExperimentalBuiltinFunctionIds() {
if (FLAG_harmony_atomics) { if (FLAG_harmony_sharedarraybuffer) {
struct BuiltinFunctionIds { struct BuiltinFunctionIds {
const char* holder_expr; const char* holder_expr;
const char* fun_name; const char* fun_name;
......
...@@ -199,7 +199,6 @@ DEFINE_BOOL(legacy_const, true, "legacy semantics for const in sloppy mode") ...@@ -199,7 +199,6 @@ DEFINE_BOOL(legacy_const, true, "legacy semantics for const in sloppy mode")
V(harmony_destructuring, "harmony destructuring") \ V(harmony_destructuring, "harmony destructuring") \
V(harmony_default_parameters, "harmony default parameters") \ V(harmony_default_parameters, "harmony default parameters") \
V(harmony_sharedarraybuffer, "harmony sharedarraybuffer") \ V(harmony_sharedarraybuffer, "harmony sharedarraybuffer") \
V(harmony_atomics, "harmony atomics") \
V(harmony_simd, "harmony simd") V(harmony_simd, "harmony simd")
// Features that are complete (but still behind --harmony/es-staging flag). // Features that are complete (but still behind --harmony/es-staging flag).
......
...@@ -21835,7 +21835,6 @@ class FutexInterruptionThread : public v8::base::Thread { ...@@ -21835,7 +21835,6 @@ class FutexInterruptionThread : public v8::base::Thread {
TEST(FutexInterruption) { TEST(FutexInterruption) {
i::FLAG_harmony_sharedarraybuffer = true; i::FLAG_harmony_sharedarraybuffer = true;
i::FLAG_harmony_atomics = true;
v8::Isolate* isolate = CcTest::isolate(); v8::Isolate* isolate = CcTest::isolate();
v8::HandleScope scope(isolate); v8::HandleScope scope(isolate);
LocalContext env; LocalContext env;
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-atomics --harmony-sharedarraybuffer // Flags: --harmony-sharedarraybuffer
function Module(stdlib, foreign, heap) { function Module(stdlib, foreign, heap) {
"use asm"; "use asm";
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-atomics --harmony-sharedarraybuffer // Flags: --harmony-sharedarraybuffer
function Module(stdlib, foreign, heap) { function Module(stdlib, foreign, heap) {
"use asm"; "use asm";
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-atomics --harmony-sharedarraybuffer // Flags: --harmony-sharedarraybuffer
function Module(stdlib, foreign, heap) { function Module(stdlib, foreign, heap) {
"use asm"; "use asm";
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-atomics --harmony-sharedarraybuffer // Flags: --harmony-sharedarraybuffer
function Module(stdlib, foreign, heap) { function Module(stdlib, foreign, heap) {
"use asm"; "use asm";
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-atomics --harmony-sharedarraybuffer // Flags: --harmony-sharedarraybuffer
function Module(stdlib, foreign, heap) { function Module(stdlib, foreign, heap) {
"use asm"; "use asm";
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-atomics --harmony-sharedarraybuffer // Flags: --harmony-sharedarraybuffer
function Module(stdlib, foreign, heap) { function Module(stdlib, foreign, heap) {
"use asm"; "use asm";
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-atomics --harmony-sharedarraybuffer // Flags: --harmony-sharedarraybuffer
function Module(stdlib, foreign, heap) { function Module(stdlib, foreign, heap) {
"use asm"; "use asm";
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-atomics --harmony-sharedarraybuffer // Flags: --harmony-sharedarraybuffer
function Module(stdlib, foreign, heap) { function Module(stdlib, foreign, heap) {
"use asm"; "use asm";
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-atomics --harmony-sharedarraybuffer // Flags: --harmony-sharedarraybuffer
function Module(stdlib, foreign, heap) { function Module(stdlib, foreign, heap) {
"use asm"; "use asm";
......
...@@ -25,7 +25,7 @@ ...@@ -25,7 +25,7 @@
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
// Flags: --harmony-sharedarraybuffer --harmony-atomics // Flags: --harmony-sharedarraybuffer
if (this.Worker) { if (this.Worker) {
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-atomics --harmony-sharedarraybuffer // Flags: --harmony-sharedarraybuffer
// //
function toRangeWrapped(value) { function toRangeWrapped(value) {
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --allow-natives-syntax --harmony-atomics --harmony-sharedarraybuffer // Flags: --allow-natives-syntax --harmony-sharedarraybuffer
(function TestFailsWithNonSharedArray() { (function TestFailsWithNonSharedArray() {
var ab = new ArrayBuffer(16); var ab = new ArrayBuffer(16);
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-sharedarraybuffer --harmony-atomics // Flags: --harmony-sharedarraybuffer
var sab = new SharedArrayBuffer(8); var sab = new SharedArrayBuffer(8);
var ta = new Int32Array(sab); var ta = new Int32Array(sab);
ta.__defineSetter__('length', function() {;}); ta.__defineSetter__('length', function() {;});
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment