Commit 19312c16 authored by yangguo's avatar yangguo Committed by Commit bot

Do not clear stepping after DebugEvaluate.

Clearing stepping was originally introduced in http://codereview.chromium.org/7889039
But DebugEvaluate now also uses a DisableBreak scope, which makes sure we don't step
inside the evaluated code.

R=yurys@chromium.org
BUG=chromium:467180
LOG=N

Review URL: https://codereview.chromium.org/1129363003

Cr-Commit-Position: refs/heads/master@{#28461}
parent 7af6c1ee
...@@ -2447,8 +2447,6 @@ static MaybeHandle<Object> DebugEvaluate(Isolate* isolate, ...@@ -2447,8 +2447,6 @@ static MaybeHandle<Object> DebugEvaluate(Isolate* isolate,
result = Handle<JSObject>::cast(PrototypeIterator::GetCurrent(iter)); result = Handle<JSObject>::cast(PrototypeIterator::GetCurrent(iter));
} }
// Clear the oneshot breakpoints so that the debugger does not step further.
isolate->debug()->ClearStepping();
return result; return result;
} }
......
// Copyright 2015 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --expose-debug-as debug
function f() {
for (var i = 10; i < 14; i++) { // 1
i; // 2
}
} // 3
var state = "conditional";
var log = [];
var exception = null;
function listener(event, exec_state, event_data, data) {
if (event != Debug.DebugEvent.Break) return;
try {
var label = +exec_state.frame(0).sourceLineText().substr(-1);
log.push(label);
if (label == 2) log.push(exec_state.frame(0).evaluate("i").value());
exec_state.prepareStep(Debug.StepAction.StepNext, 1);
} catch (e) {
exception = e;
print("Caught something. " + e + " " + e.stack);
};
};
var Debug = debug.Debug;
Debug.setListener(listener);
Debug.setBreakPoint(f, 2, 0, "i == 12");
f();
Debug.setListener(null); // 4
assertEquals([2,12,1,1,2,13,1,1,3,4], log);
assertNull(exception);
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment