Commit 18d82682 authored by Michael Starzinger's avatar Michael Starzinger Committed by Commit Bot

[test] Remove dead and unmaintained test variants.

The two variants "turbofan" and "turbofan_opt" are not part of any of
the default sets of variants that run-tests.py uses. The only way to
trigger execution would be via the --variants flag directly, which our
infrastructure is not doing.

R=machenbach@chromium.org

Change-Id: Ifa58cb4a83a3760ffba73e8b40b417a845f53506
Reviewed-on: https://chromium-review.googlesource.com/526637Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45772}
parent 63f09185
...@@ -402,18 +402,6 @@ ...@@ -402,18 +402,6 @@
}], # 'arch == ppc64 and simulator_run == True' }], # 'arch == ppc64 and simulator_run == True'
##############################################################################
['variant == turbofan_opt', {
# BUG(v8:5457)
'test-api/SetJitCodeEventHandler': [PASS, ['no_snap', SKIP]],
}], # variant == turbofan_opt
##############################################################################
['variant == turbofan', {
# BUG(4751). Flaky with Ignition.
'test-cpu-profiler/JsNativeJsSample': [SKIP],
}], # variant == turbofan
############################################################################## ##############################################################################
['variant == noturbofan and no_snap', { ['variant == noturbofan and no_snap', {
# Too slow for old pipeline and nosnap. # Too slow for old pipeline and nosnap.
......
...@@ -62,12 +62,6 @@ ...@@ -62,12 +62,6 @@
'debug/es8/async-function-debug-scopes': [SKIP], 'debug/es8/async-function-debug-scopes': [SKIP],
}], # 'gc_stress == True' }], # 'gc_stress == True'
##############################################################################
['variant == turbofan_opt', {
# TODO(jarin/mstarzinger): Investigate debugger issues with TurboFan.
'debug/debug-evaluate-locals': [FAIL],
}], # variant == turbofan_opt
############################################################################## ##############################################################################
['variant == wasm_traps', { ['variant == wasm_traps', {
'*': [SKIP], '*': [SKIP],
......
...@@ -633,20 +633,6 @@ ...@@ -633,20 +633,6 @@
'harmony/futex': [SKIP], 'harmony/futex': [SKIP],
}], # variant == noturbofan and no_snap }], # variant == noturbofan and no_snap
##############################################################################
['variant == turbofan_opt', {
'es6/array-iterator-turbo': [SKIP],
# TODO(jgruber): Fails in --turbo --always-opt mode.
'regress/regress-105': [FAIL],
# Too slow.
'big-object-literal': [SKIP],
'ignition/regress-599001-verifyheap': [SKIP],
'unicode-test': [SKIP],
}], # variant == turbofan_opt
############################################################################## ##############################################################################
['gcov_coverage', { ['gcov_coverage', {
# Tests taking too long. # Tests taking too long.
......
...@@ -865,18 +865,6 @@ ...@@ -865,18 +865,6 @@
}], # ALWAYS }], # ALWAYS
['variant == turbofan_opt', {
# These timeout flakily under CFI/turbofan_opt
'js1_5/Regress/regress-360969-05': [SKIP],
'js1_5/Regress/regress-360969-06': [SKIP],
# These timeout under CFI/turbofan_opt
'ecma/FunctionObjects/15.3.1.1-3': [SKIP],
'ecma/FunctionObjects/15.3.2.1-3': [SKIP],
'ecma/FunctionObjects/15.3.5-1': [SKIP],
}], # variant == turbofan_opt
['no_i18n == True and mode == debug', { ['no_i18n == True and mode == debug', {
# Tests too slow for no18n debug. # Tests too slow for no18n debug.
'ecma_3/Statements/regress-302439': [PASS, FAST_VARIANTS], 'ecma_3/Statements/regress-302439': [PASS, FAST_VARIANTS],
......
...@@ -6,8 +6,6 @@ ...@@ -6,8 +6,6 @@
ALL_VARIANT_FLAGS = { ALL_VARIANT_FLAGS = {
"default": [[]], "default": [[]],
"stress": [["--stress-opt", "--always-opt"]], "stress": [["--stress-opt", "--always-opt"]],
"turbofan": [["--turbo"]],
"turbofan_opt": [["--turbo", "--always-opt"]],
"noturbofan": [["--no-turbo"]], "noturbofan": [["--no-turbo"]],
"fullcode": [["--noopt", "--no-turbo"]], "fullcode": [["--noopt", "--no-turbo"]],
# No optimization means disable all optimizations. OptimizeFunctionOnNextCall # No optimization means disable all optimizations. OptimizeFunctionOnNextCall
...@@ -22,7 +20,6 @@ ALL_VARIANT_FLAGS = { ...@@ -22,7 +20,6 @@ ALL_VARIANT_FLAGS = {
FAST_VARIANT_FLAGS = { FAST_VARIANT_FLAGS = {
"default": [[]], "default": [[]],
"stress": [["--stress-opt"]], "stress": [["--stress-opt"]],
"turbofan": [["--turbo"]],
"noturbofan": [["--no-turbo"]], "noturbofan": [["--no-turbo"]],
"fullcode": [["--noopt", "--no-turbo"]], "fullcode": [["--noopt", "--no-turbo"]],
# No optimization means disable all optimizations. OptimizeFunctionOnNextCall # No optimization means disable all optimizations. OptimizeFunctionOnNextCall
...@@ -33,6 +30,5 @@ FAST_VARIANT_FLAGS = { ...@@ -33,6 +30,5 @@ FAST_VARIANT_FLAGS = {
"wasm_traps": [["--wasm_guard_pages", "--wasm_trap_handler", "--invoke-weak-callbacks"]], "wasm_traps": [["--wasm_guard_pages", "--wasm_trap_handler", "--invoke-weak-callbacks"]],
} }
ALL_VARIANTS = set(["default", "stress", "turbofan", "turbofan_opt", ALL_VARIANTS = set(["default", "stress", "noturbofan", "fullcode",
"noturbofan", "fullcode", "nooptimization", "asm_wasm", "nooptimization", "asm_wasm", "wasm_traps"])
"wasm_traps"])
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment