Commit 18b28402 authored by Maya Lekova's avatar Maya Lekova Committed by Commit Bot

[test] Remove redundant API test with max-old-space-size limit

Remove the test-api/InitializeDefaultIsolateOnSecondaryThread_ResourceConstraints
test which was setting max-old-space-size limit without acutally using it. This
caused repetitive failures, resulting in the test being effectively disabled.

Bug: v8:8521

R=ulan@chromium.org, yangguo@chromium.org

Change-Id: Iad39cc95df86963d256816bf56d0bc5f62f7d5c9
Reviewed-on: https://chromium-review.googlesource.com/c/1356506Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57964}
parent 7e5cac2c
......@@ -238,9 +238,6 @@
'test-serialize/CustomSnapshotDataBlobWithWarmup': [SKIP],
'test-serialize/SnapshotDataBlobWithWarmup': [SKIP],
# https://crbug.com/v8/8521
'test-api/InitializeDefaultIsolateOnSecondaryThread_ResourceConstraints': [SKIP],
# https://crbug.com/v8/7763
'test-lockers/ExtensionsRegistration': [SKIP],
}], # 'no_snap == True'
......
......@@ -21257,7 +21257,6 @@ TEST(IsolateDifferentContexts) {
class InitDefaultIsolateThread : public v8::base::Thread {
public:
enum TestCase {
SetResourceConstraints,
SetFatalHandler,
SetCounterFunction,
SetCreateHistogramFunction,
......@@ -21272,22 +21271,9 @@ class InitDefaultIsolateThread : public v8::base::Thread {
void Run() override {
v8::Isolate::CreateParams create_params;
create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
switch (testCase_) {
case SetResourceConstraints: {
create_params.constraints.set_max_semi_space_size_in_kb(1024);
create_params.constraints.set_max_old_space_size(8);
break;
}
default:
break;
}
v8::Isolate* isolate = v8::Isolate::New(create_params);
isolate->Enter();
switch (testCase_) {
case SetResourceConstraints:
// Already handled in pre-Isolate-creation block.
break;
case SetFatalHandler:
isolate->SetFatalErrorHandler(nullptr);
break;
......@@ -21324,10 +21310,6 @@ static void InitializeTestHelper(InitDefaultIsolateThread::TestCase testCase) {
CHECK(thread.result());
}
TEST(InitializeDefaultIsolateOnSecondaryThread_ResourceConstraints) {
InitializeTestHelper(InitDefaultIsolateThread::SetResourceConstraints);
}
TEST(InitializeDefaultIsolateOnSecondaryThread_FatalHandler) {
InitializeTestHelper(InitDefaultIsolateThread::SetFatalHandler);
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment