Commit 17f74118 authored by Maciej Goszczycki's avatar Maciej Goszczycki Committed by Commit Bot

[cleanup] Remove unused 'executable' argument from InitializePage

Bug: v8:9183
Change-Id: I53ad134b6dc8611ba439b78f27bfc8e56a82169e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1635697Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
Commit-Queue: Maciej Goszczycki <goszczycki@google.com>
Cr-Commit-Position: refs/heads/master@{#61941}
parent 00868103
...@@ -768,7 +768,7 @@ MemoryChunk* MemoryChunk::Initialize(Heap* heap, Address base, size_t size, ...@@ -768,7 +768,7 @@ MemoryChunk* MemoryChunk::Initialize(Heap* heap, Address base, size_t size,
return chunk; return chunk;
} }
Page* PagedSpace::InitializePage(MemoryChunk* chunk, Executability executable) { Page* PagedSpace::InitializePage(MemoryChunk* chunk) {
Page* page = static_cast<Page*>(chunk); Page* page = static_cast<Page*>(chunk);
DCHECK_EQ(MemoryChunkLayout::AllocatableMemoryInMemoryChunk( DCHECK_EQ(MemoryChunkLayout::AllocatableMemoryInMemoryChunk(
page->owner()->identity()), page->owner()->identity()),
...@@ -783,8 +783,7 @@ Page* PagedSpace::InitializePage(MemoryChunk* chunk, Executability executable) { ...@@ -783,8 +783,7 @@ Page* PagedSpace::InitializePage(MemoryChunk* chunk, Executability executable) {
return page; return page;
} }
Page* SemiSpace::InitializePage(MemoryChunk* chunk, Executability executable) { Page* SemiSpace::InitializePage(MemoryChunk* chunk) {
DCHECK_EQ(executable, Executability::NOT_EXECUTABLE);
bool in_to_space = (id() != kFromSpace); bool in_to_space = (id() != kFromSpace);
chunk->SetFlag(in_to_space ? MemoryChunk::TO_PAGE : MemoryChunk::FROM_PAGE); chunk->SetFlag(in_to_space ? MemoryChunk::TO_PAGE : MemoryChunk::FROM_PAGE);
Page* page = static_cast<Page*>(chunk); Page* page = static_cast<Page*>(chunk);
...@@ -856,7 +855,7 @@ Page* Page::ConvertNewToOld(Page* old_page) { ...@@ -856,7 +855,7 @@ Page* Page::ConvertNewToOld(Page* old_page) {
OldSpace* old_space = old_page->heap()->old_space(); OldSpace* old_space = old_page->heap()->old_space();
old_page->set_owner(old_space); old_page->set_owner(old_space);
old_page->SetFlags(0, static_cast<uintptr_t>(~0)); old_page->SetFlags(0, static_cast<uintptr_t>(~0));
Page* new_page = old_space->InitializePage(old_page, NOT_EXECUTABLE); Page* new_page = old_space->InitializePage(old_page);
old_space->AddPage(new_page); old_space->AddPage(new_page);
return new_page; return new_page;
} }
...@@ -1251,7 +1250,7 @@ Page* MemoryAllocator::AllocatePage(size_t size, SpaceType* owner, ...@@ -1251,7 +1250,7 @@ Page* MemoryAllocator::AllocatePage(size_t size, SpaceType* owner,
chunk = AllocateChunk(size, size, executable, owner); chunk = AllocateChunk(size, size, executable, owner);
} }
if (chunk == nullptr) return nullptr; if (chunk == nullptr) return nullptr;
return owner->InitializePage(chunk, executable); return owner->InitializePage(chunk);
} }
template EXPORT_TEMPLATE_DEFINE(V8_EXPORT_PRIVATE) template EXPORT_TEMPLATE_DEFINE(V8_EXPORT_PRIVATE)
......
...@@ -2211,7 +2211,7 @@ class V8_EXPORT_PRIVATE PagedSpace ...@@ -2211,7 +2211,7 @@ class V8_EXPORT_PRIVATE PagedSpace
void RefineAllocatedBytesAfterSweeping(Page* page); void RefineAllocatedBytesAfterSweeping(Page* page);
Page* InitializePage(MemoryChunk* chunk, Executability executable); Page* InitializePage(MemoryChunk* chunk);
void ReleasePage(Page* page); void ReleasePage(Page* page);
...@@ -2465,7 +2465,7 @@ class SemiSpace : public Space { ...@@ -2465,7 +2465,7 @@ class SemiSpace : public Space {
void RemovePage(Page* page); void RemovePage(Page* page);
void PrependPage(Page* page); void PrependPage(Page* page);
Page* InitializePage(MemoryChunk* chunk, Executability executable); Page* InitializePage(MemoryChunk* chunk);
// Age mark accessors. // Age mark accessors.
Address age_mark() { return age_mark_; } Address age_mark() { return age_mark_; }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment