Commit 17ad3ae4 authored by jgruber's avatar jgruber Committed by Commit Bot

[builtins] Declare builtin symbols

This is an attempt to make builtin symbols visible in crash stack
traces. Can be reverted if unsuccessful.

TBR=yangguo@chromium.org

Bug: v8:6666, v8:7722
Change-Id: I74a44b23d1a39d8885992f73d7ed02baf43cfa30
Reviewed-on: https://chromium-review.googlesource.com/1170830Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55054}
parent 3a838016
...@@ -190,9 +190,13 @@ class SnapshotWriter { ...@@ -190,9 +190,13 @@ class SnapshotWriter {
// stream. // stream.
if (is_default_variant) { if (is_default_variant) {
// Create nicer symbol names for the default mode. // Create nicer symbol names for the default mode.
fprintf(fp, "__asm__(\"\" V8_ASM_DECLARE(\"Builtins_%s\"));\n",
i::Builtins::name(i));
fprintf(fp, "__asm__(V8_ASM_LABEL(\"Builtins_%s\"));\n", fprintf(fp, "__asm__(V8_ASM_LABEL(\"Builtins_%s\"));\n",
i::Builtins::name(i)); i::Builtins::name(i));
} else { } else {
fprintf(fp, "__asm__(\"\" V8_ASM_DECLARE(\"%s_Builtins_%s\"));\n",
embedded_variant, i::Builtins::name(i));
fprintf(fp, "__asm__(V8_ASM_LABEL(\"%s_Builtins_%s\"));\n", fprintf(fp, "__asm__(V8_ASM_LABEL(\"%s_Builtins_%s\"));\n",
embedded_variant, i::Builtins::name(i)); embedded_variant, i::Builtins::name(i));
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment