The time spent in GCPrologue callbacks and GCEpilogue callbacks should be measured as EXTERNAL time

BUG=

Review URL: https://codereview.chromium.org/11817044
Patch from Kentaro Hara <haraken@chromium.org>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13370 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent cc3bb603
...@@ -892,9 +892,12 @@ bool Heap::PerformGarbageCollection(GarbageCollector collector, ...@@ -892,9 +892,12 @@ bool Heap::PerformGarbageCollection(GarbageCollector collector,
GCType gc_type = GCType gc_type =
collector == MARK_COMPACTOR ? kGCTypeMarkSweepCompact : kGCTypeScavenge; collector == MARK_COMPACTOR ? kGCTypeMarkSweepCompact : kGCTypeScavenge;
for (int i = 0; i < gc_prologue_callbacks_.length(); ++i) { {
if (gc_type & gc_prologue_callbacks_[i].gc_type) { GCTracer::Scope scope(tracer, GCTracer::Scope::EXTERNAL);
gc_prologue_callbacks_[i].callback(gc_type, kNoGCCallbackFlags); for (int i = 0; i < gc_prologue_callbacks_.length(); ++i) {
if (gc_type & gc_prologue_callbacks_[i].gc_type) {
gc_prologue_callbacks_[i].callback(gc_type, kNoGCCallbackFlags);
}
} }
} }
...@@ -1002,10 +1005,13 @@ bool Heap::PerformGarbageCollection(GarbageCollector collector, ...@@ -1002,10 +1005,13 @@ bool Heap::PerformGarbageCollection(GarbageCollector collector,
amount_of_external_allocated_memory_; amount_of_external_allocated_memory_;
} }
GCCallbackFlags callback_flags = kNoGCCallbackFlags; {
for (int i = 0; i < gc_epilogue_callbacks_.length(); ++i) { GCTracer::Scope scope(tracer, GCTracer::Scope::EXTERNAL);
if (gc_type & gc_epilogue_callbacks_[i].gc_type) { GCCallbackFlags callback_flags = kNoGCCallbackFlags;
gc_epilogue_callbacks_[i].callback(gc_type, callback_flags); for (int i = 0; i < gc_epilogue_callbacks_.length(); ++i) {
if (gc_type & gc_epilogue_callbacks_[i].gc_type) {
gc_epilogue_callbacks_[i].callback(gc_type, callback_flags);
}
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment