Commit 167053b0 authored by zhengxing.li's avatar zhengxing.li Committed by Commit bot

X87: [turbofan] Pass Runtime::FunctionId to TrapIf and TrapUnless isel methods.

  port b29d6d49(r41790)

  original commit message:
  This also fixes UBSAN failures due to improper OpParameter<> calls.

BUG=

Review-Url: https://codereview.chromium.org/2681763002
Cr-Commit-Position: refs/heads/master@{#43022}
parent 56bf7dbd
......@@ -1590,16 +1590,16 @@ void InstructionSelector::VisitDeoptimizeUnless(Node* node) {
VisitWordCompareZero(this, node, node->InputAt(0), &cont);
}
void InstructionSelector::VisitTrapIf(Node* node) {
FlagsContinuation cont = FlagsContinuation::ForTrap(
kNotEqual, OpParameter<Runtime::FunctionId>(node->op()),
node->InputAt(1));
void InstructionSelector::VisitTrapIf(Node* node, Runtime::FunctionId func_id) {
FlagsContinuation cont =
FlagsContinuation::ForTrap(kNotEqual, func_id, node->InputAt(1));
VisitWordCompareZero(this, node, node->InputAt(0), &cont);
}
void InstructionSelector::VisitTrapUnless(Node* node) {
FlagsContinuation cont = FlagsContinuation::ForTrap(
kEqual, OpParameter<Runtime::FunctionId>(node->op()), node->InputAt(1));
void InstructionSelector::VisitTrapUnless(Node* node,
Runtime::FunctionId func_id) {
FlagsContinuation cont =
FlagsContinuation::ForTrap(kEqual, func_id, node->InputAt(1));
VisitWordCompareZero(this, node, node->InputAt(0), &cont);
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment