Remove --harmony-arrow-functions flag

Arrow functions have been enabled by default since the 4.5 branch.

Review URL: https://codereview.chromium.org/1373633002

Cr-Commit-Position: refs/heads/master@{#31031}

src/bootstrapper.cc

@@ -1854,7 +1854,6 @@ void Bootstrapper::ExportExperimentalFromRuntime(Isolate* isolate,
 
 EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_modules)
 EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_array_includes)
-EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_arrow_functions)
 EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_proxies)
 EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_sloppy)
 EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_sloppy_function)
@@ -2554,7 +2553,6 @@ bool Genesis::InstallExperimentalNatives() {
   static const char* harmony_modules_natives[] = {nullptr};
   static const char* harmony_regexps_natives[] = {"native harmony-regexp.js",
                                                   nullptr};
-  static const char* harmony_arrow_functions_natives[] = {nullptr};
   static const char* harmony_tostring_natives[] = {"native harmony-tostring.js",
                                                    nullptr};
   static const char* harmony_sloppy_natives[] = {nullptr};

src/flag-definitions.h

@@ -210,7 +210,6 @@ DEFINE_BOOL(legacy_const, true, "legacy semantics for const in sloppy mode")
 
 // Features that are shipping (turned on by default, but internal flag remains).
 #define HARMONY_SHIPPING(V)                                     \
-  V(harmony_arrow_functions, "harmony arrow functions")         \
   V(harmony_array_includes, "harmony Array.prototype.includes") \
   V(harmony_new_target, "harmony new.target")                   \
   V(harmony_object_observe, "harmony Object.observe")           \

src/parser.cc

@@ -913,7 +913,6 @@ Parser::Parser(ParseInfo* info)
   DCHECK(!info->script().is_null() || info->source_stream() != NULL);
   set_allow_lazy(info->allow_lazy_parsing());
   set_allow_natives(FLAG_allow_natives_syntax || info->is_native());
-  set_allow_harmony_arrow_functions(FLAG_harmony_arrow_functions);
   set_allow_harmony_sloppy(FLAG_harmony_sloppy);
   set_allow_harmony_sloppy_function(FLAG_harmony_sloppy_function);
   set_allow_harmony_sloppy_let(FLAG_harmony_sloppy_let);
@@ -4732,7 +4731,6 @@ PreParser::PreParseResult Parser::ParseLazyFunctionBodyWithPreParser(
     reusable_preparser_->set_allow_lazy(true);
 #define SET_ALLOW(name) reusable_preparser_->set_allow_##name(allow_##name());
     SET_ALLOW(natives);
-    SET_ALLOW(harmony_arrow_functions);
     SET_ALLOW(harmony_sloppy);
     SET_ALLOW(harmony_sloppy_let);
     SET_ALLOW(harmony_rest_parameters);

src/preparser.h

@@ -107,7 +107,6 @@ class ParserBase : public Traits {
         stack_overflow_(false),
         allow_lazy_(false),
         allow_natives_(false),
-        allow_harmony_arrow_functions_(false),
         allow_harmony_sloppy_(false),
         allow_harmony_sloppy_function_(false),
         allow_harmony_sloppy_let_(false),
@@ -126,7 +125,6 @@ class ParserBase : public Traits {
 
   ALLOW_ACCESSORS(lazy);
   ALLOW_ACCESSORS(natives);
-  ALLOW_ACCESSORS(harmony_arrow_functions);
   ALLOW_ACCESSORS(harmony_sloppy);
   ALLOW_ACCESSORS(harmony_sloppy_function);
   ALLOW_ACCESSORS(harmony_sloppy_let);
@@ -827,7 +825,6 @@ class ParserBase : public Traits {
 
   bool allow_lazy_;
   bool allow_natives_;
-  bool allow_harmony_arrow_functions_;
   bool allow_harmony_sloppy_;
   bool allow_harmony_sloppy_function_;
   bool allow_harmony_sloppy_let_;
@@ -2915,7 +2912,7 @@ ParserBase<Traits>::ParseAssignmentExpression(bool accept_IN,
   }
   ExpressionT expression = this->ParseConditionalExpression(
       accept_IN, &arrow_formals_classifier, CHECK_OK);
-  if (allow_harmony_arrow_functions() && peek() == Token::ARROW) {
+  if (peek() == Token::ARROW) {
     BindingPatternUnexpectedToken(classifier);
     ValidateArrowFormalParameters(&arrow_formals_classifier, expression,
                                   parenthesized_formals, CHECK_OK);

test/cctest/test-asm-validator.cc

@@ -55,7 +55,6 @@ std::string Validate(Zone* zone, const char* source,
 
   i::ParseInfo info(zone, script);
   i::Parser parser(&info);
-  parser.set_allow_harmony_arrow_functions(true);
   parser.set_allow_harmony_sloppy(true);
   info.set_global();
   info.set_lazy(false);

test/cctest/test-ast-expression-visitor.cc

@@ -31,7 +31,6 @@ static void CollectTypes(HandleAndZoneScope* handles, const char* source,
 
   i::ParseInfo info(handles->main_zone(), script);
   i::Parser parser(&info);
-  parser.set_allow_harmony_arrow_functions(true);
   parser.set_allow_harmony_sloppy(true);
   info.set_global();
   info.set_lazy(false);

test/cctest/test-typing-reset.cc

@@ -274,7 +274,6 @@ TEST(ResetTypingInfo) {
 
   i::ParseInfo info(handles.main_zone(), script);
   i::Parser parser(&info);
-  parser.set_allow_harmony_arrow_functions(true);
   parser.set_allow_harmony_sloppy(true);
   info.set_global();
   info.set_lazy(false);

test/message/arrow-bare-rest-param.js

@@ -2,6 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
-// Flags: --harmony-rest-parameters --harmony-arrow-functions
+// Flags: --harmony-rest-parameters
 
 ...x => 10

test/message/arrow-formal-parameters.js

@@ -2,6 +2,4 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --harmony-arrow-functions
-
 (b, a, a, d) => a

test/message/arrow-formal-parameters.out

-*%(basename)s:7: SyntaxError: Duplicate parameter name not allowed in this context
+*%(basename)s:5: SyntaxError: Duplicate parameter name not allowed in this context
 (b, a, a, d) => a
            ^
 SyntaxError: Duplicate parameter name not allowed in this context

test/message/arrow-missing.js

@@ -2,6 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
-// Flags: --harmony-rest-parameters --harmony-arrow-functions
+// Flags: --harmony-rest-parameters
 
 function foo() { return(); }

test/message/arrow-param-after-rest-2.js

@@ -2,6 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
-// Flags: --harmony-rest-parameters --harmony-arrow-functions
+// Flags: --harmony-rest-parameters
 
 (w, ...x, y) => 10

test/message/arrow-param-after-rest.js

@@ -2,6 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
-// Flags: --harmony-rest-parameters --harmony-arrow-functions
+// Flags: --harmony-rest-parameters
 
 (...x, y) => 10

test/message/arrow-strict-eval-bare-parameter.js

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-//
-// Flags: --harmony-arrow-functions
 
 "use strict";
 eval => 42

test/message/arrow-strict-eval-bare-parameter.out

-*%(basename)s:8: SyntaxError: Unexpected eval or arguments in strict mode
+*%(basename)s:6: SyntaxError: Unexpected eval or arguments in strict mode
 eval => 42
 ^^^^
 SyntaxError: Unexpected eval or arguments in strict mode

test/message/arrow-two-rest-params.js

@@ -2,6 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
-// Flags: --harmony-rest-parameters --harmony-arrow-functions
+// Flags: --harmony-rest-parameters
 
 (w, ...x, ...y) => 10

test/message/invalid-spread-2.js

@@ -2,6 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
-// Flags: --harmony-rest-parameters --harmony-arrow-functions
+// Flags: --harmony-rest-parameters
 
 (x, ...y, z)

test/message/invalid-spread.js

@@ -2,6 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
-// Flags: --harmony-rest-parameters --harmony-arrow-functions
+// Flags: --harmony-rest-parameters
 
 (x, ...y)

test/mjsunit/harmony/arrow-functions-lexical-arguments.js → test/mjsunit/es6/arrow-functions-lexical-arguments.js

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --harmony-arrow-functions
-
 
 (function testInFunctionDeclaration() {
   var calls = 0;

test/mjsunit/harmony/arrow-functions-this.js → test/mjsunit/es6/arrow-functions-this.js

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --harmony-arrow-functions
-
 var object = {};
 var global = this;
 var call = Function.call.bind(Function.call);

test/mjsunit/harmony/arrow-functions.js → test/mjsunit/es6/arrow-functions.js

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --harmony-arrow-functions
-
 // Arrow functions are like functions, except they throw when using the
 // "new" operator on them.
 assertEquals("function", typeof (() => {}));

test/mjsunit/harmony/object-literals-super.js → test/mjsunit/es6/object-literals-super.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --harmony-arrow-functions --allow-natives-syntax
+// Flags: --allow-natives-syntax
 
 
 (function TestHomeObject() {

test/mjsunit/harmony/regress/regress-3501.js → test/mjsunit/es6/regress/regress-3501.js

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --harmony-arrow-functions
-
 // See: http://code.google.com/p/v8/issues/detail?id=3501
 
 "use strict";

test/mjsunit/harmony/regress/regress-4056.js → test/mjsunit/es6/regress/regress-4056.js

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --harmony-arrow-functions
-
 function strictFunctionArrowEval(s) {
   "use strict";
   return (()=>eval(s))();

test/mjsunit/harmony/regress/regress-4160.js → test/mjsunit/es6/regress/regress-4160.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --harmony-arrow-functions --allow-natives-syntax
+// Flags: --allow-natives-syntax
 
 (function(x) {
   (function(x) {

test/mjsunit/harmony/regress/regress-arrow-duplicate-params.js → test/mjsunit/es6/regress/regress-arrow-duplicate-params.js

@@ -2,6 +2,4 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --harmony-arrow-functions
-
 assertThrows("(x, x, y) => 10;", SyntaxError);

test/mjsunit/harmony/regress/regress-crbug-465671-null.js → test/mjsunit/es6/regress/regress-crbug-465671-null.js

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --harmony-arrow-functions
-
 // This used to trigger a segfault because of NULL being accessed.
 function f() {
   var a = [10];

test/mjsunit/harmony/regress/regress-crbug-465671.js → test/mjsunit/es6/regress/regress-crbug-465671.js

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --harmony-arrow-functions
-
 // This used to trigger crash because of an unhandled stack overflow.
 function f() {
   var a = [10];

test/mjsunit/harmony/arrow-rest-params-lazy-parsing.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --harmony-rest-parameters --harmony-arrow-functions
+// Flags: --harmony-rest-parameters
 // Flags: --min-preparse-length=0
 
 (function testRestIndex() {

test/mjsunit/harmony/arrow-rest-params.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --harmony-rest-parameters --harmony-arrow-functions
+// Flags: --harmony-rest-parameters
 
 (function testRestIndex() {
   assertEquals(5, ((...args) => args.length)(1,2,3,4,5));

test/mjsunit/harmony/default-parameters.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --harmony-default-parameters --harmony-arrow-functions
+// Flags: --harmony-default-parameters
 // Flags: --harmony-rest-parameters --harmony-destructuring
 
 

test/mjsunit/harmony/destructuring-parameters-literalcount-nolazy.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 //
 // Flags: --harmony-destructuring
-// Flags: --harmony-arrow-functions --no-lazy --allow-natives-syntax
+// Flags: --no-lazy --allow-natives-syntax
 
 
 var t1 = [1];

test/mjsunit/harmony/destructuring-parameters-literalcount.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 //
 // Flags: --harmony-destructuring
-// Flags: --harmony-arrow-functions --allow-natives-syntax
+// Flags: --allow-natives-syntax
 
 
 var t1 = [1];

test/mjsunit/harmony/destructuring.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
-// Flags: --harmony-destructuring --harmony-arrow-functions
+// Flags: --harmony-destructuring
 // Flags: --harmony-default-parameters --harmony-rest-parameters
 
 (function TestObjectLiteralPattern() {

test/mjsunit/harmony/new-target.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --harmony-new-target --harmony-reflect --harmony-destructuring
-// Flags: --harmony-rest-parameters --harmony-arrow-functions
+// Flags: --harmony-rest-parameters
 
 
 (function TestClass() {

test/mjsunit/harmony/regress/regress-4211.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
-// Flags: --harmony-arrow-functions --harmony-rest-parameters
+// Flags: --harmony-rest-parameters
 
 assertThrows("()=>{}()", SyntaxError);
 assertThrows("x=>{}()", SyntaxError);

test/mjsunit/harmony/regress/regress-508074.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --harmony-rest-parameters --harmony-arrow-functions
+// Flags: --harmony-rest-parameters
 // Flags: --allow-natives-syntax
 
 var f = (a, b, ...c) => {

test/mjsunit/harmony/rest-params-lazy-parsing.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --harmony-rest-parameters --harmony-arrow-functions
+// Flags: --harmony-rest-parameters
 // Flags: --min-preparse-length=0
 
 function variadic(co, ...values) {

test/mjsunit/harmony/super.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --harmony-arrow-functions --allow-natives-syntax
+// Flags: --allow-natives-syntax
 // Flags: --harmony-spread-calls --harmony-destructuring
 // Flags: --harmony-rest-parameters --harmony-sloppy
 

test/mjsunit/strong/classes.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --strong-mode --harmony-arrow-functions
+// Flags: --strong-mode
 
 'use strong';
 

test/mjsunit/strong/declaration-after-use.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --strong-mode --harmony-rest-parameters --harmony-arrow-functions
+// Flags: --strong-mode --harmony-rest-parameters
 
 // Note that it's essential for these tests that the reference is inside dead
 // code (because we already produce ReferenceErrors for run-time unresolved

test/mjsunit/strong/destructuring.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 //
 // Flags: --harmony-destructuring
-// Flags: --harmony-arrow-functions --strong-mode --allow-natives-syntax
+// Flags: --strong-mode --allow-natives-syntax
 
 (function() {
   var f = (function() {

test/mjsunit/strong/function-arity.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --strong-mode --harmony-arrow-functions --harmony-reflect
+// Flags: --strong-mode --harmony-reflect
 // Flags: --harmony-spread-calls --harmony-rest-parameters --allow-natives-syntax
 
 'use strict';

test/mjsunit/strong/literals.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --strong-mode --allow-natives-syntax
-// Flags: --harmony-arrow-functions --harmony-rest-parameters
+// Flags: --harmony-rest-parameters
 // Flags: --harmony-destructuring --harmony-spread-arrays
 
 'use strict';

test/mjsunit/strong/mutually-recursive-classes.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --strong-mode --harmony-arrow-functions
+// Flags: --strong-mode
 "use strict"
 
 let prologue_dead = "(function outer() { if (false) { ";

test/mjsunit/strong/undefined.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --strong-mode --harmony-sloppy --harmony-arrow-functions
+// Flags: --strong-mode --harmony-sloppy
 
 // Repurposing the strict mode 'eval' and 'arguments' tests to test for correct
 // behaviour of 'undefined' as an identifier in strong mode.

test/mjsunit/this-dynamic-lookup.js

@@ -2,7 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --harmony-arrow-functions
 // NO HARNESS
 
 var globalEval = eval;