Commit 16055d51 authored by machenbach's avatar machenbach Committed by Commit bot

Revert of Speedup access to global_proxy.* attributes/accessors. (patchset #3...

Revert of Speedup access to global_proxy.* attributes/accessors. (patchset #3 id:80001 of https://codereview.chromium.org/2403003002/ )

Reason for revert:
Blocks roll:
https://codereview.chromium.org/2406213002/

Original issue's description:
> Speedup access to global_proxy.* attributes/accessors.
>
> Using a global proxy (e.g. 'window.f', 'w.f' or 'this.f') is considerably slower than evaluating just 'f'. This CL aims to perform the necessary checks at compile time and inline the accesses.
>
> This is a follow-on CL to crrev.com/2369933005:
> - The initial upload is crrev.com/2369933005 + a rebase.
> - The remaining issues are the fixes requested by the reviewers on that CL.
>
> BUG=chromium:634276
>
> Committed: https://crrev.com/8f43d748272536117008aa6a1b53ea52126261c1
> Cr-Commit-Position: refs/heads/master@{#40153}

TBR=jochen@chromium.org,verwaest@chromium.org,vogelheim@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:634276

Review-Url: https://codereview.chromium.org/2408133002
Cr-Commit-Position: refs/heads/master@{#40171}
parent 65716011
This diff is collapsed.
...@@ -2364,15 +2364,13 @@ class HOptimizedGraphBuilder : public HGraphBuilder, ...@@ -2364,15 +2364,13 @@ class HOptimizedGraphBuilder : public HGraphBuilder,
#undef DECLARE_VISIT #undef DECLARE_VISIT
private: private:
bool CanInlineGlobalPropertyAccess(Variable* var, LookupIterator* it, // Helpers for flow graph construction.
PropertyAccessType access_type); enum GlobalPropertyAccess {
kUseCell,
bool CanInlineGlobalPropertyAccess(LookupIterator* it, kUseGeneric
PropertyAccessType access_type); };
GlobalPropertyAccess LookupGlobalProperty(Variable* var, LookupIterator* it,
void InlineGlobalPropertyLoad(LookupIterator* it, BailoutId ast_id); PropertyAccessType access_type);
void InlineGlobalPropertyStore(LookupIterator* it, HValue* value,
BailoutId ast_id);
void EnsureArgumentsArePushedForAccess(); void EnsureArgumentsArePushedForAccess();
bool TryArgumentsAccess(Property* expr); bool TryArgumentsAccess(Property* expr);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment