Skip to content

V
V8
Commit 1540a014 authored by Igor Sheludko's avatar Igor Sheludko Committed by Commit Bot
Browse files
Options

[zone] Cleanup zone allocations in src/compiler and tests, pt.2 

... by migrating old-style code
  MyObject* obj = new (zone) MyObject(...)

to the new style
  MyObject* obj = zone->New<MyObject>(...)

Bug: v8:10689
Change-Id: Iec2b3102bd35ad7e50b90882ade78d27999a71f2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2288866Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68803}
parent 3af53301
Hide whitespace changes
Inline Side-by-side
Showing with 219 additions and 214 deletions
src/compiler/bytecode-analysis.cc
View file @ 1540a014
......@@ -20,8 +20,8 @@ using interpreter::OperandType;
BytecodeLoopAssignments::BytecodeLoopAssignments(int parameter_count,
int register_count, Zone* zone)
: parameter_count_(parameter_count),
bit_vector_(new (zone)
BitVector(parameter_count + register_count, zone)) {}
bit_vector_(
zone->New<BitVector>(parameter_count + register_count, zone)) {}
void BytecodeLoopAssignments::Add(interpreter::Register r) {
if (r.is_parameter()) {
......
src/compiler/bytecode-graph-builder.cc
View file @ 1540a014
......@@ -514,6 +514,8 @@ class BytecodeGraphBuilder::Environment : public ZoneObject {
const BytecodeLivenessState* liveness);
private:
friend Zone;
explicit Environment(const Environment* copy);
bool StateValuesRequireUpdate(Node** state_values, Node** values, int count);
......@@ -707,7 +709,7 @@ void BytecodeGraphBuilder::Environment::RecordAfterState(
}
BytecodeGraphBuilder::Environment* BytecodeGraphBuilder::Environment::Copy() {
return new (zone()) Environment(this);
return zone()->New<Environment>(this);
}
void BytecodeGraphBuilder::Environment::Merge(
......
src/compiler/bytecode-liveness-map.cc
View file @ 1540a014
......@@ -9,8 +9,8 @@ namespace internal {
namespace compiler {
BytecodeLiveness::BytecodeLiveness(int register_count, Zone* zone)
: in(new (zone) BytecodeLivenessState(register_count, zone)),
out(new (zone) BytecodeLivenessState(register_count, zone)) {}
: in(zone->New<BytecodeLivenessState>(register_count, zone)),
out(zone->New<BytecodeLivenessState>(register_count, zone)) {}
BytecodeLivenessMap::BytecodeLivenessMap(int bytecode_size, Zone* zone)
: liveness_map_(base::bits::RoundUpToPowerOfTwo32(bytecode_size / 4 + 1),
......
src/compiler/c-linkage.cc
View file @ 1540a014
......@@ -222,7 +222,7 @@ CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone,
LinkageLocation target_loc = LinkageLocation::ForAnyRegister(target_type);
flags |= CallDescriptor::kNoAllocate;
return new (zone) CallDescriptor( // --
return zone->New<CallDescriptor>( // --
CallDescriptor::kCallAddress, // kind
target_type, // target MachineType
target_loc, // target location
......
src/compiler/code-assembler.cc
View file @ 1540a014
......@@ -77,7 +77,7 @@ CodeAssemblerState::CodeAssemblerState(Isolate* isolate, Zone* zone,
PoisoningMitigationLevel poisoning_level,
int32_t builtin_index)
: raw_assembler_(new RawMachineAssembler(
isolate, new (zone) Graph(zone), call_descriptor,
isolate, zone->New<Graph>(zone), call_descriptor,
MachineType::PointerRepresentation(),
InstructionSelector::SupportedMachineOperatorFlags(),
InstructionSelector::AlignmentRequirements(), poisoning_level)),
......@@ -86,9 +86,9 @@ CodeAssemblerState::CodeAssemblerState(Isolate* isolate, Zone* zone,
builtin_index_(builtin_index),
code_generated_(false),
variables_(zone),
jsgraph_(new (zone) JSGraph(
jsgraph_(zone->New<JSGraph>(
isolate, raw_assembler_->graph(), raw_assembler_->common(),
new (zone) JSOperatorBuilder(zone), raw_assembler_->simplified(),
zone->New<JSOperatorBuilder>(zone), raw_assembler_->simplified(),
raw_assembler_->machine())) {}
CodeAssemblerState::~CodeAssemblerState() = default;
......@@ -135,7 +135,7 @@ void CodeAssembler::BreakOnNode(int node_id) {
Graph* graph = raw_assembler()->graph();
Zone* zone = graph->zone();
GraphDecorator* decorator =
new (zone) BreakOnNodeDecorator(static_cast<NodeId>(node_id));
zone->New<BreakOnNodeDecorator>(static_cast<NodeId>(node_id));
graph->AddDecorator(decorator);
}
......@@ -1199,9 +1199,7 @@ void CodeAssembler::Branch(TNode<BoolT> condition,
void CodeAssembler::Switch(Node* index, Label* default_label,
const int32_t* case_values, Label** case_labels,
size_t case_count) {
RawMachineLabel** labels =
new (zone()->New(sizeof(RawMachineLabel*) * case_count))
RawMachineLabel*[case_count];
RawMachineLabel** labels = zone()->NewArray<RawMachineLabel*>(case_count);
for (size_t i = 0; i < case_count; ++i) {
labels[i] = case_labels[i]->label_;
case_labels[i]->MergeVariables();
......@@ -1275,8 +1273,8 @@ bool CodeAssemblerVariable::ImplComparator::operator()(
CodeAssemblerVariable::CodeAssemblerVariable(CodeAssembler* assembler,
MachineRepresentation rep)
: impl_(new (assembler->zone())
Impl(rep, assembler->state()->NextVariableId())),
: impl_(assembler->zone()->New<Impl>(rep,
assembler->state()->NextVariableId())),
state_(assembler->state()) {
state_->variables_.insert(impl_);
}
......@@ -1292,8 +1290,8 @@ CodeAssemblerVariable::CodeAssemblerVariable(CodeAssembler* assembler,
CodeAssemblerVariable::CodeAssemblerVariable(CodeAssembler* assembler,
AssemblerDebugInfo debug_info,
MachineRepresentation rep)
: impl_(new (assembler->zone())
Impl(rep, assembler->state()->NextVariableId())),
: impl_(assembler->zone()->New<Impl>(rep,
assembler->state()->NextVariableId())),
state_(assembler->state()) {
impl_->set_debug_info(debug_info);
state_->variables_.insert(impl_);
......@@ -1361,10 +1359,9 @@ CodeAssemblerLabel::CodeAssemblerLabel(CodeAssembler* assembler,
merge_count_(0),
state_(assembler->state()),
label_(nullptr) {
void* buffer = assembler->zone()->New(sizeof(RawMachineLabel));
label_ = new (buffer)
RawMachineLabel(type == kDeferred ? RawMachineLabel::kDeferred
: RawMachineLabel::kNonDeferred);
label_ = assembler->zone()->New<RawMachineLabel>(
type == kDeferred ? RawMachineLabel::kDeferred
: RawMachineLabel::kNonDeferred);
for (size_t i = 0; i < vars_count; ++i) {
variable_phis_[vars[i]->impl_] = nullptr;
}
......
src/compiler/common-operator.cc
View file @ 1540a014
......@@ -144,7 +144,7 @@ const Operator* CommonOperatorBuilder::MarkAsSafetyCheck(
const Operator* CommonOperatorBuilder::DelayedStringConstant(
const StringConstantBase* str) {
return new (zone()) Operator1<const StringConstantBase*>(
return zone()->New<Operator1<const StringConstantBase*>>(
IrOpcode::kDelayedStringConstant, Operator::kPure,
"DelayedStringConstant", 0, 0, 0, 1, 0, 0, str);
}
......@@ -916,7 +916,7 @@ const Operator* CommonOperatorBuilder::End(size_t control_input_count) {
break;
}
// Uncached.
return new (zone()) Operator( //--
return zone()->New<Operator>( //--
IrOpcode::kEnd, Operator::kKontrol, // opcode
"End", // name
0, 0, control_input_count, 0, 0, 0); // counts
......@@ -933,7 +933,7 @@ const Operator* CommonOperatorBuilder::Return(int value_input_count) {
break;
}
// Uncached.
return new (zone()) Operator( //--
return zone()->New<Operator>( //--
IrOpcode::kReturn, Operator::kNoThrow, // opcode
"Return", // name
value_input_count + 1, 1, 1, 0, 0, 1); // counts
......@@ -964,7 +964,7 @@ const Operator* CommonOperatorBuilder::Deoptimize(
// Uncached
DeoptimizeParameters parameter(kind, reason, feedback,
IsSafetyCheck::kNoSafetyCheck);
return new (zone()) Operator1<DeoptimizeParameters>( // --
return zone()->New<Operator1<DeoptimizeParameters>>( // --
IrOpcode::kDeoptimize, // opcodes
Operator::kFoldable | Operator::kNoThrow, // properties
"Deoptimize", // name
......@@ -985,7 +985,7 @@ const Operator* CommonOperatorBuilder::DeoptimizeIf(
#undef CACHED_DEOPTIMIZE_IF
// Uncached
DeoptimizeParameters parameter(kind, reason, feedback, is_safety_check);
return new (zone()) Operator1<DeoptimizeParameters>( // --
return zone()->New<Operator1<DeoptimizeParameters>>( // --
IrOpcode::kDeoptimizeIf, // opcode
Operator::kFoldable | Operator::kNoThrow, // properties
"DeoptimizeIf", // name
......@@ -1006,7 +1006,7 @@ const Operator* CommonOperatorBuilder::DeoptimizeUnless(
#undef CACHED_DEOPTIMIZE_UNLESS
// Uncached
DeoptimizeParameters parameter(kind, reason, feedback, is_safety_check);
return new (zone()) Operator1<DeoptimizeParameters>( // --
return zone()->New<Operator1<DeoptimizeParameters>>( // --
IrOpcode::kDeoptimizeUnless, // opcode
Operator::kFoldable | Operator::kNoThrow, // properties
"DeoptimizeUnless", // name
......@@ -1025,7 +1025,7 @@ const Operator* CommonOperatorBuilder::TrapIf(TrapId trap_id) {
break;
}
// Uncached
return new (zone()) Operator1<TrapId>( // --
return zone()->New<Operator1<TrapId>>( // --
IrOpcode::kTrapIf, // opcode
Operator::kFoldable | Operator::kNoThrow, // properties
"TrapIf", // name
......@@ -1044,7 +1044,7 @@ const Operator* CommonOperatorBuilder::TrapUnless(TrapId trap_id) {
break;
}
// Uncached
return new (zone()) Operator1<TrapId>( // --
return zone()->New<Operator1<TrapId>>( // --
IrOpcode::kTrapUnless, // opcode
Operator::kFoldable | Operator::kNoThrow, // properties
"TrapUnless", // name
......@@ -1053,7 +1053,7 @@ const Operator* CommonOperatorBuilder::TrapUnless(TrapId trap_id) {
}
const Operator* CommonOperatorBuilder::Switch(size_t control_output_count) {
return new (zone()) Operator( // --
return zone()->New<Operator>( // --
IrOpcode::kSwitch, Operator::kKontrol, // opcode
"Switch", // name
1, 0, 1, 0, 0, control_output_count); // counts
......@@ -1062,7 +1062,7 @@ const Operator* CommonOperatorBuilder::Switch(size_t control_output_count) {
const Operator* CommonOperatorBuilder::IfValue(int32_t index,
int32_t comparison_order,
BranchHint hint) {
return new (zone()) Operator1<IfValueParameters>( // --
return zone()->New<Operator1<IfValueParameters>>( // --
IrOpcode::kIfValue, Operator::kKontrol, // opcode
"IfValue", // name
0, 0, 1, 0, 0, 1, // counts
......@@ -1070,7 +1070,7 @@ const Operator* CommonOperatorBuilder::IfValue(int32_t index,
}
const Operator* CommonOperatorBuilder::IfDefault(BranchHint hint) {
return new (zone()) Operator1<BranchHint>( // --
return zone()->New<Operator1<BranchHint>>( // --
IrOpcode::kIfDefault, Operator::kKontrol, // opcode
"IfDefault", // name
0, 0, 1, 0, 0, 1, // counts
......@@ -1078,7 +1078,7 @@ const Operator* CommonOperatorBuilder::IfDefault(BranchHint hint) {
}
const Operator* CommonOperatorBuilder::Start(int value_output_count) {
return new (zone()) Operator( // --
return zone()->New<Operator>( // --
IrOpcode::kStart, Operator::kFoldable | Operator::kNoThrow, // opcode
"Start", // name
0, 0, 0, value_output_count, 1, 1); // counts
......@@ -1096,7 +1096,7 @@ const Operator* CommonOperatorBuilder::Loop(int control_input_count) {
break;
}
// Uncached.
return new (zone()) Operator( // --
return zone()->New<Operator>( // --
IrOpcode::kLoop, Operator::kKontrol, // opcode
"Loop", // name
0, 0, control_input_count, 0, 0, 1); // counts
......@@ -1114,7 +1114,7 @@ const Operator* CommonOperatorBuilder::Merge(int control_input_count) {
break;
}
// Uncached.
return new (zone()) Operator( // --
return zone()->New<Operator>( // --
IrOpcode::kMerge, Operator::kKontrol, // opcode
"Merge", // name
0, 0, control_input_count, 0, 0, 1); // counts
......@@ -1135,7 +1135,7 @@ const Operator* CommonOperatorBuilder::Parameter(int index,
}
}
// Uncached.
return new (zone()) Operator1<ParameterInfo>( // --
return zone()->New<Operator1<ParameterInfo>>( // --
IrOpcode::kParameter, Operator::kPure, // opcode
"Parameter", // name
1, 0, 0, 1, 0, 0, // counts
......@@ -1143,7 +1143,7 @@ const Operator* CommonOperatorBuilder::Parameter(int index,
}
const Operator* CommonOperatorBuilder::OsrValue(int index) {
return new (zone()) Operator1<int>( // --
return zone()->New<Operator1<int>>( // --
IrOpcode::kOsrValue, Operator::kNoProperties, // opcode
"OsrValue", // name
0, 0, 1, 1, 0, 0, // counts
......@@ -1151,7 +1151,7 @@ const Operator* CommonOperatorBuilder::OsrValue(int index) {
}
const Operator* CommonOperatorBuilder::Int32Constant(int32_t value) {
return new (zone()) Operator1<int32_t>( // --
return zone()->New<Operator1<int32_t>>( // --
IrOpcode::kInt32Constant, Operator::kPure, // opcode
"Int32Constant", // name
0, 0, 0, 1, 0, 0, // counts
......@@ -1160,7 +1160,7 @@ const Operator* CommonOperatorBuilder::Int32Constant(int32_t value) {
const Operator* CommonOperatorBuilder::Int64Constant(int64_t value) {
return new (zone()) Operator1<int64_t>( // --
return zone()->New<Operator1<int64_t>>( // --
IrOpcode::kInt64Constant, Operator::kPure, // opcode
"Int64Constant", // name
0, 0, 0, 1, 0, 0, // counts
......@@ -1168,7 +1168,7 @@ const Operator* CommonOperatorBuilder::Int64Constant(int64_t value) {
}
const Operator* CommonOperatorBuilder::TaggedIndexConstant(int32_t value) {
return new (zone()) Operator1<int32_t>( // --
return zone()->New<Operator1<int32_t>>( // --
IrOpcode::kTaggedIndexConstant, Operator::kPure, // opcode
"TaggedIndexConstant", // name
0, 0, 0, 1, 0, 0, // counts
......@@ -1176,7 +1176,7 @@ const Operator* CommonOperatorBuilder::TaggedIndexConstant(int32_t value) {
}
const Operator* CommonOperatorBuilder::Float32Constant(volatile float value) {
return new (zone()) Operator1<float>( // --
return zone()->New<Operator1<float>>( // --
IrOpcode::kFloat32Constant, Operator::kPure, // opcode
"Float32Constant", // name
0, 0, 0, 1, 0, 0, // counts
......@@ -1185,7 +1185,7 @@ const Operator* CommonOperatorBuilder::Float32Constant(volatile float value) {
const Operator* CommonOperatorBuilder::Float64Constant(volatile double value) {
return new (zone()) Operator1<double>( // --
return zone()->New<Operator1<double>>( // --
IrOpcode::kFloat64Constant, Operator::kPure, // opcode
"Float64Constant", // name
0, 0, 0, 1, 0, 0, // counts
......@@ -1195,7 +1195,7 @@ const Operator* CommonOperatorBuilder::Float64Constant(volatile double value) {
const Operator* CommonOperatorBuilder::ExternalConstant(
const ExternalReference& value) {
return new (zone()) Operator1<ExternalReference>( // --
return zone()->New<Operator1<ExternalReference>>( // --
IrOpcode::kExternalConstant, Operator::kPure, // opcode
"ExternalConstant", // name
0, 0, 0, 1, 0, 0, // counts
......@@ -1204,7 +1204,7 @@ const Operator* CommonOperatorBuilder::ExternalConstant(
const Operator* CommonOperatorBuilder::NumberConstant(volatile double value) {
return new (zone()) Operator1<double>( // --
return zone()->New<Operator1<double>>( // --
IrOpcode::kNumberConstant, Operator::kPure, // opcode
"NumberConstant", // name
0, 0, 0, 1, 0, 0, // counts
......@@ -1212,7 +1212,7 @@ const Operator* CommonOperatorBuilder::NumberConstant(volatile double value) {
}
const Operator* CommonOperatorBuilder::PointerConstant(intptr_t value) {
return new (zone()) Operator1<intptr_t>( // --
return zone()->New<Operator1<intptr_t>>( // --
IrOpcode::kPointerConstant, Operator::kPure, // opcode
"PointerConstant", // name
0, 0, 0, 1, 0, 0, // counts
......@@ -1221,7 +1221,7 @@ const Operator* CommonOperatorBuilder::PointerConstant(intptr_t value) {
const Operator* CommonOperatorBuilder::HeapConstant(
const Handle<HeapObject>& value) {
return new (zone()) Operator1<Handle<HeapObject>>( // --
return zone()->New<Operator1<Handle<HeapObject>>>( // --
IrOpcode::kHeapConstant, Operator::kPure, // opcode
"HeapConstant", // name
0, 0, 0, 1, 0, 0, // counts
......@@ -1230,7 +1230,7 @@ const Operator* CommonOperatorBuilder::HeapConstant(
const Operator* CommonOperatorBuilder::CompressedHeapConstant(
const Handle<HeapObject>& value) {
return new (zone()) Operator1<Handle<HeapObject>>( // --
return zone()->New<Operator1<Handle<HeapObject>>>( // --
IrOpcode::kCompressedHeapConstant, Operator::kPure, // opcode
"CompressedHeapConstant", // name
0, 0, 0, 1, 0, 0, // counts
......@@ -1250,7 +1250,7 @@ const StringConstantBase* StringConstantBaseOf(const Operator* op) {
const Operator* CommonOperatorBuilder::RelocatableInt32Constant(
int32_t value, RelocInfo::Mode rmode) {
return new (zone()) Operator1<RelocatablePtrConstantInfo>( // --
return zone()->New<Operator1<RelocatablePtrConstantInfo>>( // --
IrOpcode::kRelocatableInt32Constant, Operator::kPure, // opcode
"RelocatableInt32Constant", // name
0, 0, 0, 1, 0, 0, // counts
......@@ -1259,7 +1259,7 @@ const Operator* CommonOperatorBuilder::RelocatableInt32Constant(
const Operator* CommonOperatorBuilder::RelocatableInt64Constant(
int64_t value, RelocInfo::Mode rmode) {
return new (zone()) Operator1<RelocatablePtrConstantInfo>( // --
return zone()->New<Operator1<RelocatablePtrConstantInfo>>( // --
IrOpcode::kRelocatableInt64Constant, Operator::kPure, // opcode
"RelocatableInt64Constant", // name
0, 0, 0, 1, 0, 0, // counts
......@@ -1267,7 +1267,7 @@ const Operator* CommonOperatorBuilder::RelocatableInt64Constant(
}
const Operator* CommonOperatorBuilder::ObjectId(uint32_t object_id) {
return new (zone()) Operator1<uint32_t>( // --
return zone()->New<Operator1<uint32_t>>( // --
IrOpcode::kObjectId, Operator::kPure, // opcode
"ObjectId", // name
0, 0, 0, 1, 0, 0, // counts
......@@ -1276,7 +1276,7 @@ const Operator* CommonOperatorBuilder::ObjectId(uint32_t object_id) {
const Operator* CommonOperatorBuilder::Select(MachineRepresentation rep,
BranchHint hint) {
return new (zone()) Operator1<SelectParameters>( // --
return zone()->New<Operator1<SelectParameters>>( // --
IrOpcode::kSelect, Operator::kPure, // opcode
"Select", // name
3, 0, 0, 1, 0, 0, // counts
......@@ -1295,7 +1295,7 @@ const Operator* CommonOperatorBuilder::Phi(MachineRepresentation rep,
CACHED_PHI_LIST(CACHED_PHI)
#undef CACHED_PHI
// Uncached.
return new (zone()) Operator1<MachineRepresentation>( // --
return zone()->New<Operator1<MachineRepresentation>>( // --
IrOpcode::kPhi, Operator::kPure, // opcode
"Phi", // name
value_input_count, 0, 1, 1, 0, 0, // counts
......@@ -1303,7 +1303,7 @@ const Operator* CommonOperatorBuilder::Phi(MachineRepresentation rep,
}
const Operator* CommonOperatorBuilder::TypeGuard(Type type) {
return new (zone()) Operator1<Type>( // --
return zone()->New<Operator1<Type>>( // --
IrOpcode::kTypeGuard, Operator::kPure, // opcode
"TypeGuard", // name
1, 1, 1, 1, 1, 0, // counts
......@@ -1311,7 +1311,7 @@ const Operator* CommonOperatorBuilder::TypeGuard(Type type) {
}
const Operator* CommonOperatorBuilder::FoldConstant() {
return new (zone()) Operator( // --
return zone()->New<Operator>( // --
IrOpcode::kFoldConstant, Operator::kPure, // opcode
"FoldConstant", // name
2, 0, 0, 1, 0, 0); // counts
......@@ -1329,7 +1329,7 @@ const Operator* CommonOperatorBuilder::EffectPhi(int effect_input_count) {
break;
}
// Uncached.
return new (zone()) Operator( // --
return zone()->New<Operator>( // --
IrOpcode::kEffectPhi, Operator::kKontrol, // opcode
"EffectPhi", // name
0, effect_input_count, 1, 0, 1, 0); // counts
......@@ -1348,7 +1348,7 @@ const Operator* CommonOperatorBuilder::InductionVariablePhi(int input_count) {
break;
}
// Uncached.
return new (zone()) Operator( // --
return zone()->New<Operator>( // --
IrOpcode::kInductionVariablePhi, Operator::kPure, // opcode
"InductionVariablePhi", // name
input_count, 0, 1, 1, 0, 0); // counts
......@@ -1384,7 +1384,7 @@ const Operator* CommonOperatorBuilder::StateValues(int arguments,
#endif
// Uncached.
return new (zone()) Operator1<SparseInputMask>( // --
return zone()->New<Operator1<SparseInputMask>>( // --
IrOpcode::kStateValues, Operator::kPure, // opcode
"StateValues", // name
arguments, 0, 0, 1, 0, 0, // counts
......@@ -1398,7 +1398,7 @@ const Operator* CommonOperatorBuilder::TypedStateValues(
bitmask.CountReal() == static_cast<int>(types->size()));
#endif
return new (zone()) Operator1<TypedStateValueInfo>( // --
return zone()->New<Operator1<TypedStateValueInfo>>( // --
IrOpcode::kTypedStateValues, Operator::kPure, // opcode
"TypedStateValues", // name
static_cast<int>(types->size()), 0, 0, 1, 0, 0, // counts
......@@ -1407,7 +1407,7 @@ const Operator* CommonOperatorBuilder::TypedStateValues(
const Operator* CommonOperatorBuilder::ArgumentsElementsState(
ArgumentsStateType type) {
return new (zone()) Operator1<ArgumentsStateType>( // --
return zone()->New<Operator1<ArgumentsStateType>>( // --
IrOpcode::kArgumentsElementsState, Operator::kPure, // opcode
"ArgumentsElementsState", // name
0, 0, 0, 1, 0, 0, // counts
......@@ -1416,7 +1416,7 @@ const Operator* CommonOperatorBuilder::ArgumentsElementsState(
const Operator* CommonOperatorBuilder::ArgumentsLengthState(
ArgumentsStateType type) {
return new (zone()) Operator1<ArgumentsStateType>( // --
return zone()->New<Operator1<ArgumentsStateType>>( // --
IrOpcode::kArgumentsLengthState, Operator::kPure, // opcode
"ArgumentsLengthState", // name
0, 0, 0, 1, 0, 0, // counts
......@@ -1431,7 +1431,7 @@ ArgumentsStateType ArgumentsStateTypeOf(Operator const* op) {
const Operator* CommonOperatorBuilder::ObjectState(uint32_t object_id,
int pointer_slots) {
return new (zone()) Operator1<ObjectStateInfo>( // --
return zone()->New<Operator1<ObjectStateInfo>>( // --
IrOpcode::kObjectState, Operator::kPure, // opcode
"ObjectState", // name
pointer_slots, 0, 0, 1, 0, 0, // counts
......@@ -1440,7 +1440,7 @@ const Operator* CommonOperatorBuilder::ObjectState(uint32_t object_id,
const Operator* CommonOperatorBuilder::TypedObjectState(
uint32_t object_id, const ZoneVector<MachineType>* types) {
return new (zone()) Operator1<TypedObjectStateInfo>( // --
return zone()->New<Operator1<TypedObjectStateInfo>>( // --
IrOpcode::kTypedObjectState, Operator::kPure, // opcode
"TypedObjectState", // name
static_cast<int>(types->size()), 0, 0, 1, 0, 0, // counts
......@@ -1469,7 +1469,7 @@ const Operator* CommonOperatorBuilder::FrameState(
BailoutId bailout_id, OutputFrameStateCombine state_combine,
const FrameStateFunctionInfo* function_info) {
FrameStateInfo state_info(bailout_id, state_combine, function_info);
return new (zone()) Operator1<FrameStateInfo>( // --
return zone()->New<Operator1<FrameStateInfo>>( // --
IrOpcode::kFrameState, Operator::kPure, // opcode
"FrameState", // name
5, 0, 0, 1, 0, 0, // counts
......@@ -1497,7 +1497,7 @@ const Operator* CommonOperatorBuilder::Call(
os << "[" << *parameter() << "]";
}
};
return new (zone()) CallOperator(call_descriptor);
return zone()->New<CallOperator>(call_descriptor);
}
const Operator* CommonOperatorBuilder::TailCall(
......@@ -1517,7 +1517,7 @@ const Operator* CommonOperatorBuilder::TailCall(
os << "[" << *parameter() << "]";
}
};
return new (zone()) TailCallOperator(call_descriptor);
return zone()->New<TailCallOperator>(call_descriptor);
}
const Operator* CommonOperatorBuilder::Projection(size_t index) {
......@@ -1531,7 +1531,7 @@ const Operator* CommonOperatorBuilder::Projection(size_t index) {
break;
}
// Uncached.
return new (zone()) Operator1<size_t>( // --
return zone()->New<Operator1<size_t>>( // --
IrOpcode::kProjection, // opcode
Operator::kPure, // flags
"Projection", // name
......@@ -1559,12 +1559,12 @@ const FrameStateFunctionInfo*
CommonOperatorBuilder::CreateFrameStateFunctionInfo(
FrameStateType type, int parameter_count, int local_count,
Handle<SharedFunctionInfo> shared_info) {
return new (zone()->New(sizeof(FrameStateFunctionInfo)))
FrameStateFunctionInfo(type, parameter_count, local_count, shared_info);
return zone()->New<FrameStateFunctionInfo>(type, parameter_count, local_count,
shared_info);
}
const Operator* CommonOperatorBuilder::DeadValue(MachineRepresentation rep) {
return new (zone()) Operator1<MachineRepresentation>( // --
return zone()->New<Operator1<MachineRepresentation>>( // --
IrOpcode::kDeadValue, Operator::kPure, // opcode
"DeadValue", // name
1, 0, 0, 1, 0, 0, // counts
......
src/compiler/compilation-dependencies.cc
View file @ 1540a014
......@@ -373,21 +373,21 @@ void CompilationDependencies::RecordDependency(
MapRef CompilationDependencies::DependOnInitialMap(
const JSFunctionRef& function) {
MapRef map = function.initial_map();
RecordDependency(new (zone_) InitialMapDependency(function, map));
RecordDependency(zone_->New<InitialMapDependency>(function, map));
return map;
}
ObjectRef CompilationDependencies::DependOnPrototypeProperty(
const JSFunctionRef& function) {
ObjectRef prototype = function.prototype();
RecordDependency(new (zone_)
PrototypePropertyDependency(function, prototype));
RecordDependency(
zone_->New<PrototypePropertyDependency>(function, prototype));
return prototype;
}
void CompilationDependencies::DependOnStableMap(const MapRef& map) {
if (map.CanTransition()) {
RecordDependency(new (zone_) StableMapDependency(map));
RecordDependency(zone_->New<StableMapDependency>(map));
} else {
DCHECK(map.is_stable());
}
......@@ -400,7 +400,7 @@ void CompilationDependencies::DependOnTransition(const MapRef& target_map) {
AllocationType CompilationDependencies::DependOnPretenureMode(
const AllocationSiteRef& site) {
AllocationType allocation = site.GetAllocationType();
RecordDependency(new (zone_) PretenureModeDependency(site, allocation));
RecordDependency(zone_->New<PretenureModeDependency>(site, allocation));
return allocation;
}
......@@ -423,7 +423,7 @@ PropertyConstness CompilationDependencies::DependOnFieldConstness(
}
DCHECK_EQ(constness, PropertyConstness::kConst);
RecordDependency(new (zone_) FieldConstnessDependency(owner, descriptor));
RecordDependency(zone_->New<FieldConstnessDependency>(owner, descriptor));
return PropertyConstness::kConst;
}
......@@ -441,12 +441,12 @@ void CompilationDependencies::DependOnGlobalProperty(
const PropertyCellRef& cell) {
PropertyCellType type = cell.property_details().cell_type();
bool read_only = cell.property_details().IsReadOnly();
RecordDependency(new (zone_) GlobalPropertyDependency(cell, type, read_only));
RecordDependency(zone_->New<GlobalPropertyDependency>(cell, type, read_only));
}
bool CompilationDependencies::DependOnProtector(const PropertyCellRef& cell) {
if (cell.value().AsSmi() != Protectors::kProtectorValid) return false;
RecordDependency(new (zone_) ProtectorDependency(cell));
RecordDependency(zone_->New<ProtectorDependency>(cell));
return true;
}
......@@ -493,7 +493,7 @@ void CompilationDependencies::DependOnElementsKind(
? site.boilerplate().value().GetElementsKind()
: site.GetElementsKind();
if (AllocationSite::ShouldTrack(kind)) {
RecordDependency(new (zone_) ElementsKindDependency(site, kind));
RecordDependency(zone_->New<ElementsKindDependency>(site, kind));
}
}
......@@ -619,7 +619,7 @@ CompilationDependencies::DependOnInitialMapInstanceSizePrediction(
// Currently, we always install the prediction dependency. If this turns out
// to be too expensive, we can only install the dependency if slack
// tracking is active.
RecordDependency(new (zone_) InitialMapInstanceSizePredictionDependency(
RecordDependency(zone_->New<InitialMapInstanceSizePredictionDependency>(
function, instance_size));
DCHECK_LE(instance_size, function.initial_map().instance_size());
return SlackTrackingPrediction(initial_map, instance_size);
......@@ -629,7 +629,7 @@ CompilationDependency const*
CompilationDependencies::TransitionDependencyOffTheRecord(
const MapRef& target_map) const {
if (target_map.CanBeDeprecated()) {
return new (zone_) TransitionDependency(target_map);
return zone_->New<TransitionDependency>(target_map);
} else {
DCHECK(!target_map.is_deprecated());
return nullptr;
......@@ -643,7 +643,7 @@ CompilationDependencies::FieldRepresentationDependencyOffTheRecord(
PropertyDetails details = owner.GetPropertyDetails(descriptor);
DCHECK(details.representation().Equals(
map.GetPropertyDetails(descriptor).representation()));
return new (zone_) FieldRepresentationDependency(owner, descriptor,
return zone_->New<FieldRepresentationDependency>(owner, descriptor,
details.representation());
}
......@@ -653,7 +653,7 @@ CompilationDependencies::FieldTypeDependencyOffTheRecord(
MapRef owner = map.FindFieldOwner(descriptor);
ObjectRef type = owner.GetFieldType(descriptor);
DCHECK(type.equals(map.GetFieldType(descriptor)));
return new (zone_) FieldTypeDependency(owner, descriptor, type);
return zone_->New<FieldTypeDependency>(owner, descriptor, type);
}
} // namespace compiler
......
src/compiler/compiler-source-position-table.cc
View file @ 1540a014
......@@ -32,7 +32,7 @@ SourcePositionTable::SourcePositionTable(Graph* graph)
void SourcePositionTable::AddDecorator() {
DCHECK_NULL(decorator_);
decorator_ = new (graph_->zone()) Decorator(this);
decorator_ = graph_->zone()->New<Decorator>(this);
graph_->AddDecorator(decorator_);
}
......
src/compiler/control-equivalence.h
View file @ 1540a014
......@@ -136,7 +136,7 @@ class V8_EXPORT_PRIVATE ControlEquivalence final
void AllocateData(Node* node) {
size_t const index = node->id();
if (index >= node_data_.size()) node_data_.resize(index + 1);
node_data_[index] = new (zone_) NodeData(zone_);
node_data_[index] = zone_->New<NodeData>(zone_);
}
int NewClassNumber() { return class_number_++; }
......
src/compiler/csa-load-elimination.cc
View file @ 1540a014
......@@ -125,7 +125,7 @@ CsaLoadElimination::AbstractState::KillField(Node* kill_object,
MachineRepresentation kill_repr,
Zone* zone) const {
FieldInfo empty_info;
AbstractState* that = new (zone) AbstractState(*this);
AbstractState* that = zone->New<AbstractState>(*this);
for (std::pair<Field, FieldInfo> entry : that->field_infos_) {
Field field = entry.first;
MachineRepresentation field_repr = entry.second.representation;
......@@ -142,7 +142,7 @@ CsaLoadElimination::AbstractState const*
CsaLoadElimination::AbstractState::AddField(Node* object, Node* offset,
CsaLoadElimination::FieldInfo info,
Zone* zone) const {
AbstractState* that = new (zone) AbstractState(*this);
AbstractState* that = zone->New<AbstractState>(*this);
that->field_infos_.Set({object, offset}, info);
return that;
}
......@@ -233,7 +233,7 @@ Reduction CsaLoadElimination::ReduceEffectPhi(Node* node) {
// Make a copy of the first input's state and merge with the state
// from other inputs.
AbstractState* state = new (zone()) AbstractState(*state0);
AbstractState* state = zone()->New<AbstractState>(*state0);
for (int i = 1; i < input_count; ++i) {
Node* const input = NodeProperties::GetEffectInput(node, i);
state->Merge(node_states_.Get(input), zone());
......
src/compiler/escape-analysis.cc
View file @ 1540a014
......@@ -266,8 +266,8 @@ class EscapeAnalysisTracker : public ZoneObject {
VirtualObject* NewVirtualObject(int size) {
if (next_object_id_ >= kMaxTrackedObjects) return nullptr;
return new (zone_)
VirtualObject(&variable_states_, next_object_id_++, size);
return zone_->New<VirtualObject>(&variable_states_, next_object_id_++,
size);
}
SparseSidetable<VirtualObject*> virtual_objects_;
......@@ -829,7 +829,7 @@ EscapeAnalysis::EscapeAnalysis(JSGraph* jsgraph, TickCounter* tick_counter,
jsgraph->graph(),
[this](Node* node, Reduction* reduction) { Reduce(node, reduction); },
tick_counter, zone),
tracker_(new (zone) EscapeAnalysisTracker(jsgraph, this, zone)),
tracker_(zone->New<EscapeAnalysisTracker>(jsgraph, this, zone)),
jsgraph_(jsgraph) {}
Node* EscapeAnalysisResult::GetReplacementOf(Node* node) {
......
src/compiler/functional-list.h
View file @ 1540a014
......@@ -67,7 +67,7 @@ class FunctionalList {
}
void PushFront(A a, Zone* zone) {
elements_ = new (zone) Cons(std::move(a), elements_);
elements_ = zone->New<Cons>(std::move(a), elements_);
}
// If {hint} happens to be exactly what we want to allocate, avoid allocation
......
src/compiler/js-graph.cc
View file @ 1540a014
......@@ -173,11 +173,11 @@ DEFINE_GETTER(EmptyStateValues,
graph()->NewNode(common()->StateValues(0,
SparseInputMask::Dense())))
DEFINE_GETTER(SingleDeadTypedStateValues,
graph()->NewNode(common()->TypedStateValues(
new (graph()->zone()->New(sizeof(ZoneVector<MachineType>)))
ZoneVector<MachineType>(0, graph()->zone()),
SparseInputMask(SparseInputMask::kEndMarker << 1))))
DEFINE_GETTER(
SingleDeadTypedStateValues,
graph()->NewNode(common()->TypedStateValues(
graph()->zone()->New<ZoneVector<MachineType>>(0, graph()->zone()),
SparseInputMask(SparseInputMask::kEndMarker << 1))))
#undef DEFINE_GETTER
#undef GET_CACHED_FIELD
......
src/compiler/js-heap-broker.cc
View file @ 1540a014
......@@ -281,6 +281,11 @@ CallHandlerInfoData::CallHandlerInfoData(JSHeapBroker* broker,
: HeapObjectData(broker, storage, object),
callback_(v8::ToCData<Address>(object->callback())) {}
// These definitions are here in order to please the linker, which in debug mode
// sometimes requires static constants to be defined in .cc files.
const uint32_t JSHeapBroker::kMinimalRefsBucketCount;
const uint32_t JSHeapBroker::kInitialRefsBucketCount;
void JSHeapBroker::IncrementTracingIndentation() { ++trace_indentation_; }
void JSHeapBroker::DecrementTracingIndentation() { --trace_indentation_; }
......@@ -2389,8 +2394,8 @@ JSHeapBroker::JSHeapBroker(Isolate* isolate, Zone* broker_zone,
bool is_native_context_independent)
: isolate_(isolate),
zone_(broker_zone),
refs_(new (zone())
RefsMap(kMinimalRefsBucketCount, AddressMatcher(), zone())),
refs_(zone()->New<RefsMap>(kMinimalRefsBucketCount, AddressMatcher(),
zone())),
root_index_map_(isolate),
array_and_object_prototypes_(zone()),
tracing_enabled_(tracing_enabled),
......@@ -2619,7 +2624,7 @@ void JSHeapBroker::InitializeAndStartSerializing(
refs_ = nullptr;
refs_ =
new (zone()) RefsMap(kInitialRefsBucketCount, AddressMatcher(), zone());
zone()->New<RefsMap>(kInitialRefsBucketCount, AddressMatcher(), zone());
SetTargetNativeContextRef(native_context);
target_native_context().Serialize();
......@@ -2671,15 +2676,15 @@ ObjectData* JSHeapBroker::GetOrCreateData(Handle<Object> object) {
// TODO(neis): Remove these Allow* once we serialize everything upfront.
AllowHandleDereference handle_dereference;
if (object->IsSmi()) {
new (zone()) ObjectData(this, data_storage, object, kSmi);
zone()->New<ObjectData>(this, data_storage, object, kSmi);
} else if (IsReadOnlyHeapObject(*object)) {
new (zone()) ObjectData(this, data_storage, object,
zone()->New<ObjectData>(this, data_storage, object,
kUnserializedReadOnlyHeapObject);
#define CREATE_DATA_IF_MATCH(name) \
} else if (object->Is##name()) { \
CHECK(SerializingAllowed()); \
AllowHandleAllocation handle_allocation; \
new (zone()) name##Data(this, data_storage, Handle<name>::cast(object));
zone()->New<name##Data>(this, data_storage, Handle<name>::cast(object));
HEAP_BROKER_OBJECT_LIST(CREATE_DATA_IF_MATCH)
#undef CREATE_DATA_IF_MATCH
} else {
......@@ -3932,9 +3937,9 @@ ObjectRef::ObjectRef(JSHeapBroker* broker, Handle<Object> object,
if (*storage == nullptr) {
AllowHandleDereferenceIf allow_handle_dereference(
kUnserializedHeapObject, broker->mode());
entry->value = new (broker->zone())
ObjectData(broker, storage, object,
object->IsSmi() ? kSmi : kUnserializedHeapObject);
entry->value = broker->zone()->New<ObjectData>(
broker, storage, object,
object->IsSmi() ? kSmi : kUnserializedHeapObject);
}
data_ = *storage;
break;
......@@ -4443,7 +4448,7 @@ ElementAccessFeedback::transition_groups() const {
ElementAccessFeedback const& ElementAccessFeedback::Refine(
ZoneVector<Handle<Map>> const& inferred_maps, Zone* zone) const {
ElementAccessFeedback& refined_feedback =
*new (zone) ElementAccessFeedback(zone, keyed_mode(), slot_kind());
*zone->New<ElementAccessFeedback>(zone, keyed_mode(), slot_kind());
if (inferred_maps.empty()) return refined_feedback;
ZoneUnorderedSet<Handle<Map>, Handle<Map>::hash, Handle<Map>::equal_to>
......@@ -4697,7 +4702,7 @@ bool JSHeapBroker::CanUseFeedback(const FeedbackNexus& nexus) const {
const ProcessedFeedback& JSHeapBroker::NewInsufficientFeedback(
FeedbackSlotKind kind) const {
return *new (zone()) InsufficientFeedback(kind);
return *zone()->New<InsufficientFeedback>(kind);
}
ProcessedFeedback const& JSHeapBroker::ReadFeedbackForPropertyAccess(
......@@ -4722,7 +4727,7 @@ ProcessedFeedback const& JSHeapBroker::ReadFeedbackForPropertyAccess(
if (name.has_value()) {
// We rely on this invariant in JSGenericLowering.
DCHECK_IMPLIES(maps.empty(), nexus.ic_state() == MEGAMORPHIC);
return *new (zone()) NamedAccessFeedback(
return *zone()->New<NamedAccessFeedback>(
*name, ZoneVector<Handle<Map>>(maps.begin(), maps.end(), zone()), kind);
} else if (nexus.GetKeyType() == ELEMENT && !maps.empty()) {
return ProcessFeedbackMapsForElementAccess(
......@@ -4732,8 +4737,8 @@ ProcessedFeedback const& JSHeapBroker::ReadFeedbackForPropertyAccess(
DCHECK(maps.empty());
DCHECK_EQ(nexus.ic_state(), MEGAMORPHIC);
// TODO(neis): Using ElementAccessFeedback here is kind of an abuse.
return *new (zone())
ElementAccessFeedback(zone(), KeyedAccessMode::FromNexus(nexus), kind);
return *zone()->New<ElementAccessFeedback>(
zone(), KeyedAccessMode::FromNexus(nexus), kind);
}
}
......@@ -4746,7 +4751,7 @@ ProcessedFeedback const& JSHeapBroker::ReadFeedbackForGlobalAccess(
nexus.kind() == FeedbackSlotKind::kStoreGlobalStrict);
if (!CanUseFeedback(nexus)) return NewInsufficientFeedback(nexus.kind());
if (nexus.ic_state() != MONOMORPHIC || nexus.GetFeedback()->IsCleared()) {
return *new (zone()) GlobalAccessFeedback(nexus.kind());
return *zone()->New<GlobalAccessFeedback>(nexus.kind());
}
Handle<Object> feedback_value(nexus.GetFeedback()->GetHeapObjectOrSmi(),
......@@ -4774,7 +4779,7 @@ ProcessedFeedback const& JSHeapBroker::ReadFeedbackForGlobalAccess(
context_ref.get(context_slot_index,
SerializationPolicy::kSerializeIfNeeded);
}
return *new (zone()) GlobalAccessFeedback(context_ref, context_slot_index,
return *zone()->New<GlobalAccessFeedback>(context_ref, context_slot_index,
immutable, nexus.kind());
}
......@@ -4783,7 +4788,7 @@ ProcessedFeedback const& JSHeapBroker::ReadFeedbackForGlobalAccess(
// object and the feedback is the cell holding its value.
PropertyCellRef cell(this, Handle<PropertyCell>::cast(feedback_value));
cell.Serialize();
return *new (zone()) GlobalAccessFeedback(cell, nexus.kind());
return *zone()->New<GlobalAccessFeedback>(cell, nexus.kind());
}
ProcessedFeedback const& JSHeapBroker::ReadFeedbackForBinaryOperation(
......@@ -4792,7 +4797,7 @@ ProcessedFeedback const& JSHeapBroker::ReadFeedbackForBinaryOperation(
if (!CanUseFeedback(nexus)) return NewInsufficientFeedback(nexus.kind());
BinaryOperationHint hint = nexus.GetBinaryOperationFeedback();
DCHECK_NE(hint, BinaryOperationHint::kNone); // Not uninitialized.
return *new (zone()) BinaryOperationFeedback(hint, nexus.kind());
return *zone()->New<BinaryOperationFeedback>(hint, nexus.kind());
}
ProcessedFeedback const& JSHeapBroker::ReadFeedbackForCompareOperation(
......@@ -4801,7 +4806,7 @@ ProcessedFeedback const& JSHeapBroker::ReadFeedbackForCompareOperation(
if (!CanUseFeedback(nexus)) return NewInsufficientFeedback(nexus.kind());
CompareOperationHint hint = nexus.GetCompareOperationFeedback();
DCHECK_NE(hint, CompareOperationHint::kNone); // Not uninitialized.
return *new (zone()) CompareOperationFeedback(hint, nexus.kind());
return *zone()->New<CompareOperationFeedback>(hint, nexus.kind());
}
ProcessedFeedback const& JSHeapBroker::ReadFeedbackForForIn(
......@@ -4810,7 +4815,7 @@ ProcessedFeedback const& JSHeapBroker::ReadFeedbackForForIn(
if (!CanUseFeedback(nexus)) return NewInsufficientFeedback(nexus.kind());
ForInHint hint = nexus.GetForInFeedback();
DCHECK_NE(hint, ForInHint::kNone); // Not uninitialized.
return *new (zone()) ForInFeedback(hint, nexus.kind());
return *zone()->New<ForInFeedback>(hint, nexus.kind());
}
ProcessedFeedback const& JSHeapBroker::ReadFeedbackForInstanceOf(
......@@ -4826,7 +4831,7 @@ ProcessedFeedback const& JSHeapBroker::ReadFeedbackForInstanceOf(
optional_constructor = JSObjectRef(this, constructor);
}
}
return *new (zone()) InstanceOfFeedback(optional_constructor, nexus.kind());
return *zone()->New<InstanceOfFeedback>(optional_constructor, nexus.kind());
}
ProcessedFeedback const& JSHeapBroker::ReadFeedbackForArrayOrObjectLiteral(
......@@ -4844,7 +4849,7 @@ ProcessedFeedback const& JSHeapBroker::ReadFeedbackForArrayOrObjectLiteral(
site.SerializeBoilerplate();
}
return *new (zone()) LiteralFeedback(site, nexus.kind());
return *zone()->New<LiteralFeedback>(site, nexus.kind());
}
ProcessedFeedback const& JSHeapBroker::ReadFeedbackForRegExpLiteral(
......@@ -4859,7 +4864,7 @@ ProcessedFeedback const& JSHeapBroker::ReadFeedbackForRegExpLiteral(
JSRegExpRef regexp(this, handle(object, isolate()));
regexp.SerializeAsRegExpBoilerplate();
return *new (zone()) RegExpLiteralFeedback(regexp, nexus.kind());
return *zone()->New<RegExpLiteralFeedback>(regexp, nexus.kind());
}
ProcessedFeedback const& JSHeapBroker::ReadFeedbackForTemplateObject(
......@@ -4873,7 +4878,7 @@ ProcessedFeedback const& JSHeapBroker::ReadFeedbackForTemplateObject(
}
JSArrayRef array(this, handle(object, isolate()));
return *new (zone()) TemplateObjectFeedback(array, nexus.kind());
return *zone()->New<TemplateObjectFeedback>(array, nexus.kind());
}
ProcessedFeedback const& JSHeapBroker::ReadFeedbackForCall(
......@@ -4891,7 +4896,7 @@ ProcessedFeedback const& JSHeapBroker::ReadFeedbackForCall(
}
float frequency = nexus.ComputeCallFrequency();
SpeculationMode mode = nexus.GetSpeculationMode();
return *new (zone()) CallFeedback(target_ref, frequency, mode, nexus.kind());
return *zone()->New<CallFeedback>(target_ref, frequency, mode, nexus.kind());
}
BinaryOperationHint JSHeapBroker::GetFeedbackForBinaryOperation(
......@@ -5092,7 +5097,7 @@ ElementAccessFeedback const& JSHeapBroker::ProcessFeedbackMapsForElementAccess(
}
ElementAccessFeedback* result =
new (zone()) ElementAccessFeedback(zone(), keyed_mode, slot_kind);
zone()->New<ElementAccessFeedback>(zone(), keyed_mode, slot_kind);
for (auto entry : transition_groups) {
result->AddGroup(std::move(entry.second));
}
......@@ -5249,7 +5254,7 @@ BytecodeAnalysis const& JSHeapBroker::GetBytecodeAnalysis(
}
CHECK_EQ(policy, SerializationPolicy::kSerializeIfNeeded);
BytecodeAnalysis* analysis = new (zone()) BytecodeAnalysis(
BytecodeAnalysis* analysis = zone()->New<BytecodeAnalysis>(
bytecode_array, zone(), osr_bailout_id, analyze_liveness);
DCHECK_EQ(analysis->osr_bailout_id(), osr_bailout_id);
bytecode_analyses_[bytecode_array_data] = analysis;
......
src/compiler/js-heap-broker.h
View file @ 1540a014
......@@ -284,8 +284,8 @@ class V8_EXPORT_PRIVATE JSHeapBroker {
ZoneMultimap<SerializedFunction, HintsVector> serialized_functions_;
static const size_t kMaxSerializedFunctionsCacheSize = 200;
static const size_t kMinimalRefsBucketCount = 8; // must be power of 2
static const size_t kInitialRefsBucketCount = 1024; // must be power of 2
static const uint32_t kMinimalRefsBucketCount = 8; // must be power of 2
static const uint32_t kInitialRefsBucketCount = 1024; // must be power of 2
};
class TraceScope {
......
src/compiler/js-native-context-specialization.cc
View file @ 1540a014
......@@ -170,7 +170,7 @@ Reduction JSNativeContextSpecialization::ReduceJSToString(Node* node) {
NumberMatcher number_matcher(input);
if (number_matcher.HasValue()) {
const StringConstantBase* base =
new (shared_zone()) NumberToStringConstant(number_matcher.Value());
shared_zone()->New<NumberToStringConstant>(number_matcher.Value());
reduction =
Replace(graph()->NewNode(common()->DelayedStringConstant(base)));
ReplaceWithValue(node, reduction.replacement());
......@@ -187,13 +187,13 @@ JSNativeContextSpecialization::CreateDelayedStringConstant(Node* node) {
} else {
NumberMatcher number_matcher(node);
if (number_matcher.HasValue()) {
return new (shared_zone()) NumberToStringConstant(number_matcher.Value());
return shared_zone()->New<NumberToStringConstant>(number_matcher.Value());
} else {
HeapObjectMatcher matcher(node);
if (matcher.HasValue() && matcher.Ref(broker()).IsString()) {
StringRef s = matcher.Ref(broker()).AsString();
return new (shared_zone())
StringLiteral(s.object(), static_cast<size_t>(s.length()));
return shared_zone()->New<StringLiteral>(
s.object(), static_cast<size_t>(s.length()));
} else {
UNREACHABLE();
}
......@@ -335,7 +335,7 @@ Reduction JSNativeContextSpecialization::ReduceJSAdd(Node* node) {
const StringConstantBase* left = CreateDelayedStringConstant(lhs);
const StringConstantBase* right = CreateDelayedStringConstant(rhs);
const StringConstantBase* cons =
new (shared_zone()) StringCons(left, right);
shared_zone()->New<StringCons>(left, right);
Node* reduced = graph()->NewNode(common()->DelayedStringConstant(cons));
ReplaceWithValue(node, reduced);
......
src/compiler/js-operator.cc
View file @ 1540a014
......@@ -728,7 +728,7 @@ CACHED_OP_LIST(CACHED_OP)
#define UNARY_OP(JSName, Name) \
const Operator* JSOperatorBuilder::Name(FeedbackSource const& feedback) { \
FeedbackParameter parameters(feedback); \
return new (zone()) Operator1<FeedbackParameter>( \
return zone()->New<Operator1<FeedbackParameter>>( \
IrOpcode::k##JSName, Operator::kNoProperties, #JSName, 2, 1, 1, 1, 1, \
2, parameters); \
}
......@@ -739,7 +739,7 @@ JS_UNOP_WITH_FEEDBACK(UNARY_OP)
const Operator* JSOperatorBuilder::Name(FeedbackSource const& feedback) { \
static constexpr auto kProperties = BinopProperties(IrOpcode::k##JSName); \
FeedbackParameter parameters(feedback); \
return new (zone()) Operator1<FeedbackParameter>( \
return zone()->New<Operator1<FeedbackParameter>>( \
IrOpcode::k##JSName, kProperties, #JSName, 3, 1, 1, 1, 1, \
Operator::ZeroIfNoThrow(kProperties), parameters); \
}
......@@ -756,7 +756,7 @@ const Operator* JSOperatorBuilder::StoreDataPropertyInLiteral(
static constexpr int kArity =
kObject + kName + kValue + kFlags + kFeedbackVector;
FeedbackParameter parameters(feedback);
return new (zone()) Operator1<FeedbackParameter>( // --
return zone()->New<Operator1<FeedbackParameter>>( // --
IrOpcode::kJSStoreDataPropertyInLiteral,
Operator::kNoThrow, // opcode
"JSStoreDataPropertyInLiteral", // name
......@@ -772,7 +772,7 @@ const Operator* JSOperatorBuilder::StoreInArrayLiteral(
static constexpr int kFeedbackVector = 1;
static constexpr int kArity = kArray + kIndex + kValue + kFeedbackVector;
FeedbackParameter parameters(feedback);
return new (zone()) Operator1<FeedbackParameter>( // --
return zone()->New<Operator1<FeedbackParameter>>( // --
IrOpcode::kJSStoreInArrayLiteral,
Operator::kNoThrow, // opcode
"JSStoreInArrayLiteral", // name
......@@ -783,7 +783,7 @@ const Operator* JSOperatorBuilder::StoreInArrayLiteral(
const Operator* JSOperatorBuilder::CallForwardVarargs(size_t arity,
uint32_t start_index) {
CallForwardVarargsParameters parameters(arity, start_index);
return new (zone()) Operator1<CallForwardVarargsParameters>( // --
return zone()->New<Operator1<CallForwardVarargsParameters>>( // --
IrOpcode::kJSCallForwardVarargs, Operator::kNoProperties, // opcode
"JSCallForwardVarargs", // name
parameters.arity(), 1, 1, 1, 1, 2, // counts
......@@ -796,7 +796,7 @@ const Operator* JSOperatorBuilder::Call(
SpeculationMode speculation_mode, CallFeedbackRelation feedback_relation) {
CallParameters parameters(arity, frequency, feedback, convert_mode,
speculation_mode, feedback_relation);
return new (zone()) Operator1<CallParameters>( // --
return zone()->New<Operator1<CallParameters>>( // --
IrOpcode::kJSCall, Operator::kNoProperties, // opcode
"JSCall", // name
parameters.arity(), 1, 1, 1, 1, 2, // inputs/outputs
......@@ -810,7 +810,7 @@ const Operator* JSOperatorBuilder::CallWithArrayLike(
CallParameters parameters(
JSCallWithArrayLikeNode::ArityForArgc(kTheArrayLikeObject), frequency,
feedback, ConvertReceiverMode::kAny, speculation_mode, feedback_relation);
return new (zone()) Operator1<CallParameters>( // --
return zone()->New<Operator1<CallParameters>>( // --
IrOpcode::kJSCallWithArrayLike, Operator::kNoProperties, // opcode
"JSCallWithArrayLike", // name
parameters.arity(), 1, 1, 1, 1, 2, // counts
......@@ -826,7 +826,7 @@ const Operator* JSOperatorBuilder::CallWithSpread(
CallParameters parameters(arity, frequency, feedback,
ConvertReceiverMode::kAny, speculation_mode,
feedback_relation);
return new (zone()) Operator1<CallParameters>( // --
return zone()->New<Operator1<CallParameters>>( // --
IrOpcode::kJSCallWithSpread, Operator::kNoProperties, // opcode
"JSCallWithSpread", // name
parameters.arity(), 1, 1, 1, 1, 2, // counts
......@@ -850,7 +850,7 @@ const Operator* JSOperatorBuilder::CallRuntime(const Runtime::Function* f,
size_t arity) {
CallRuntimeParameters parameters(f->function_id, arity);
DCHECK(f->nargs == -1 || f->nargs == static_cast<int>(parameters.arity()));
return new (zone()) Operator1<CallRuntimeParameters>( // --
return zone()->New<Operator1<CallRuntimeParameters>>( // --
IrOpcode::kJSCallRuntime, Operator::kNoProperties, // opcode
"JSCallRuntime", // name
parameters.arity(), 1, 1, f->result_size, 1, 2, // inputs/outputs
......@@ -860,7 +860,7 @@ const Operator* JSOperatorBuilder::CallRuntime(const Runtime::Function* f,
const Operator* JSOperatorBuilder::ConstructForwardVarargs(
size_t arity, uint32_t start_index) {
ConstructForwardVarargsParameters parameters(arity, start_index);
return new (zone()) Operator1<ConstructForwardVarargsParameters>( // --
return zone()->New<Operator1<ConstructForwardVarargsParameters>>( // --
IrOpcode::kJSConstructForwardVarargs, Operator::kNoProperties, // opcode
"JSConstructForwardVarargs", // name
parameters.arity(), 1, 1, 1, 1, 2, // counts
......@@ -873,7 +873,7 @@ const Operator* JSOperatorBuilder::Construct(uint32_t arity,
CallFrequency const& frequency,
FeedbackSource const& feedback) {
ConstructParameters parameters(arity, frequency, feedback);
return new (zone()) Operator1<ConstructParameters>( // --
return zone()->New<Operator1<ConstructParameters>>( // --
IrOpcode::kJSConstruct, Operator::kNoProperties, // opcode
"JSConstruct", // name
parameters.arity(), 1, 1, 1, 1, 2, // counts
......@@ -886,7 +886,7 @@ const Operator* JSOperatorBuilder::ConstructWithArrayLike(
ConstructParameters parameters(
JSConstructWithArrayLikeNode::ArityForArgc(kTheArrayLikeObject),
frequency, feedback);
return new (zone()) Operator1<ConstructParameters>( // --
return zone()->New<Operator1<ConstructParameters>>( // --
IrOpcode::kJSConstructWithArrayLike, // opcode
Operator::kNoProperties, // properties
"JSConstructWithArrayLike", // name
......@@ -898,7 +898,7 @@ const Operator* JSOperatorBuilder::ConstructWithSpread(
uint32_t arity, CallFrequency const& frequency,
FeedbackSource const& feedback) {
ConstructParameters parameters(arity, frequency, feedback);
return new (zone()) Operator1<ConstructParameters>( // --
return zone()->New<Operator1<ConstructParameters>>( // --
IrOpcode::kJSConstructWithSpread, Operator::kNoProperties, // opcode
"JSConstructWithSpread", // name
parameters.arity(), 1, 1, 1, 1, 2, // counts
......@@ -911,7 +911,7 @@ const Operator* JSOperatorBuilder::LoadNamed(Handle<Name> name,
static constexpr int kFeedbackVector = 1;
static constexpr int kArity = kObject + kFeedbackVector;
NamedAccess access(LanguageMode::kSloppy, name, feedback);
return new (zone()) Operator1<NamedAccess>( // --
return zone()->New<Operator1<NamedAccess>>( // --
IrOpcode::kJSLoadNamed, Operator::kNoProperties, // opcode
"JSLoadNamed", // name
kArity, 1, 1, 1, 1, 2, // counts
......@@ -921,7 +921,7 @@ const Operator* JSOperatorBuilder::LoadNamed(Handle<Name> name,
const Operator* JSOperatorBuilder::LoadProperty(
FeedbackSource const& feedback) {
PropertyAccess access(LanguageMode::kSloppy, feedback);
return new (zone()) Operator1<PropertyAccess>( // --
return zone()->New<Operator1<PropertyAccess>>( // --
IrOpcode::kJSLoadProperty, Operator::kNoProperties, // opcode
"JSLoadProperty", // name
3, 1, 1, 1, 1, 2, // counts
......@@ -931,7 +931,7 @@ const Operator* JSOperatorBuilder::LoadProperty(
const Operator* JSOperatorBuilder::GetIterator(
FeedbackSource const& load_feedback, FeedbackSource const& call_feedback) {
GetIteratorParameters access(load_feedback, call_feedback);
return new (zone()) Operator1<GetIteratorParameters>( // --
return zone()->New<Operator1<GetIteratorParameters>>( // --
IrOpcode::kJSGetIterator, Operator::kNoProperties, // opcode
"JSGetIterator", // name
2, 1, 1, 1, 1, 2, // counts
......@@ -940,7 +940,7 @@ const Operator* JSOperatorBuilder::GetIterator(
const Operator* JSOperatorBuilder::HasProperty(FeedbackSource const& feedback) {
PropertyAccess access(LanguageMode::kSloppy, feedback);
return new (zone()) Operator1<PropertyAccess>( // --
return zone()->New<Operator1<PropertyAccess>>( // --
IrOpcode::kJSHasProperty, Operator::kNoProperties, // opcode
"JSHasProperty", // name
3, 1, 1, 1, 1, 2, // counts
......@@ -948,7 +948,7 @@ const Operator* JSOperatorBuilder::HasProperty(FeedbackSource const& feedback) {
}
const Operator* JSOperatorBuilder::ForInNext(ForInMode mode) {
return new (zone()) Operator1<ForInMode>( // --
return zone()->New<Operator1<ForInMode>>( // --
IrOpcode::kJSForInNext, Operator::kNoProperties, // opcode
"JSForInNext", // name
4, 1, 1, 1, 1, 2, // counts
......@@ -956,7 +956,7 @@ const Operator* JSOperatorBuilder::ForInNext(ForInMode mode) {
}
const Operator* JSOperatorBuilder::ForInPrepare(ForInMode mode) {
return new (zone()) Operator1<ForInMode>( // --
return zone()->New<Operator1<ForInMode>>( // --
IrOpcode::kJSForInPrepare, // opcode
Operator::kNoWrite | Operator::kNoThrow, // flags
"JSForInPrepare", // name
......@@ -965,7 +965,7 @@ const Operator* JSOperatorBuilder::ForInPrepare(ForInMode mode) {
}
const Operator* JSOperatorBuilder::GeneratorStore(int register_count) {
return new (zone()) Operator1<int>( // --
return zone()->New<Operator1<int>>( // --
IrOpcode::kJSGeneratorStore, Operator::kNoThrow, // opcode
"JSGeneratorStore", // name
3 + register_count, 1, 1, 0, 1, 0, // counts
......@@ -983,7 +983,7 @@ int GeneratorStoreValueCountOf(const Operator* op) {
}
const Operator* JSOperatorBuilder::GeneratorRestoreRegister(int index) {
return new (zone()) Operator1<int>( // --
return zone()->New<Operator1<int>>( // --
IrOpcode::kJSGeneratorRestoreRegister, Operator::kNoThrow, // opcode
"JSGeneratorRestoreRegister", // name
1, 1, 1, 1, 1, 0, // counts
......@@ -1003,7 +1003,7 @@ const Operator* JSOperatorBuilder::StoreNamed(LanguageMode language_mode,
static constexpr int kFeedbackVector = 1;
static constexpr int kArity = kObject + kValue + kFeedbackVector;
NamedAccess access(language_mode, name, feedback);
return new (zone()) Operator1<NamedAccess>( // --
return zone()->New<Operator1<NamedAccess>>( // --
IrOpcode::kJSStoreNamed, Operator::kNoProperties, // opcode
"JSStoreNamed", // name
kArity, 1, 1, 0, 1, 2, // counts
......@@ -1013,7 +1013,7 @@ const Operator* JSOperatorBuilder::StoreNamed(LanguageMode language_mode,
const Operator* JSOperatorBuilder::StoreProperty(
LanguageMode language_mode, FeedbackSource const& feedback) {
PropertyAccess access(language_mode, feedback);
return new (zone()) Operator1<PropertyAccess>( // --
return zone()->New<Operator1<PropertyAccess>>( // --
IrOpcode::kJSStoreProperty, Operator::kNoProperties, // opcode
"JSStoreProperty", // name
4, 1, 1, 0, 1, 2, // counts
......@@ -1027,7 +1027,7 @@ const Operator* JSOperatorBuilder::StoreNamedOwn(
static constexpr int kFeedbackVector = 1;
static constexpr int kArity = kObject + kValue + kFeedbackVector;
StoreNamedOwnParameters parameters(name, feedback);
return new (zone()) Operator1<StoreNamedOwnParameters>( // --
return zone()->New<Operator1<StoreNamedOwnParameters>>( // --
IrOpcode::kJSStoreNamedOwn, Operator::kNoProperties, // opcode
"JSStoreNamedOwn", // name
kArity, 1, 1, 0, 1, 2, // counts
......@@ -1035,14 +1035,14 @@ const Operator* JSOperatorBuilder::StoreNamedOwn(
}
const Operator* JSOperatorBuilder::DeleteProperty() {
return new (zone()) Operator( // --
return zone()->New<Operator>( // --
IrOpcode::kJSDeleteProperty, Operator::kNoProperties, // opcode
"JSDeleteProperty", // name
3, 1, 1, 1, 1, 2); // counts
}
const Operator* JSOperatorBuilder::CreateGeneratorObject() {
return new (zone()) Operator( // --
return zone()->New<Operator>( // --
IrOpcode::kJSCreateGeneratorObject, Operator::kEliminatable, // opcode
"JSCreateGeneratorObject", // name
2, 1, 1, 1, 1, 0); // counts
......@@ -1054,7 +1054,7 @@ const Operator* JSOperatorBuilder::LoadGlobal(const Handle<Name>& name,
static constexpr int kFeedbackVector = 1;
static constexpr int kArity = kFeedbackVector;
LoadGlobalParameters parameters(name, feedback, typeof_mode);
return new (zone()) Operator1<LoadGlobalParameters>( // --
return zone()->New<Operator1<LoadGlobalParameters>>( // --
IrOpcode::kJSLoadGlobal, Operator::kNoProperties, // opcode
"JSLoadGlobal", // name
kArity, 1, 1, 1, 1, 2, // counts
......@@ -1068,7 +1068,7 @@ const Operator* JSOperatorBuilder::StoreGlobal(LanguageMode language_mode,
static constexpr int kFeedbackVector = 1;
static constexpr int kArity = kValue + kFeedbackVector;
StoreGlobalParameters parameters(language_mode, feedback, name);
return new (zone()) Operator1<StoreGlobalParameters>( // --
return zone()->New<Operator1<StoreGlobalParameters>>( // --
IrOpcode::kJSStoreGlobal, Operator::kNoProperties, // opcode
"JSStoreGlobal", // name
kArity, 1, 1, 0, 1, 2, // counts
......@@ -1076,7 +1076,7 @@ const Operator* JSOperatorBuilder::StoreGlobal(LanguageMode language_mode,
}
const Operator* JSOperatorBuilder::HasContextExtension(size_t depth) {
return new (zone()) Operator1<size_t>( // --
return zone()->New<Operator1<size_t>>( // --
IrOpcode::kJSHasContextExtension, // opcode
Operator::kNoWrite | Operator::kNoThrow, // flags
"JSHasContextExtension", // name
......@@ -1087,7 +1087,7 @@ const Operator* JSOperatorBuilder::HasContextExtension(size_t depth) {
const Operator* JSOperatorBuilder::LoadContext(size_t depth, size_t index,
bool immutable) {
ContextAccess access(depth, index, immutable);
return new (zone()) Operator1<ContextAccess>( // --
return zone()->New<Operator1<ContextAccess>>( // --
IrOpcode::kJSLoadContext, // opcode
Operator::kNoWrite | Operator::kNoThrow, // flags
"JSLoadContext", // name
......@@ -1098,7 +1098,7 @@ const Operator* JSOperatorBuilder::LoadContext(size_t depth, size_t index,
const Operator* JSOperatorBuilder::StoreContext(size_t depth, size_t index) {
ContextAccess access(depth, index, false);
return new (zone()) Operator1<ContextAccess>( // --
return zone()->New<Operator1<ContextAccess>>( // --
IrOpcode::kJSStoreContext, // opcode
Operator::kNoRead | Operator::kNoThrow, // flags
"JSStoreContext", // name
......@@ -1107,7 +1107,7 @@ const Operator* JSOperatorBuilder::StoreContext(size_t depth, size_t index) {
}
const Operator* JSOperatorBuilder::LoadModule(int32_t cell_index) {
return new (zone()) Operator1<int32_t>( // --
return zone()->New<Operator1<int32_t>>( // --
IrOpcode::kJSLoadModule, // opcode
Operator::kNoWrite | Operator::kNoThrow, // flags
"JSLoadModule", // name
......@@ -1116,7 +1116,7 @@ const Operator* JSOperatorBuilder::LoadModule(int32_t cell_index) {
}
const Operator* JSOperatorBuilder::StoreModule(int32_t cell_index) {
return new (zone()) Operator1<int32_t>( // --
return zone()->New<Operator1<int32_t>>( // --
IrOpcode::kJSStoreModule, // opcode
Operator::kNoRead | Operator::kNoThrow, // flags
"JSStoreModule", // name
......@@ -1125,7 +1125,7 @@ const Operator* JSOperatorBuilder::StoreModule(int32_t cell_index) {
}
const Operator* JSOperatorBuilder::CreateArguments(CreateArgumentsType type) {
return new (zone()) Operator1<CreateArgumentsType>( // --
return zone()->New<Operator1<CreateArgumentsType>>( // --
IrOpcode::kJSCreateArguments, Operator::kEliminatable, // opcode
"JSCreateArguments", // name
1, 1, 0, 1, 1, 0, // counts
......@@ -1137,7 +1137,7 @@ const Operator* JSOperatorBuilder::CreateArray(
// constructor, new_target, arg1, ..., argN
int const value_input_count = static_cast<int>(arity) + 2;
CreateArrayParameters parameters(arity, site);
return new (zone()) Operator1<CreateArrayParameters>( // --
return zone()->New<Operator1<CreateArrayParameters>>( // --
IrOpcode::kJSCreateArray, Operator::kNoProperties, // opcode
"JSCreateArray", // name
value_input_count, 1, 1, 1, 1, 2, // counts
......@@ -1146,7 +1146,7 @@ const Operator* JSOperatorBuilder::CreateArray(
const Operator* JSOperatorBuilder::CreateArrayIterator(IterationKind kind) {
CreateArrayIteratorParameters parameters(kind);
return new (zone()) Operator1<CreateArrayIteratorParameters>( // --
return zone()->New<Operator1<CreateArrayIteratorParameters>>( // --
IrOpcode::kJSCreateArrayIterator, Operator::kEliminatable, // opcode
"JSCreateArrayIterator", // name
1, 1, 1, 1, 1, 0, // counts
......@@ -1155,7 +1155,7 @@ const Operator* JSOperatorBuilder::CreateArrayIterator(IterationKind kind) {
const Operator* JSOperatorBuilder::CreateAsyncFunctionObject(
int register_count) {
return new (zone()) Operator1<int>( // --
return zone()->New<Operator1<int>>( // --
IrOpcode::kJSCreateAsyncFunctionObject, // opcode
Operator::kEliminatable, // flags
"JSCreateAsyncFunctionObject", // name
......@@ -1167,7 +1167,7 @@ const Operator* JSOperatorBuilder::CreateCollectionIterator(
CollectionKind collection_kind, IterationKind iteration_kind) {
CreateCollectionIteratorParameters parameters(collection_kind,
iteration_kind);
return new (zone()) Operator1<CreateCollectionIteratorParameters>(
return zone()->New<Operator1<CreateCollectionIteratorParameters>>(
IrOpcode::kJSCreateCollectionIterator, Operator::kEliminatable,
"JSCreateCollectionIterator", 1, 1, 1, 1, 1, 0, parameters);
}
......@@ -1177,7 +1177,7 @@ const Operator* JSOperatorBuilder::CreateBoundFunction(size_t arity,
// bound_target_function, bound_this, arg1, ..., argN
int const value_input_count = static_cast<int>(arity) + 2;
CreateBoundFunctionParameters parameters(arity, map);
return new (zone()) Operator1<CreateBoundFunctionParameters>( // --
return zone()->New<Operator1<CreateBoundFunctionParameters>>( // --
IrOpcode::kJSCreateBoundFunction, Operator::kEliminatable, // opcode
"JSCreateBoundFunction", // name
value_input_count, 1, 1, 1, 1, 0, // counts
......@@ -1190,7 +1190,7 @@ const Operator* JSOperatorBuilder::CreateClosure(
static constexpr int kFeedbackCell = 1;
static constexpr int kArity = kFeedbackCell;
CreateClosureParameters parameters(shared_info, code, allocation);
return new (zone()) Operator1<CreateClosureParameters>( // --
return zone()->New<Operator1<CreateClosureParameters>>( // --
IrOpcode::kJSCreateClosure, Operator::kEliminatable, // opcode
"JSCreateClosure", // name
kArity, 1, 1, 1, 1, 0, // counts
......@@ -1202,7 +1202,7 @@ const Operator* JSOperatorBuilder::CreateLiteralArray(
FeedbackSource const& feedback, int literal_flags, int number_of_elements) {
CreateLiteralParameters parameters(description, feedback, number_of_elements,
literal_flags);
return new (zone()) Operator1<CreateLiteralParameters>( // --
return zone()->New<Operator1<CreateLiteralParameters>>( // --
IrOpcode::kJSCreateLiteralArray, // opcode
Operator::kNoProperties, // properties
"JSCreateLiteralArray", // name
......@@ -1215,7 +1215,7 @@ const Operator* JSOperatorBuilder::CreateEmptyLiteralArray(
static constexpr int kFeedbackVector = 1;
static constexpr int kArity = kFeedbackVector;
FeedbackParameter parameters(feedback);
return new (zone()) Operator1<FeedbackParameter>( // --
return zone()->New<Operator1<FeedbackParameter>>( // --
IrOpcode::kJSCreateEmptyLiteralArray, // opcode
Operator::kEliminatable, // properties
"JSCreateEmptyLiteralArray", // name
......@@ -1224,7 +1224,7 @@ const Operator* JSOperatorBuilder::CreateEmptyLiteralArray(
}
const Operator* JSOperatorBuilder::CreateArrayFromIterable() {
return new (zone()) Operator( // --
return zone()->New<Operator>( // --
IrOpcode::kJSCreateArrayFromIterable, // opcode
Operator::kNoProperties, // properties
"JSCreateArrayFromIterable", // name
......@@ -1237,7 +1237,7 @@ const Operator* JSOperatorBuilder::CreateLiteralObject(
int number_of_properties) {
CreateLiteralParameters parameters(constant_properties, feedback,
number_of_properties, literal_flags);
return new (zone()) Operator1<CreateLiteralParameters>( // --
return zone()->New<Operator1<CreateLiteralParameters>>( // --
IrOpcode::kJSCreateLiteralObject, // opcode
Operator::kNoProperties, // properties
"JSCreateLiteralObject", // name
......@@ -1249,7 +1249,7 @@ const Operator* JSOperatorBuilder::GetTemplateObject(
Handle<TemplateObjectDescription> description,
Handle<SharedFunctionInfo> shared, FeedbackSource const& feedback) {
GetTemplateObjectParameters parameters(description, shared, feedback);
return new (zone()) Operator1<GetTemplateObjectParameters>( // --
return zone()->New<Operator1<GetTemplateObjectParameters>>( // --
IrOpcode::kJSGetTemplateObject, // opcode
Operator::kEliminatable, // properties
"JSGetTemplateObject", // name
......@@ -1260,7 +1260,7 @@ const Operator* JSOperatorBuilder::GetTemplateObject(
const Operator* JSOperatorBuilder::CloneObject(FeedbackSource const& feedback,
int literal_flags) {
CloneObjectParameters parameters(feedback, literal_flags);
return new (zone()) Operator1<CloneObjectParameters>( // --
return zone()->New<Operator1<CloneObjectParameters>>( // --
IrOpcode::kJSCloneObject, // opcode
Operator::kNoProperties, // properties
"JSCloneObject", // name
......@@ -1269,7 +1269,7 @@ const Operator* JSOperatorBuilder::CloneObject(FeedbackSource const& feedback,
}
const Operator* JSOperatorBuilder::StackCheck(StackCheckKind kind) {
return new (zone()) Operator1<StackCheckKind>( // --
return zone()->New<Operator1<StackCheckKind>>( // --
IrOpcode::kJSStackCheck, // opcode
Operator::kNoWrite, // properties
"JSStackCheck", // name
......@@ -1278,7 +1278,7 @@ const Operator* JSOperatorBuilder::StackCheck(StackCheckKind kind) {
}
const Operator* JSOperatorBuilder::CreateEmptyLiteralObject() {
return new (zone()) Operator( // --
return zone()->New<Operator>( // --
IrOpcode::kJSCreateEmptyLiteralObject, // opcode
Operator::kNoProperties, // properties
"JSCreateEmptyLiteralObject", // name
......@@ -1290,7 +1290,7 @@ const Operator* JSOperatorBuilder::CreateLiteralRegExp(
int literal_flags) {
CreateLiteralParameters parameters(constant_pattern, feedback, -1,
literal_flags);
return new (zone()) Operator1<CreateLiteralParameters>( // --
return zone()->New<Operator1<CreateLiteralParameters>>( // --
IrOpcode::kJSCreateLiteralRegExp, // opcode
Operator::kNoProperties, // properties
"JSCreateLiteralRegExp", // name
......@@ -1302,7 +1302,7 @@ const Operator* JSOperatorBuilder::CreateFunctionContext(
Handle<ScopeInfo> scope_info, int slot_count, ScopeType scope_type) {
CreateFunctionContextParameters parameters(scope_info, slot_count,
scope_type);
return new (zone()) Operator1<CreateFunctionContextParameters>( // --
return zone()->New<Operator1<CreateFunctionContextParameters>>( // --
IrOpcode::kJSCreateFunctionContext, Operator::kNoProperties, // opcode
"JSCreateFunctionContext", // name
0, 1, 1, 1, 1, 2, // counts
......@@ -1311,7 +1311,7 @@ const Operator* JSOperatorBuilder::CreateFunctionContext(
const Operator* JSOperatorBuilder::CreateCatchContext(
const Handle<ScopeInfo>& scope_info) {
return new (zone()) Operator1<Handle<ScopeInfo>>(
return zone()->New<Operator1<Handle<ScopeInfo>>>(
IrOpcode::kJSCreateCatchContext, Operator::kNoProperties, // opcode
"JSCreateCatchContext", // name
1, 1, 1, 1, 1, 2, // counts
......@@ -1320,7 +1320,7 @@ const Operator* JSOperatorBuilder::CreateCatchContext(
const Operator* JSOperatorBuilder::CreateWithContext(
const Handle<ScopeInfo>& scope_info) {
return new (zone()) Operator1<Handle<ScopeInfo>>(
return zone()->New<Operator1<Handle<ScopeInfo>>>(
IrOpcode::kJSCreateWithContext, Operator::kNoProperties, // opcode
"JSCreateWithContext", // name
1, 1, 1, 1, 1, 2, // counts
......@@ -1329,7 +1329,7 @@ const Operator* JSOperatorBuilder::CreateWithContext(
const Operator* JSOperatorBuilder::CreateBlockContext(
const Handle<ScopeInfo>& scope_info) {
return new (zone()) Operator1<Handle<ScopeInfo>>( // --
return zone()->New<Operator1<Handle<ScopeInfo>>>( // --
IrOpcode::kJSCreateBlockContext, Operator::kNoProperties, // opcode
"JSCreateBlockContext", // name
0, 1, 1, 1, 1, 2, // counts
......
src/compiler/linkage.cc
View file @ 1540a014
......@@ -74,7 +74,7 @@ MachineSignature* CallDescriptor::GetMachineSignature(Zone* zone) const {
for (size_t i = 0; i < param_count; ++i) {
types[current++] = GetParameterType(i);
}
return new (zone) MachineSignature(return_count, param_count, types);
return zone->New<MachineSignature>(return_count, param_count, types);
}
int CallDescriptor::GetFirstUnusedStackSlot() const {
......@@ -295,7 +295,7 @@ CallDescriptor* Linkage::GetCEntryStubCallDescriptor(
MachineType target_type = MachineType::AnyTagged();
LinkageLocation target_loc =
LinkageLocation::ForAnyRegister(MachineType::AnyTagged());
return new (zone) CallDescriptor( // --
return zone->New<CallDescriptor>( // --
CallDescriptor::kCallCodeObject, // kind
target_type, // target MachineType
target_loc, // target location
......@@ -353,7 +353,7 @@ CallDescriptor* Linkage::GetJSCallDescriptor(Zone* zone, bool is_osr,
LinkageLocation target_loc =
is_osr ? LinkageLocation::ForSavedCallerFunction()
: regloc(kJSFunctionRegister, MachineType::AnyTagged());
return new (zone) CallDescriptor( // --
return zone->New<CallDescriptor>( // --
CallDescriptor::kCallJSFunction, // kind
target_type, // target MachineType
target_loc, // target location
......@@ -452,7 +452,7 @@ CallDescriptor* Linkage::GetStubCallDescriptor(
}
LinkageLocation target_loc = LinkageLocation::ForAnyRegister(target_type);
return new (zone) CallDescriptor( // --
return zone->New<CallDescriptor>( // --
kind, // kind
target_type, // target MachineType
target_loc, // target location
......@@ -499,7 +499,7 @@ CallDescriptor* Linkage::GetBytecodeDispatchCallDescriptor(
LinkageLocation target_loc = LinkageLocation::ForAnyRegister(target_type);
const CallDescriptor::Flags kFlags =
CallDescriptor::kCanUseRoots | CallDescriptor::kFixedTargetRegister;
return new (zone) CallDescriptor( // --
return zone->New<CallDescriptor>( // --
CallDescriptor::kCallAddress, // kind
target_type, // target MachineType
target_loc, // target location
......
src/compiler/load-elimination.cc
View file @ 1540a014
......@@ -167,7 +167,7 @@ LoadElimination::AbstractElements::Kill(Node* object, Node* index,
for (Element const element : this->elements_) {
if (element.object == nullptr) continue;
if (MayAlias(object, element.object)) {
AbstractElements* that = new (zone) AbstractElements(zone);
AbstractElements* that = zone->New<AbstractElements>(zone);
for (Element const element : this->elements_) {
if (element.object == nullptr) continue;
DCHECK_NOT_NULL(element.index);
......@@ -221,7 +221,7 @@ LoadElimination::AbstractElements const*
LoadElimination::AbstractElements::Merge(AbstractElements const* that,
Zone* zone) const {
if (this->Equals(that)) return this;
AbstractElements* copy = new (zone) AbstractElements(zone);
AbstractElements* copy = zone->New<AbstractElements>(zone);
for (Element const this_element : this->elements_) {
if (this_element.object == nullptr) continue;
for (Element const that_element : that->elements_) {
......@@ -293,7 +293,7 @@ LoadElimination::AbstractField const* LoadElimination::AbstractField::KillConst(
// store was performed on the Allocate node. We therefore remove information
// on all nodes that must alias with 'object'.
if (MustAlias(object, pair.first)) {
AbstractField* that = new (zone) AbstractField(zone);
AbstractField* that = zone->New<AbstractField>(zone);
for (auto pair : this->info_for_node_) {
if (!MustAlias(object, pair.first)) {
that->info_for_node_.insert(pair);
......@@ -311,7 +311,7 @@ LoadElimination::AbstractField const* LoadElimination::AbstractField::Kill(
for (auto pair : this->info_for_node_) {
if (pair.first->IsDead()) continue;
if (alias_info.MayAlias(pair.first)) {
AbstractField* that = new (zone) AbstractField(zone);
AbstractField* that = zone->New<AbstractField>(zone);
for (auto pair : this->info_for_node_) {
if (!alias_info.MayAlias(pair.first) ||
!MayAlias(name, pair.second.name)) {
......@@ -355,7 +355,7 @@ LoadElimination::AbstractMaps const* LoadElimination::AbstractMaps::Kill(
const AliasStateInfo& alias_info, Zone* zone) const {
for (auto pair : this->info_for_node_) {
if (alias_info.MayAlias(pair.first)) {
AbstractMaps* that = new (zone) AbstractMaps(zone);
AbstractMaps* that = zone->New<AbstractMaps>(zone);
for (auto pair : this->info_for_node_) {
if (!alias_info.MayAlias(pair.first)) that->info_for_node_.insert(pair);
}
......@@ -368,7 +368,7 @@ LoadElimination::AbstractMaps const* LoadElimination::AbstractMaps::Kill(
LoadElimination::AbstractMaps const* LoadElimination::AbstractMaps::Merge(
AbstractMaps const* that, Zone* zone) const {
if (this->Equals(that)) return this;
AbstractMaps* copy = new (zone) AbstractMaps(zone);
AbstractMaps* copy = zone->New<AbstractMaps>(zone);
for (auto this_it : this->info_for_node_) {
Node* this_object = this_it.first;
ZoneHandleSet<Map> this_maps = this_it.second;
......@@ -382,7 +382,7 @@ LoadElimination::AbstractMaps const* LoadElimination::AbstractMaps::Merge(
LoadElimination::AbstractMaps const* LoadElimination::AbstractMaps::Extend(
Node* object, ZoneHandleSet<Map> maps, Zone* zone) const {
AbstractMaps* that = new (zone) AbstractMaps(zone);
AbstractMaps* that = zone->New<AbstractMaps>(zone);
that->info_for_node_ = this->info_for_node_;
object = ResolveRenames(object);
that->info_for_node_[object] = maps;
......@@ -480,11 +480,11 @@ bool LoadElimination::AbstractState::LookupMaps(
LoadElimination::AbstractState const* LoadElimination::AbstractState::SetMaps(
Node* object, ZoneHandleSet<Map> maps, Zone* zone) const {
AbstractState* that = new (zone) AbstractState(*this);
AbstractState* that = zone->New<AbstractState>(*this);
if (that->maps_) {
that->maps_ = that->maps_->Extend(object, maps, zone);
} else {
that->maps_ = new (zone) AbstractMaps(object, maps, zone);
that->maps_ = zone->New<AbstractMaps>(object, maps, zone);
}
return that;
}
......@@ -494,7 +494,7 @@ LoadElimination::AbstractState const* LoadElimination::AbstractState::KillMaps(
if (this->maps_) {
AbstractMaps const* that_maps = this->maps_->Kill(alias_info, zone);
if (this->maps_ != that_maps) {
AbstractState* that = new (zone) AbstractState(*this);
AbstractState* that = zone->New<AbstractState>(*this);
that->maps_ = that_maps;
return that;
}
......@@ -521,13 +521,13 @@ LoadElimination::AbstractState::AddElement(Node* object, Node* index,
Node* value,
MachineRepresentation representation,
Zone* zone) const {
AbstractState* that = new (zone) AbstractState(*this);
AbstractState* that = zone->New<AbstractState>(*this);
if (that->elements_) {
that->elements_ =
that->elements_->Extend(object, index, value, representation, zone);
} else {
that->elements_ =
new (zone) AbstractElements(object, index, value, representation, zone);
zone->New<AbstractElements>(object, index, value, representation, zone);
}
return that;
}
......@@ -539,7 +539,7 @@ LoadElimination::AbstractState::KillElement(Node* object, Node* index,
AbstractElements const* that_elements =
this->elements_->Kill(object, index, zone);
if (this->elements_ != that_elements) {
AbstractState* that = new (zone) AbstractState(*this);
AbstractState* that = zone->New<AbstractState>(*this);
that->elements_ = that_elements;
return that;
}
......@@ -550,14 +550,14 @@ LoadElimination::AbstractState::KillElement(Node* object, Node* index,
LoadElimination::AbstractState const* LoadElimination::AbstractState::AddField(
Node* object, IndexRange index_range, LoadElimination::FieldInfo info,
Zone* zone) const {
AbstractState* that = new (zone) AbstractState(*this);
AbstractState* that = zone->New<AbstractState>(*this);
AbstractFields& fields =
info.const_field_info.IsConst() ? that->const_fields_ : that->fields_;
for (int index : index_range) {
if (fields[index]) {
fields[index] = fields[index]->Extend(object, info, zone);
} else {
fields[index] = new (zone) AbstractField(object, info, zone);
fields[index] = zone->New<AbstractField>(object, info, zone);
}
}
return that;
......@@ -573,7 +573,7 @@ LoadElimination::AbstractState::KillConstField(Node* object,
if (AbstractField const* this_field = this->const_fields_[index]) {
this_field = this_field->KillConst(object, zone);
if (this->const_fields_[index] != this_field) {
if (!that) that = new (zone) AbstractState(*this);
if (!that) that = zone->New<AbstractState>(*this);
that->const_fields_[index] = this_field;
}
}
......@@ -596,7 +596,7 @@ LoadElimination::AbstractState const* LoadElimination::AbstractState::KillField(
if (AbstractField const* this_field = this->fields_[index]) {
this_field = this_field->Kill(alias_info, name, zone);
if (this->fields_[index] != this_field) {
if (!that) that = new (zone) AbstractState(*this);
if (!that) that = zone->New<AbstractState>(*this);
that->fields_[index] = this_field;
}
}
......@@ -614,7 +614,7 @@ LoadElimination::AbstractState::KillFields(Node* object, MaybeHandle<Name> name,
AbstractField const* that_field =
this_field->Kill(alias_info, name, zone);
if (that_field != this_field) {
AbstractState* that = new (zone) AbstractState(*this);
AbstractState* that = zone->New<AbstractState>(*this);
that->fields_[i] = that_field;
while (++i < fields_.size()) {
if (this->fields_[i] != nullptr) {
......@@ -632,7 +632,7 @@ LoadElimination::AbstractState const* LoadElimination::AbstractState::KillAll(
// Kill everything except for const fields
for (size_t i = 0; i < const_fields_.size(); ++i) {
if (const_fields_[i]) {
AbstractState* that = new (zone) AbstractState();
AbstractState* that = zone->New<AbstractState>();
that->const_fields_ = const_fields_;
return that;
}
......@@ -1188,7 +1188,7 @@ Reduction LoadElimination::ReduceEffectPhi(Node* node) {
// Make a copy of the first input's state and merge with the state
// from other inputs.
AbstractState* state = new (zone()) AbstractState(*state0);
AbstractState* state = zone()->New<AbstractState>(*state0);
for (int i = 1; i < input_count; ++i) {
Node* const input = NodeProperties::GetEffectInput(node, i);
state->Merge(node_states_.Get(input), zone());
......
src/compiler/load-elimination.h
View file @ 1540a014
......@@ -59,7 +59,7 @@ class V8_EXPORT_PRIVATE LoadElimination final
AbstractElements const* Extend(Node* object, Node* index, Node* value,
MachineRepresentation representation,
Zone* zone) const {
AbstractElements* that = new (zone) AbstractElements(*this);
AbstractElements* that = zone->New<AbstractElements>(*this);
that->elements_[that->next_index_] =
Element(object, index, value, representation);
that->next_index_ = (that->next_index_ + 1) % arraysize(elements_);
......@@ -134,7 +134,7 @@ class V8_EXPORT_PRIVATE LoadElimination final
AbstractField const* Extend(Node* object, FieldInfo info,
Zone* zone) const {
AbstractField* that = new (zone) AbstractField(zone);
AbstractField* that = zone->New<AbstractField>(zone);
that->info_for_node_ = this->info_for_node_;
that->info_for_node_[object] = info;
return that;
......@@ -148,7 +148,7 @@ class V8_EXPORT_PRIVATE LoadElimination final
}
AbstractField const* Merge(AbstractField const* that, Zone* zone) const {
if (this->Equals(that)) return this;
AbstractField* copy = new (zone) AbstractField(zone);
AbstractField* copy = zone->New<AbstractField>(zone);
for (auto this_it : this->info_for_node_) {
Node* this_object = this_it.first;
FieldInfo this_second = this_it.second;
......
src/compiler/loop-analysis.cc
View file @ 1540a014
......@@ -524,7 +524,7 @@ class LoopFinderImpl {
LoopTree* LoopFinder::BuildLoopTree(Graph* graph, TickCounter* tick_counter,
Zone* zone) {
LoopTree* loop_tree =
new (graph->zone()) LoopTree(graph->NodeCount(), graph->zone());
graph->zone()->New<LoopTree>(graph->NodeCount(), graph->zone());
LoopFinderImpl finder(graph, loop_tree, tick_counter, zone);
finder.Run();
if (FLAG_trace_turbo_loop) {
......
src/compiler/loop-peeling.cc
View file @ 1540a014
......@@ -216,7 +216,7 @@ PeeledIteration* LoopPeeler::Peel(LoopTree::Loop* loop) {
//============================================================================
// Construct the peeled iteration.
//============================================================================
PeeledIterationImpl* iter = new (tmp_zone_) PeeledIterationImpl(tmp_zone_);
PeeledIterationImpl* iter = tmp_zone_->New<PeeledIterationImpl>(tmp_zone_);
size_t estimated_peeled_size = 5 + (loop->TotalSize()) * 2;
Peeling peeling(graph_, estimated_peeled_size, &iter->node_pairs_);
......
src/compiler/loop-variable-optimizer.cc
View file @ 1540a014
......@@ -260,7 +260,7 @@ InductionVariable* LoopVariableOptimizer::TryGetInductionVariable(Node* phi) {
if (!effect_phi) return nullptr;
Node* incr = arith->InputAt(1);
return new (zone()) InductionVariable(phi, effect_phi, arith, incr, initial,
return zone()->New<InductionVariable>(phi, effect_phi, arith, incr, initial,
zone(), arithmeticType);
}
......
src/compiler/loop-variable-optimizer.h
View file @ 1540a014
......@@ -41,6 +41,7 @@ class InductionVariable : public ZoneObject {
private:
friend class LoopVariableOptimizer;
friend Zone;
InductionVariable(Node* phi, Node* effect_phi, Node* arith, Node* increment,
Node* init_value, Zone* zone, ArithmeticType arithmeticType)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment