Commit 15166c63 authored by Georg Neis's avatar Georg Neis Committed by Commit Bot

[compiler] Include node id in --assert-types failure output

Change-Id: Idb5ac9b0d3703e94f33d74318080790d00c4ec45
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2401428
Auto-Submit: Georg Neis <neis@chromium.org>
Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69836}
parent 015ceed4
...@@ -1633,14 +1633,15 @@ macro IsIntegerOrSomeInfinity(o: Object): bool { ...@@ -1633,14 +1633,15 @@ macro IsIntegerOrSomeInfinity(o: Object): bool {
} }
builtin CheckNumberInRange(implicit context: Context)( builtin CheckNumberInRange(implicit context: Context)(
value: Number, min: Number, max: Number): Undefined { value: Number, min: Number, max: Number, nodeId: Smi): Undefined {
if (IsIntegerOrSomeInfinity(value) && min <= value && value <= max) { if (IsIntegerOrSomeInfinity(value) && min <= value && value <= max) {
return Undefined; return Undefined;
} else { } else {
Print('Range type assertion failed! (value/min/max)'); Print('Range type assertion failed! (value/min/max/nodeId)');
Print(value); Print(value);
Print(min); Print(min);
Print(max); Print(max);
Print(nodeId);
unreachable; unreachable;
} }
} }
......
...@@ -6014,7 +6014,7 @@ Node* EffectControlLinearizer::LowerAssertType(Node* node) { ...@@ -6014,7 +6014,7 @@ Node* EffectControlLinearizer::LowerAssertType(Node* node) {
Node* const min = __ NumberConstant(range->Min()); Node* const min = __ NumberConstant(range->Min());
Node* const max = __ NumberConstant(range->Max()); Node* const max = __ NumberConstant(range->Max());
CallBuiltin(Builtins::kCheckNumberInRange, node->op()->properties(), input, CallBuiltin(Builtins::kCheckNumberInRange, node->op()->properties(), input,
min, max); min, max, __ SmiConstant(node->id()));
return input; return input;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment