Commit 14f17729 authored by Milad Fa's avatar Milad Fa Committed by Commit Bot

[snapshot] Use a function symbol only on x64 or ia32

Change-Id: I14bac71f1b80de6e92b729b369aa4871f9af5bb2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2453453
Commit-Queue: Milad Fa <mfarazma@redhat.com>
Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70382}
parent 1b1eda08
...@@ -193,6 +193,7 @@ class EmbeddedFileWriter : public EmbeddedFileWriterInterface { ...@@ -193,6 +193,7 @@ class EmbeddedFileWriter : public EmbeddedFileWriterInterface {
w->SectionText(); w->SectionText();
w->AlignToCodeAlignment(); w->AlignToCodeAlignment();
#if V8_TARGET_ARCH_IA32 || V8_TARGET_ARCH_X64
// UMA needs an exposed function-type label at the start of the embedded // UMA needs an exposed function-type label at the start of the embedded
// code section, thus this label is declared as a function (otherwise we // code section, thus this label is declared as a function (otherwise we
// could use DeclareLabel). // could use DeclareLabel).
...@@ -200,6 +201,9 @@ class EmbeddedFileWriter : public EmbeddedFileWriterInterface { ...@@ -200,6 +201,9 @@ class EmbeddedFileWriter : public EmbeddedFileWriterInterface {
w->DeclareFunctionBegin(EmbeddedBlobCodeDataSymbol().c_str(), w->DeclareFunctionBegin(EmbeddedBlobCodeDataSymbol().c_str(),
kDummyFunctionLength); kDummyFunctionLength);
w->DeclareFunctionEnd(EmbeddedBlobCodeDataSymbol().c_str()); w->DeclareFunctionEnd(EmbeddedBlobCodeDataSymbol().c_str());
#else
w->DeclareLabel(EmbeddedBlobCodeDataSymbol().c_str());
#endif
for (int i = 0; i < i::Builtins::builtin_count; i++) { for (int i = 0; i < i::Builtins::builtin_count; i++) {
if (!blob->ContainsBuiltin(i)) continue; if (!blob->ContainsBuiltin(i)) continue;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment