Commit 149b8223 authored by Jaroslav Sevcik's avatar Jaroslav Sevcik Committed by Commit Bot

[turbofan] Only lower constant load if feedback agrees with receiver map.

Bug: chromium:945187
Change-Id: I564a4495f13651ea9fdf1b95c25658b92ff9de49
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1538125Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60437}
parent 077e49a1
......@@ -199,6 +199,15 @@ Node* PropertyAccessBuilder::TryBuildLoadConstantDataField(
// Optimize immutable property loads.
HeapObjectMatcher m(receiver);
if (m.HasValue() && m.Value()->IsJSObject()) {
// Make sure the actual map of the receiver is among the maps in
// {access_info}.
Handle<Map> receiver_map = handle(m.Value()->map(), isolate());
if (std::find_if(access_info.receiver_maps().begin(),
access_info.receiver_maps().end(), [&](Handle<Map> map) {
return map.address() == receiver_map.address();
}) == access_info.receiver_maps().end()) {
return nullptr;
}
// TODO(ishell): Use something simpler like
//
// Handle<Object> value =
......
// Copyright 2019 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --allow-natives-syntax
function f() {
const o = { get : Object };
Object.defineProperty(Object, 0, o);
}
f();
%OptimizeFunctionOnNextCall(f);
delete Object.fromEntries;
f();
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment