Commit 146c9e54 authored by Michael Achenbach's avatar Michael Achenbach Committed by Commit Bot

[foozzie] Consistently drop validate-asm flag

Also format flags in single lines to make configs easier to read and modify.

BUG=chromium:673246
NOTRY=true
R=mstarzinger@chromium.org,titzer@chromium.org,rmcilroy@chromium.org

Change-Id: If37486c98af161467b639271b035207c3ae1077a
Reviewed-on: https://chromium-review.googlesource.com/452579Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43719}
parent 0b2bd664
......@@ -9,9 +9,9 @@
# Compared x64,ignition with x64,ignition_staging
#
# Flags of x64,ignition:
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --es-staging --random-seed 12345 --ignition --turbo-filter=~ --hydrogen-filter=~ --validate-asm --nocrankshaft
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --es-staging --random-seed 12345 --ignition --turbo-filter=~ --hydrogen-filter=~ --nocrankshaft
# Flags of x64,ignition_staging:
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --es-staging --random-seed 12345 --ignition-staging --validate-asm
--abort_on_stack_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --es-staging --random-seed 12345 --ignition-staging
#
# Difference:
- unknown
......
......@@ -20,20 +20,44 @@ import v8_commands
import v8_suppressions
CONFIGS = dict(
default=['--validate-asm'],
fullcode=['--nocrankshaft', '--turbo-filter=~', '--validate-asm'],
ignition=['--ignition', '--turbo-filter=~', '--hydrogen-filter=~',
'--validate-asm', '--nocrankshaft'],
ignition_eager=['--ignition', '--turbo-filter=~', '--hydrogen-filter=~',
'--validate-asm', '--nocrankshaft', '--no-lazy',
'--no-lazy-inner-functions'],
ignition_staging=['--ignition-staging', '--validate-asm'],
ignition_turbo=['--ignition-staging', '--turbo', '--validate-asm'],
ignition_turbo_opt=['--ignition-staging', '--turbo', '--always-opt',
'--validate-asm'],
default=[],
fullcode=[
'--nocrankshaft',
'--turbo-filter=~',
],
ignition=[
'--ignition',
'--turbo-filter=~',
'--hydrogen-filter=~',
'--nocrankshaft',
],
ignition_eager=[
'--ignition',
'--turbo-filter=~',
'--hydrogen-filter=~',
'--nocrankshaft',
'--no-lazy',
'--no-lazy-inner-functions',
],
ignition_staging=[
'--ignition-staging',
],
ignition_turbo=[
'--ignition-staging',
'--turbo',
],
ignition_turbo_opt=[
'--ignition-staging',
'--turbo',
'--always-opt',
],
ignition_turbo_opt_eager=[
'--ignition-staging', '--turbo', '--always-opt', '--validate-asm',
'--no-lazy', '--no-lazy-inner-functions'],
'--ignition-staging',
'--turbo',
'--always-opt',
'--no-lazy',
'--no-lazy-inner-functions',
],
)
# Timeout in seconds for one d8 run.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment