Commit 139f2350 authored by Mike Stanton's avatar Mike Stanton Committed by Commit Bot

[api] Its sufficient for the holder in api call to be a JSReceier

Bug: chromium:1158124
Change-Id: Ic23f4b2ffb9436771afcc0090f2179b48851c39d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2596336Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
Commit-Queue: Michael Stanton <mvstanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71829}
parent c5b56704
......@@ -57,8 +57,8 @@ inline Object PropertyCallbackArguments::receiver() {
return *slot_at(T::kThisIndex);
}
inline JSObject FunctionCallbackArguments::holder() {
return JSObject::cast(*slot_at(T::kHolderIndex));
inline JSReceiver FunctionCallbackArguments::holder() {
return JSReceiver::cast(*slot_at(T::kHolderIndex));
}
#define FOR_EACH_CALLBACK(F) \
......
......@@ -177,7 +177,7 @@ class FunctionCallbackArguments
inline Handle<Object> Call(CallHandlerInfo handler);
private:
inline JSObject holder();
inline JSReceiver holder();
internal::Address* argv_;
int argc_;
......
......@@ -1136,7 +1136,7 @@ void Logger::ApiIndexedPropertyAccess(const char* tag, JSObject holder,
msg.WriteToLogFile();
}
void Logger::ApiObjectAccess(const char* tag, JSObject object) {
void Logger::ApiObjectAccess(const char* tag, JSReceiver object) {
if (!FLAG_log_api) return;
MSG_BUILDER();
msg << "api" << kNext << tag << kNext << object.class_name();
......
......@@ -182,7 +182,7 @@ class Logger : public CodeEventListener {
void ApiNamedPropertyAccess(const char* tag, JSObject holder, Object name);
void ApiIndexedPropertyAccess(const char* tag, JSObject holder,
uint32_t index);
void ApiObjectAccess(const char* tag, JSObject obj);
void ApiObjectAccess(const char* tag, JSReceiver obj);
void ApiEntryCall(const char* name);
// ==== Events logged by --log-code. ====
......
// Copyright 2020 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --log-code
o = new Proxy(this, {});
o.printErr();
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment