Commit 11195df8 authored by Clemens Backes's avatar Clemens Backes Committed by Commit Bot

[asmjs][cleanup] Remove uses of DISALLOW_COPY_AND_ASSIGN

Replace by explicitly deleting the copy constructor and copy assignment
operator.

R=zhin@chromium.org

Bug: v8:11074
Change-Id: I5accd5d3d4ecfd20d497d16a3cfd189d17314479
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2523315Reviewed-by: 's avatarZhi An Ng <zhin@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71108}
parent 580980de
...@@ -196,6 +196,9 @@ class AsmJsCompilationJob final : public UnoptimizedCompilationJob { ...@@ -196,6 +196,9 @@ class AsmJsCompilationJob final : public UnoptimizedCompilationJob {
compile_time_(0), compile_time_(0),
module_source_size_(0) {} module_source_size_(0) {}
AsmJsCompilationJob(const AsmJsCompilationJob&) = delete;
AsmJsCompilationJob& operator=(const AsmJsCompilationJob&) = delete;
protected: protected:
Status ExecuteJobImpl() final; Status ExecuteJobImpl() final;
Status FinalizeJobImpl(Handle<SharedFunctionInfo> shared_info, Status FinalizeJobImpl(Handle<SharedFunctionInfo> shared_info,
...@@ -217,8 +220,6 @@ class AsmJsCompilationJob final : public UnoptimizedCompilationJob { ...@@ -217,8 +220,6 @@ class AsmJsCompilationJob final : public UnoptimizedCompilationJob {
double compile_time_; // Time (milliseconds) taken to execute step [2]. double compile_time_; // Time (milliseconds) taken to execute step [2].
int module_source_size_; // Module source size in bytes. int module_source_size_; // Module source size in bytes.
DISALLOW_COPY_AND_ASSIGN(AsmJsCompilationJob);
}; };
UnoptimizedCompilationJob::Status AsmJsCompilationJob::ExecuteJobImpl() { UnoptimizedCompilationJob::Status AsmJsCompilationJob::ExecuteJobImpl() {
......
...@@ -101,6 +101,9 @@ class AsmValueType { ...@@ -101,6 +101,9 @@ class AsmValueType {
class V8_EXPORT_PRIVATE AsmCallableType : public NON_EXPORTED_BASE(ZoneObject) { class V8_EXPORT_PRIVATE AsmCallableType : public NON_EXPORTED_BASE(ZoneObject) {
public: public:
AsmCallableType(const AsmCallableType&) = delete;
AsmCallableType& operator=(const AsmCallableType&) = delete;
virtual std::string Name() = 0; virtual std::string Name() = 0;
virtual bool CanBeInvokedWith(AsmType* return_type, virtual bool CanBeInvokedWith(AsmType* return_type,
...@@ -118,12 +121,13 @@ class V8_EXPORT_PRIVATE AsmCallableType : public NON_EXPORTED_BASE(ZoneObject) { ...@@ -118,12 +121,13 @@ class V8_EXPORT_PRIVATE AsmCallableType : public NON_EXPORTED_BASE(ZoneObject) {
private: private:
friend class AsmType; friend class AsmType;
DISALLOW_COPY_AND_ASSIGN(AsmCallableType);
}; };
class V8_EXPORT_PRIVATE AsmFunctionType final : public AsmCallableType { class V8_EXPORT_PRIVATE AsmFunctionType final : public AsmCallableType {
public: public:
AsmFunctionType(const AsmFunctionType&) = delete;
AsmFunctionType& operator=(const AsmFunctionType&) = delete;
AsmFunctionType* AsFunctionType() final { return this; } AsmFunctionType* AsFunctionType() final { return this; }
void AddArgument(AsmType* type) { args_.push_back(type); } void AddArgument(AsmType* type) { args_.push_back(type); }
...@@ -146,8 +150,6 @@ class V8_EXPORT_PRIVATE AsmFunctionType final : public AsmCallableType { ...@@ -146,8 +150,6 @@ class V8_EXPORT_PRIVATE AsmFunctionType final : public AsmCallableType {
AsmType* return_type_; AsmType* return_type_;
ZoneVector<AsmType*> args_; ZoneVector<AsmType*> args_;
DISALLOW_COPY_AND_ASSIGN(AsmFunctionType);
}; };
class V8_EXPORT_PRIVATE AsmOverloadedFunctionType final class V8_EXPORT_PRIVATE AsmOverloadedFunctionType final
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment