Commit 105103f6 authored by Johannes Henkel's avatar Johannes Henkel Committed by Commit Bot

[DevTools] Roll inspector_protocol (V8)

New Rev: b7cda08cd6e522df2159413ba5f29d2a953cc1c4

Upstream Review:
"Drop redundant std::move in inspector_protocol."
https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2112636

Change-Id: If7832adf00f1c574960e5ca3c179e7b03255fc86
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2113132
Auto-Submit: Johannes Henkel <johannes@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: 's avatarDmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#66815}
parent e70331f9
...@@ -2,7 +2,7 @@ Name: inspector protocol ...@@ -2,7 +2,7 @@ Name: inspector protocol
Short Name: inspector_protocol Short Name: inspector_protocol
URL: https://chromium.googlesource.com/deps/inspector_protocol/ URL: https://chromium.googlesource.com/deps/inspector_protocol/
Version: 0 Version: 0
Revision: c69cdc36200992d21a17bf4e5c2f3a95b8860ddf Revision: b7cda08cd6e522df2159413ba5f29d2a953cc1c4
License: BSD License: BSD
License File: LICENSE License File: LICENSE
Security Critical: no Security Critical: no
......
...@@ -491,7 +491,7 @@ std::unique_ptr<Value> DictionaryValue::clone() const ...@@ -491,7 +491,7 @@ std::unique_ptr<Value> DictionaryValue::clone() const
DCHECK(value != m_data.cend() && value->second); DCHECK(value != m_data.cend() && value->second);
result->setValue(key, value->second->clone()); result->setValue(key, value->second->clone());
} }
return std::move(result); return result;
} }
DictionaryValue::DictionaryValue() DictionaryValue::DictionaryValue()
...@@ -519,7 +519,7 @@ std::unique_ptr<Value> ListValue::clone() const ...@@ -519,7 +519,7 @@ std::unique_ptr<Value> ListValue::clone() const
std::unique_ptr<ListValue> result = ListValue::create(); std::unique_ptr<ListValue> result = ListValue::create();
for (const std::unique_ptr<protocol::Value>& value : m_data) for (const std::unique_ptr<protocol::Value>& value : m_data)
result->pushValue(value->clone()); result->pushValue(value->clone());
return std::move(result); return result;
} }
ListValue::ListValue() ListValue::ListValue()
......
...@@ -59,7 +59,7 @@ std::unique_ptr<protocol::Value> toProtocolValue( ...@@ -59,7 +59,7 @@ std::unique_ptr<protocol::Value> toProtocolValue(
if (converted) if (converted)
result->pushValue(std::move(converted)); result->pushValue(std::move(converted));
} }
return std::move(result); return result;
} }
if (value->is_dict()) { if (value->is_dict()) {
const base::DictionaryValue* dictionary = nullptr; const base::DictionaryValue* dictionary = nullptr;
...@@ -73,7 +73,7 @@ std::unique_ptr<protocol::Value> toProtocolValue( ...@@ -73,7 +73,7 @@ std::unique_ptr<protocol::Value> toProtocolValue(
if (converted) if (converted)
result->setValue(it.key(), std::move(converted)); result->setValue(it.key(), std::move(converted));
} }
return std::move(result); return result;
} }
return nullptr; return nullptr;
} }
...@@ -112,7 +112,7 @@ std::unique_ptr<base::Value> toBaseValue(Value* value, int depth) { ...@@ -112,7 +112,7 @@ std::unique_ptr<base::Value> toBaseValue(Value* value, int depth) {
if (converted) if (converted)
result->Append(std::move(converted)); result->Append(std::move(converted));
} }
return std::move(result); return result;
} }
if (value->type() == Value::TypeObject) { if (value->type() == Value::TypeObject) {
DictionaryValue* dict = DictionaryValue::cast(value); DictionaryValue* dict = DictionaryValue::cast(value);
...@@ -124,7 +124,7 @@ std::unique_ptr<base::Value> toBaseValue(Value* value, int depth) { ...@@ -124,7 +124,7 @@ std::unique_ptr<base::Value> toBaseValue(Value* value, int depth) {
if (converted) if (converted)
result->SetWithoutPathExpansion(entry.first, std::move(converted)); result->SetWithoutPathExpansion(entry.first, std::move(converted));
} }
return std::move(result); return result;
} }
return nullptr; return nullptr;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment