Commit 0f2bffa1 authored by jochen's avatar jochen Committed by Commit bot

Mark deprecated debugger APIs as such

We should consider deprecating the message based API as well in the
future.

BUG=none
R=yangguo@chromium.org
LOG=y

Review URL: https://codereview.chromium.org/1485333007

Cr-Commit-Position: refs/heads/master@{#32621}
parent 7d1263db
......@@ -157,10 +157,9 @@ class V8_EXPORT Debug {
static bool SetDebugEventListener(Isolate* isolate, EventCallback that,
Local<Value> data = Local<Value>());
V8_DEPRECATE_SOON(
"Use version with an Isolate",
static bool SetDebugEventListener(EventCallback that,
Local<Value> data = Local<Value>()));
V8_DEPRECATED("Use version with an Isolate",
static bool SetDebugEventListener(
EventCallback that, Local<Value> data = Local<Value>()));
// Schedule a debugger break to happen when JavaScript code is run
// in the given isolate.
......@@ -175,7 +174,7 @@ class V8_EXPORT Debug {
// Message based interface. The message protocol is JSON.
static void SetMessageHandler(Isolate* isolate, MessageHandler handler);
V8_DEPRECATE_SOON("Use version with an Isolate",
V8_DEPRECATED("Use version with an Isolate",
static void SetMessageHandler(MessageHandler handler));
static void SendCommand(Isolate* isolate,
......@@ -200,8 +199,7 @@ class V8_EXPORT Debug {
* }
* \endcode
*/
static V8_DEPRECATE_SOON(
"Use maybe version",
static V8_DEPRECATED("Use maybe version",
Local<Value> Call(v8::Local<v8::Function> fun,
Local<Value> data = Local<Value>()));
// TODO(dcarney): data arg should be a MaybeLocal
......@@ -212,7 +210,7 @@ class V8_EXPORT Debug {
/**
* Returns a mirror object for the given object.
*/
static V8_DEPRECATE_SOON("Use maybe version",
static V8_DEPRECATED("Use maybe version",
Local<Value> GetMirror(v8::Local<v8::Value> obj));
static MaybeLocal<Value> GetMirror(Local<Context> context,
v8::Local<v8::Value> obj);
......@@ -249,7 +247,7 @@ class V8_EXPORT Debug {
* of this method.
*/
static void ProcessDebugMessages(Isolate* isolate);
V8_DEPRECATE_SOON("Use version with an Isolate",
V8_DEPRECATED("Use version with an Isolate",
static void ProcessDebugMessages());
/**
......@@ -260,7 +258,7 @@ class V8_EXPORT Debug {
* least one DebugEventListener or MessageHandler is set.
*/
static Local<Context> GetDebugContext(Isolate* isolate);
V8_DEPRECATE_SOON("Use version with an Isolate",
V8_DEPRECATED("Use version with an Isolate",
static Local<Context> GetDebugContext());
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment