Commit 0eaba8f0 authored by Michael Starzinger's avatar Michael Starzinger Committed by Commit Bot

[iwyu] Fix some cctest IWYU violations.

This fixes include violations where normal "foo.h" headers included
inline "bar-inl.h" headers. It also removes two (almost) dead methods.

R=clemensh@chromium.org
BUG=v8:7754

Change-Id: I11c6ce71650db22f3c1d7cf5ca50529c94b94839
Reviewed-on: https://chromium-review.googlesource.com/1117076
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54060}
parent 2deeeb35
...@@ -109,7 +109,7 @@ void RunLoadStoreFloat32Offset(TestAlignment t) { ...@@ -109,7 +109,7 @@ void RunLoadStoreFloat32Offset(TestAlignment t) {
p1 = *j; p1 = *j;
p2 = *j - 5; p2 = *j - 5;
CHECK_EQ(magic, m.Call()); CHECK_EQ(magic, m.Call());
CheckDoubleEq(p1, p2); CHECK_DOUBLE_EQ(p1, p2);
} }
} }
} }
...@@ -145,7 +145,7 @@ void RunLoadStoreFloat64Offset(TestAlignment t) { ...@@ -145,7 +145,7 @@ void RunLoadStoreFloat64Offset(TestAlignment t) {
p1 = *j; p1 = *j;
p2 = *j - 5; p2 = *j - 5;
CHECK_EQ(magic, m.Call()); CHECK_EQ(magic, m.Call());
CheckDoubleEq(p1, p2); CHECK_DOUBLE_EQ(p1, p2);
} }
} }
} }
......
...@@ -11,7 +11,6 @@ ...@@ -11,7 +11,6 @@
#include "src/compiler/common-operator.h" #include "src/compiler/common-operator.h"
#include "src/compiler/node-matchers.h" #include "src/compiler/node-matchers.h"
#include "src/compiler/node.h" #include "src/compiler/node.h"
#include "src/heap/heap-inl.h"
#include "src/isolate.h" #include "src/isolate.h"
#include "src/objects.h" #include "src/objects.h"
#include "test/cctest/cctest.h" #include "test/cctest/cctest.h"
...@@ -54,14 +53,6 @@ class ValueHelper { ...@@ -54,14 +53,6 @@ class ValueHelper {
CHECK_EQ(expected, *HeapConstantOf(node->op())); CHECK_EQ(expected, *HeapConstantOf(node->op()));
} }
void CheckTrue(Node* node) {
CheckHeapConstant(isolate_->heap()->true_value(), node);
}
void CheckFalse(Node* node) {
CheckHeapConstant(isolate_->heap()->false_value(), node);
}
static constexpr float float32_array[] = { static constexpr float float32_array[] = {
-std::numeric_limits<float>::infinity(), -std::numeric_limits<float>::infinity(),
-2.70497e+38f, -2.70497e+38f,
...@@ -379,12 +370,6 @@ std::ostream& operator<<(std::ostream& out, FloatCompareWrapper<type> wrapper) { ...@@ -379,12 +370,6 @@ std::ostream& operator<<(std::ostream& out, FloatCompareWrapper<type> wrapper) {
CHECK_EQ(DoubleWrapper(lhs), rhs); \ CHECK_EQ(DoubleWrapper(lhs), rhs); \
} while (false) } while (false)
// TODO(all): Use CHECK_FLOAT_EQ to get error reported at the right location.
static inline void CheckFloatEq(float x, float y) { CHECK_FLOAT_EQ(x, y); }
// TODO(all): Use CHECK_DOUBLE_EQ to get error reported at the right location.
static inline void CheckDoubleEq(double x, double y) { CHECK_DOUBLE_EQ(x, y); }
} // namespace compiler } // namespace compiler
} // namespace internal } // namespace internal
} // namespace v8 } // namespace v8
......
...@@ -5,7 +5,6 @@ ...@@ -5,7 +5,6 @@
#ifndef WASM_ATOMICOP_UTILS_H #ifndef WASM_ATOMICOP_UTILS_H
#define WASM_ATOMICOP_UTILS_H #define WASM_ATOMICOP_UTILS_H
#include "src/objects-inl.h"
#include "test/cctest/cctest.h" #include "test/cctest/cctest.h"
#include "test/cctest/compiler/value-helper.h" #include "test/cctest/compiler/value-helper.h"
#include "test/cctest/wasm/wasm-run-utils.h" #include "test/cctest/wasm/wasm-run-utils.h"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment