Commit 0e988e47 authored by machenbach's avatar machenbach Committed by Commit bot

[test] Remove some deprecated test-runner variant shortcuts

It should be enough to specify --variants=... with the
desired set of variants. The stress/nostress shortcuts
might get confusing soon, as we intend to move the stress
option out of the developer default set.

BUG=v8:5238

Review-Url: https://codereview.chromium.org/2195373002
Cr-Commit-Position: refs/heads/master@{#38248}
parent 1515ddd8
...@@ -301,9 +301,6 @@ def BuildOptions(): ...@@ -301,9 +301,6 @@ def BuildOptions():
result.add_option("--no-sorting", "--nosorting", result.add_option("--no-sorting", "--nosorting",
help="Don't sort tests according to duration of last run.", help="Don't sort tests according to duration of last run.",
default=False, dest="no_sorting", action="store_true") default=False, dest="no_sorting", action="store_true")
result.add_option("--no-stress", "--nostress",
help="Don't run crankshaft --always-opt --stress-op test",
default=False, dest="no_stress", action="store_true")
result.add_option("--no-variants", "--novariants", result.add_option("--no-variants", "--novariants",
help="Don't run any testing variants", help="Don't run any testing variants",
default=False, dest="no_variants", action="store_true") default=False, dest="no_variants", action="store_true")
...@@ -349,9 +346,6 @@ def BuildOptions(): ...@@ -349,9 +346,6 @@ def BuildOptions():
help="Don't skip more slow tests when using a simulator.", help="Don't skip more slow tests when using a simulator.",
default=False, action="store_true", default=False, action="store_true",
dest="dont_skip_simulator_slow_tests") dest="dont_skip_simulator_slow_tests")
result.add_option("--stress-only",
help="Only run tests with --always-opt --stress-opt",
default=False, action="store_true")
result.add_option("--swarming", result.add_option("--swarming",
help="Indicates running test driver on swarming.", help="Indicates running test driver on swarming.",
default=False, action="store_true") default=False, action="store_true")
...@@ -545,23 +539,15 @@ def ProcessOptions(options): ...@@ -545,23 +539,15 @@ def ProcessOptions(options):
"""Returns true if zero or one of multiple arguments are true.""" """Returns true if zero or one of multiple arguments are true."""
return reduce(lambda x, y: x + y, args) <= 1 return reduce(lambda x, y: x + y, args) <= 1
if not excl(options.no_stress, options.stress_only, options.no_variants, if not excl(options.no_variants, bool(options.variants)):
bool(options.variants)): print("Use only one of --no-variants or --variants.")
print("Use only one of --no-stress, --stress-only, --no-variants, "
"or --variants.")
return False return False
if options.quickcheck: if options.quickcheck:
VARIANTS = ["default", "stress"] VARIANTS = ["default", "stress"]
options.slow_tests = "skip" options.slow_tests = "skip"
options.pass_fail_tests = "skip" options.pass_fail_tests = "skip"
if options.no_stress:
# FIXME(machenbach): This is not very intuitive anymore. Maybe remove a
# bunch of these shortcuts and require stating the variants explicitly.
VARIANTS = ["default", "nocrankshaft"]
if options.no_variants: if options.no_variants:
VARIANTS = ["default"] VARIANTS = ["default"]
if options.stress_only:
VARIANTS = ["stress"]
if options.variants: if options.variants:
VARIANTS = options.variants.split(",") VARIANTS = options.variants.split(",")
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment