Skip to content

V
V8
Commit 0e539d1c authored by arv's avatar arv Committed by Commit bot
Browse files
Options

Revert "ES6: Number and Boolean prototype should be ordinary objects" 

This reverts commit e965a1f8.

The reason is that it breaks jsfiddle.com

BUG=476437, v8:4001
LOG=N
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/1086673002

Cr-Commit-Position: refs/heads/master@{#27791}
parent dc65e62a
Show whitespace changes
Inline Side-by-side
Showing with 59 additions and 68 deletions
src/v8natives.js
View file @ 0e539d1c
......@@ -1513,7 +1513,7 @@ function SetUpBoolean () {
%CheckIsBootstrapping();
%SetCode($Boolean, BooleanConstructor);
%FunctionSetPrototype($Boolean, new $Object());
%FunctionSetPrototype($Boolean, new $Boolean(false));
%AddNamedProperty($Boolean.prototype, "constructor", $Boolean, DONT_ENUM);
InstallFunctions($Boolean.prototype, DONT_ENUM, [
......@@ -1692,7 +1692,7 @@ function SetUpNumber() {
%CheckIsBootstrapping();
%SetCode($Number, NumberConstructor);
%FunctionSetPrototype($Number, new $Object());
%FunctionSetPrototype($Number, new $Number(0));
%OptimizeObjectForAddingMultipleProperties($Number.prototype, 8);
// Set up the constructor property on the Number prototype object.
......
test/mjsunit/es6/prototype-ordinary-objects.js
View file @ 0e539d1c
......@@ -23,8 +23,11 @@ var funcs = [
// https://code.google.com/p/v8/issues/detail?id=4006
// String,
// Boolean,
// Number,
// https://code.google.com/p/v8/issues/detail?id=4001
ArrayBuffer,
Boolean,
DataView,
Float32Array,
Float64Array,
......@@ -32,7 +35,6 @@ var funcs = [
Int32Array,
Int8Array,
Map,
Number,
Object,
Promise,
// Proxy,
......
test/mozilla/mozilla.status
View file @ 0e539d1c
......@@ -84,15 +84,6 @@
'ecma/String/15.5.4.8-1': [FAIL],
'ecma/String/15.5.4.9-1': [FAIL],
# Boolean.prototype and Number.prototype are ordinary objects in ES6
'ecma/Boolean/15.6.3.1': [FAIL],
'ecma/Boolean/15.6.4': [FAIL],
'ecma/Boolean/15.6.4-1': [FAIL],
'ecma/Number/15.7.4-1': [FAIL],
'ecma/Number/15.7.4.2-1': [FAIL],
'ecma/Number/15.7.4.3-1': [FAIL],
'ecma/extensions/15.7.4': [FAIL],
'ecma_2/FunctionObjects/call-1': [FAIL],
##################### SKIPPED TESTS #####################
......
test/test262-es6/test262-es6.status
View file @ 0e539d1c
......@@ -92,6 +92,53 @@
'language/computed-property-names/to-name-side-effects/class': [FAIL],
'language/computed-property-names/to-name-side-effects/numbers-class': [FAIL],
# Number.prototype is a plain object in ES6
'built-ins/Number/15.7.4-1': [FAIL],
'built-ins/Number/prototype/S15.7.3.1_A2_T1': [FAIL],
'built-ins/Number/prototype/S15.7.3.1_A2_T2': [FAIL],
'built-ins/Number/prototype/S15.7.3.1_A3': [FAIL],
'built-ins/Number/prototype/S15.7.4_A1': [FAIL],
'built-ins/Number/prototype/toFixed/S15.7.4.5_A1.1_T01': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A1_T01': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A1_T02': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A1_T03': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T01': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T02': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T03': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T04': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T05': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T06': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T07': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T08': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T09': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T10': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T11': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T12': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T13': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T14': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T15': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T16': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T17': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T18': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T19': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T20': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T21': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T22': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T23': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T24': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T25': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T26': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T27': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T28': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T29': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T30': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T31': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T32': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T33': [FAIL],
'built-ins/Number/prototype/toString/S15.7.4.2_A2_T34': [FAIL],
'built-ins/Number/prototype/valueOf/S15.7.4.4_A1_T01': [FAIL],
'built-ins/Number/prototype/valueOf/S15.7.4.4_A1_T02': [FAIL],
######################## OBSOLETED BY ES6 ###########################
# ES6 allows duplicate properties
......@@ -203,6 +250,12 @@
'built-ins/Array/prototype/splice/S15.4.4.12_A3_T1': [FAIL],
'built-ins/Array/prototype/splice/S15.4.4.12_A3_T3': [FAIL],
'built-ins/Array/prototype/unshift/S15.4.4.13_A3_T2': [FAIL],
'built-ins/Boolean/prototype/S15.6.3.1_A1': [FAIL],
'built-ins/Boolean/prototype/S15.6.4_A1': [FAIL],
'built-ins/Boolean/prototype/toString/S15.6.4.2_A1_T1': [FAIL],
'built-ins/Boolean/prototype/toString/S15.6.4.2_A1_T2': [FAIL],
'built-ins/Boolean/prototype/valueOf/S15.6.4.3_A1_T1': [FAIL],
'built-ins/Boolean/prototype/valueOf/S15.6.4.3_A1_T2': [FAIL],
'built-ins/Date/15.9.1.15-1': [FAIL],
'built-ins/Date/prototype/setFullYear/15.9.5.40_1': [FAIL],
'built-ins/Error/prototype/S15.11.4_A2': [FAIL],
......
test/test262/test262.status
View file @ 0e539d1c
......@@ -208,61 +208,6 @@
'15.2.3.3-1-3': [FAIL],
'15.2.3.3-1-4': [FAIL],
# Boolean.prototype is a plain object in ES6.
'S15.6.3.1_A1': [FAIL],
'S15.6.4.2_A1_T1': [FAIL],
'S15.6.4.2_A1_T2': [FAIL],
'S15.6.4.3_A1_T1': [FAIL],
'S15.6.4.3_A1_T2': [FAIL],
'S15.6.4_A1': [FAIL],
# Number.prototype is a plain object in ES6.
'15.7.4-1': [FAIL],
'S15.7.3.1_A2_T1': [FAIL],
'S15.7.3.1_A2_T2': [FAIL],
'S15.7.3.1_A3': [FAIL],
'S15.7.4.2_A1_T01': [FAIL],
'S15.7.4.2_A1_T02': [FAIL],
'S15.7.4.2_A1_T03': [FAIL],
'S15.7.4.2_A2_T01': [FAIL],
'S15.7.4.2_A2_T02': [FAIL],
'S15.7.4.2_A2_T03': [FAIL],
'S15.7.4.2_A2_T04': [FAIL],
'S15.7.4.2_A2_T05': [FAIL],
'S15.7.4.2_A2_T06': [FAIL],
'S15.7.4.2_A2_T07': [FAIL],
'S15.7.4.2_A2_T08': [FAIL],
'S15.7.4.2_A2_T09': [FAIL],
'S15.7.4.2_A2_T10': [FAIL],
'S15.7.4.2_A2_T11': [FAIL],
'S15.7.4.2_A2_T12': [FAIL],
'S15.7.4.2_A2_T13': [FAIL],
'S15.7.4.2_A2_T14': [FAIL],
'S15.7.4.2_A2_T15': [FAIL],
'S15.7.4.2_A2_T16': [FAIL],
'S15.7.4.2_A2_T17': [FAIL],
'S15.7.4.2_A2_T18': [FAIL],
'S15.7.4.2_A2_T19': [FAIL],
'S15.7.4.2_A2_T20': [FAIL],
'S15.7.4.2_A2_T21': [FAIL],
'S15.7.4.2_A2_T22': [FAIL],
'S15.7.4.2_A2_T23': [FAIL],
'S15.7.4.2_A2_T24': [FAIL],
'S15.7.4.2_A2_T25': [FAIL],
'S15.7.4.2_A2_T26': [FAIL],
'S15.7.4.2_A2_T27': [FAIL],
'S15.7.4.2_A2_T28': [FAIL],
'S15.7.4.2_A2_T29': [FAIL],
'S15.7.4.2_A2_T30': [FAIL],
'S15.7.4.2_A2_T31': [FAIL],
'S15.7.4.2_A2_T32': [FAIL],
'S15.7.4.2_A2_T33': [FAIL],
'S15.7.4.2_A2_T34': [FAIL],
'S15.7.4.4_A1_T01': [FAIL],
'S15.7.4.4_A1_T02': [FAIL],
'S15.7.4.5_A1.1_T01': [FAIL],
'S15.7.4_A1': [FAIL],
# Function restricted "caller" and "arguments" properties are defined only on
# the intrinsic %FunctionPrototype% (and sloppy functions) in ES6
'13.2-29-s': [FAIL],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment