Commit 0e4554b4 authored by Victor Gomes's avatar Victor Gomes Committed by V8 LUCI CQ

[baseline] Enable concurrent sparkplug on future

Bug: v8:12054
Change-Id: I9d5040c806232ecbe71c26b7d65acbc8005bbd00
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3233139
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77842}
parent ba713b8e
...@@ -518,6 +518,7 @@ DEFINE_BOOL(future, FUTURE_BOOL, ...@@ -518,6 +518,7 @@ DEFINE_BOOL(future, FUTURE_BOOL,
#if ENABLE_SPARKPLUG #if ENABLE_SPARKPLUG
DEFINE_WEAK_IMPLICATION(future, sparkplug) DEFINE_WEAK_IMPLICATION(future, sparkplug)
DEFINE_WEAK_IMPLICATION(future, flush_baseline_code) DEFINE_WEAK_IMPLICATION(future, flush_baseline_code)
DEFINE_WEAK_IMPLICATION(future, concurrent_sparkplug)
#endif #endif
#if V8_SHORT_BUILTIN_CALLS #if V8_SHORT_BUILTIN_CALLS
DEFINE_WEAK_IMPLICATION(future, short_builtin_calls) DEFINE_WEAK_IMPLICATION(future, short_builtin_calls)
......
...@@ -1373,6 +1373,10 @@ static const char* call_function_test_source = ...@@ -1373,6 +1373,10 @@ static const char* call_function_test_source =
// 1 1 bar [-1] #7 // 1 1 bar [-1] #7
// 19 19 (program) [-1] #2 // 19 19 (program) [-1] #2
TEST(FunctionCallSample) { TEST(FunctionCallSample) {
// Skip test if concurrent sparkplug is enabled. The test becomes flaky,
// since it requires a precise trace.
if (i::FLAG_concurrent_sparkplug) return;
i::FLAG_allow_natives_syntax = true; i::FLAG_allow_natives_syntax = true;
LocalContext env; LocalContext env;
v8::HandleScope scope(env->GetIsolate()); v8::HandleScope scope(env->GetIsolate());
...@@ -1430,6 +1434,10 @@ static const char* function_apply_test_source = ...@@ -1430,6 +1434,10 @@ static const char* function_apply_test_source =
// 2 2 bar [-1] #16 6 // 2 2 bar [-1] #16 6
// 10 10 (program) [-1] #0 2 // 10 10 (program) [-1] #0 2
TEST(FunctionApplySample) { TEST(FunctionApplySample) {
// Skip test if concurrent sparkplug is enabled. The test becomes flaky,
// since it requires a precise trace.
if (i::FLAG_concurrent_sparkplug) return;
i::FLAG_allow_natives_syntax = true; i::FLAG_allow_natives_syntax = true;
LocalContext env; LocalContext env;
v8::HandleScope scope(env->GetIsolate()); v8::HandleScope scope(env->GetIsolate());
...@@ -1909,6 +1917,10 @@ static const char* inlining_test_source2 = R"( ...@@ -1909,6 +1917,10 @@ static const char* inlining_test_source2 = R"(
// bailed out due to 'Optimization is always disabled' // bailed out due to 'Optimization is always disabled'
// 2 (program):0 0 #2 // 2 (program):0 0 #2
TEST(Inlining2) { TEST(Inlining2) {
// Skip test if concurrent sparkplug is enabled. The test becomes flaky,
// since it requires a precise trace.
if (FLAG_concurrent_sparkplug) return;
FLAG_allow_natives_syntax = true; FLAG_allow_natives_syntax = true;
v8::Isolate* isolate = CcTest::isolate(); v8::Isolate* isolate = CcTest::isolate();
LocalContext env; LocalContext env;
...@@ -1997,6 +2009,10 @@ static const char* cross_script_source_b = R"( ...@@ -1997,6 +2009,10 @@ static const char* cross_script_source_b = R"(
)"; )";
TEST(CrossScriptInliningCallerLineNumbers) { TEST(CrossScriptInliningCallerLineNumbers) {
// Skip test if concurrent sparkplug is enabled. The test becomes flaky,
// since it requires a precise trace.
if (i::FLAG_concurrent_sparkplug) return;
i::FLAG_allow_natives_syntax = true; i::FLAG_allow_natives_syntax = true;
v8::Isolate* isolate = CcTest::isolate(); v8::Isolate* isolate = CcTest::isolate();
LocalContext env; LocalContext env;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment