Commit 0d58297f authored by Ben Smith's avatar Ben Smith Committed by Commit Bot

Revert "[foozzie] Suppress access to CurrentTimeValue"

This reverts commit e26863df.

Reason for revert: Fails on noi18n bot, see https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20noi18n%20-%20debug/34852/overview

Original change's description:
> [foozzie] Suppress access to CurrentTimeValue
>
> This stubs out CurrentTimeValue for differential fuzzing as otherwise
> the non-deterministic value leaks from Intl.DateTimeFormat format and
> formatToParts.
>
> This also affects other date creations, like Date.now(), which is
> already stubbed out on the JS side. We keep that code for
> backwards-compatibility to keep bisection stable.
>
> Bug: chromium:1149050
> Change-Id: Ifd82844c9fb8ce7262b55da6cf9f88f544268942
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546685
> Reviewed-by: Camillo Bruni <cbruni@chromium.org>
> Reviewed-by: Clemens Backes <clemensb@chromium.org>
> Commit-Queue: Michael Achenbach <machenbach@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#71294}

TBR=machenbach@chromium.org,cbruni@chromium.org,clemensb@chromium.org

Change-Id: I958ca723de826ab427d27f5121f96618cf50c832
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1149050
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2551314Reviewed-by: 's avatarBen Smith <binji@chromium.org>
Commit-Queue: Ben Smith <binji@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71298}
parent ab52d525
...@@ -5094,7 +5094,6 @@ MaybeHandle<JSDate> JSDate::New(Handle<JSFunction> constructor, ...@@ -5094,7 +5094,6 @@ MaybeHandle<JSDate> JSDate::New(Handle<JSFunction> constructor,
// static // static
double JSDate::CurrentTimeValue(Isolate* isolate) { double JSDate::CurrentTimeValue(Isolate* isolate) {
if (FLAG_log_internal_timer_events) LOG(isolate, CurrentTimeEvent()); if (FLAG_log_internal_timer_events) LOG(isolate, CurrentTimeEvent());
if (FLAG_correctness_fuzzer_suppressions) return 4.2;
// According to ECMA-262, section 15.9.1, page 117, the precision of // According to ECMA-262, section 15.9.1, page 117, the precision of
// the number in a Date object representing a particular instant in // the number in a Date object representing a particular instant in
......
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --allow-natives-syntax --correctness-fuzzer-suppressions // Flags: --allow-natives-syntax
// Files: tools/clusterfuzz/v8_mock.js // Files: tools/clusterfuzz/v8_mock.js
// Test foozzie mocks for differential fuzzing. // Test foozzie mocks for differential fuzzing.
...@@ -22,11 +22,6 @@ assertEquals(710, new Date.prototype.constructor().getUTCMilliseconds()); ...@@ -22,11 +22,6 @@ assertEquals(710, new Date.prototype.constructor().getUTCMilliseconds());
assertEquals(819134640000, assertEquals(819134640000,
new Date('December 17, 1995 03:24:00 GMT+1000').getTime()); new Date('December 17, 1995 03:24:00 GMT+1000').getTime());
// Deterministic DateTimeFormat.
const df = new Intl.DateTimeFormat(undefined, {fractionalSecondDigits: 3});
assertEquals('004', df.format());
assertEquals('004', df.formatToParts()[0].value);
// Dummy performance methods. // Dummy performance methods.
assertEquals(1.2, performance.now()); assertEquals(1.2, performance.now());
assertEquals([], performance.measureMemory()); assertEquals([], performance.measureMemory());
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment