[wasm][liftoff][arm] Add missing handling of reference types to ...

... LiftoffStackSlots::Construct

R=thibaudm@chromium.org

Bug: chromium:1171788
Change-Id: Ifb8e20f4e81fe2c698fe1f51c0b833a6049f7558
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2659255Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72433}

src/wasm/baseline/arm/liftoff-assembler-arm.h

@@ -4142,7 +4142,9 @@ void LiftoffStackSlots::Construct() {
           // split into two i32 registers
           case ValueType::kI32:
           case ValueType::kI64:
-          case ValueType::kF32: {
+          case ValueType::kF32:
+          case ValueType::kRef:
+          case ValueType::kOptRef: {
             UseScratchRegisterScope temps(asm_);
             Register scratch = temps.Acquire();
             asm_->ldr(scratch,

test/mjsunit/regress/wasm/regress-1171788.js

+// Copyright 2021 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --wasm-staging
+
+load('test/mjsunit/wasm/wasm-module-builder.js');
+
+const builder = new WasmModuleBuilder();
+builder.addType(makeSig(
+    [
+      kWasmI32, kWasmI32, kWasmI32, kWasmI32, kWasmFuncRef, kWasmI32, kWasmI32,
+      kWasmI32, kWasmI32, kWasmI32
+    ],
+    [kWasmF64]));
+// Generate function 1 (out of 1).
+builder.addFunction(undefined, 0 /* sig */)
+  .addBodyWithEnd([
+// signature: d_iiiiniiiii
+// body:
+kExprLocalGet, 0x03,  // local.get
+kExprLocalGet, 0x08,  // local.get
+kExprLocalGet, 0x00,  // local.get
+kExprI32Const, 0x01,  // i32.const
+kExprLocalGet, 0x04,  // local.get
+kExprLocalGet, 0x05,  // local.get
+kExprLocalGet, 0x06,  // local.get
+kExprLocalGet, 0x00,  // local.get
+kExprLocalGet, 0x07,  // local.get
+kExprLocalGet, 0x06,  // local.get
+kExprCallFunction, 0x00,  // call function #0: d_iiiiniiiii
+kExprLocalGet, 0x00,  // local.get
+kExprLocalGet, 0x01,  // local.get
+kExprLocalGet, 0x00,  // local.get
+kExprLocalGet, 0x08,  // local.get
+kExprLocalGet, 0x01,  // local.get
+kExprLocalGet, 0x00,  // local.get
+kExprLocalGet, 0x01,  // local.get
+kExprLocalGet, 0x07,  // local.get
+kExprLocalGet, 0x08,  // local.get
+kExprLocalGet, 0x09,  // local.get
+kExprCallFunction, 0x00,  // call function #0: d_iiiiniiiii
+kExprUnreachable,  // unreachable
+kExprEnd,  // end @46
+]);
+assertThrows(function() { builder.instantiate(); }, WebAssembly.CompileError);