Commit 0cbb6b7c authored by Igor Sheludko's avatar Igor Sheludko Committed by Commit Bot

[sparkplug] Remove redundant optimization marker check

Bug: v8:11420,v8:11429
Change-Id: Ic08a1277b08a3de1ad1124dcedaeaf2fbd313c25
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2726495
Auto-Submit: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#73091}
parent ce4baffc
......@@ -1223,8 +1223,6 @@ void Builtins::Generate_BaselineOutOfLinePrologue(MacroAssembler* masm) {
__ Assert(eq, AbortReason::kExpectedFeedbackVector);
}
__ RecordComment("[ Check optimization state");
// Check for an optimization marker.
Label has_optimized_code_or_marker;
Register optimization_state = temps.AcquireW();
......@@ -1584,19 +1582,6 @@ void Builtins::Generate_InterpreterEntryTrampoline(MacroAssembler* masm) {
masm, optimization_state, feedback_vector,
&has_optimized_code_or_marker);
// Read off the optimization state in the feedback vector.
// TODO(v8:11429): Is this worth doing here? Baseline code will check it
// anyway...
__ Ldr(optimization_state,
FieldMemOperand(feedback_vector, FeedbackVector::kFlagsOffset));
// Check if there is optimized code or a optimization marker that needes to
// be processed.
__ TestAndBranchIfAnySet(
optimization_state,
FeedbackVector::kHasOptimizedCodeOrCompileOptimizedMarkerMask,
&has_optimized_code_or_marker);
// Load the baseline code into the closure.
__ LoadTaggedPointerField(
x2, FieldMemOperand(kInterpreterBytecodeArrayRegister,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment