Commit 0ca4ad1f authored by Clemens Backes's avatar Clemens Backes Committed by Commit Bot

[wasm] Make trace event arguments camelCase

This seems to be the convention in other trace events.

R=ahaas@chromium.org

Bug: v8:11074
Change-Id: Icf7be6ba3d52cac8c77dec787f294a3edee44d20
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2521590
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71017}
parent d90b2c0c
...@@ -4111,7 +4111,7 @@ WasmCompilationResult ExecuteLiftoffCompilation( ...@@ -4111,7 +4111,7 @@ WasmCompilationResult ExecuteLiftoffCompilation(
std::unique_ptr<DebugSideTable>* debug_sidetable, int dead_breakpoint) { std::unique_ptr<DebugSideTable>* debug_sidetable, int dead_breakpoint) {
int func_body_size = static_cast<int>(func_body.end - func_body.start); int func_body_size = static_cast<int>(func_body.end - func_body.start);
TRACE_EVENT2(TRACE_DISABLED_BY_DEFAULT("v8.wasm.detailed"), TRACE_EVENT2(TRACE_DISABLED_BY_DEFAULT("v8.wasm.detailed"),
"wasm.CompileBaseline", "func_index", func_index, "body_size", "wasm.CompileBaseline", "funcIndex", func_index, "bodySize",
func_body_size); func_body_size);
Zone zone(allocator, "LiftoffCompilationZone"); Zone zone(allocator, "LiftoffCompilationZone");
......
...@@ -2960,7 +2960,7 @@ void CompilationStateImpl::FinalizeJSToWasmWrappers( ...@@ -2960,7 +2960,7 @@ void CompilationStateImpl::FinalizeJSToWasmWrappers(
// optimization we keep the code space unlocked to avoid repeated unlocking // optimization we keep the code space unlocked to avoid repeated unlocking
// because many such wrapper are allocated in sequence below. // because many such wrapper are allocated in sequence below.
TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("v8.wasm.detailed"), TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("v8.wasm.detailed"),
"wasm.FinalizeJSToWasmWrappers", "num_wrappers", "wasm.FinalizeJSToWasmWrappers", "wrappers",
js_to_wasm_wrapper_units_.size()); js_to_wasm_wrapper_units_.size());
CodeSpaceMemoryModificationScope modification_scope(isolate->heap()); CodeSpaceMemoryModificationScope modification_scope(isolate->heap());
for (auto& unit : js_to_wasm_wrapper_units_) { for (auto& unit : js_to_wasm_wrapper_units_) {
...@@ -2985,7 +2985,7 @@ CompilationStateImpl::GetNextCompilationUnit( ...@@ -2985,7 +2985,7 @@ CompilationStateImpl::GetNextCompilationUnit(
void CompilationStateImpl::OnFinishedUnits(Vector<WasmCode*> code_vector) { void CompilationStateImpl::OnFinishedUnits(Vector<WasmCode*> code_vector) {
TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("v8.wasm.detailed"), TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("v8.wasm.detailed"),
"wasm.OnFinishedUnits", "num_units", code_vector.size()); "wasm.OnFinishedUnits", "units", code_vector.size());
base::MutexGuard guard(&callbacks_mutex_); base::MutexGuard guard(&callbacks_mutex_);
......
...@@ -858,7 +858,7 @@ void NativeModule::ReserveCodeTableForTesting(uint32_t max_functions) { ...@@ -858,7 +858,7 @@ void NativeModule::ReserveCodeTableForTesting(uint32_t max_functions) {
void NativeModule::LogWasmCodes(Isolate* isolate) { void NativeModule::LogWasmCodes(Isolate* isolate) {
if (!WasmCode::ShouldBeLogged(isolate)) return; if (!WasmCode::ShouldBeLogged(isolate)) return;
TRACE_EVENT1("v8.wasm", "wasm.LogWasmCodes", "num_functions", TRACE_EVENT1("v8.wasm", "wasm.LogWasmCodes", "functions",
module_->num_declared_functions); module_->num_declared_functions);
// TODO(titzer): we skip the logging of the import wrappers // TODO(titzer): we skip the logging of the import wrappers
......
...@@ -1036,8 +1036,7 @@ void WasmEngine::LogOutstandingCodesForIsolate(Isolate* isolate) { ...@@ -1036,8 +1036,7 @@ void WasmEngine::LogOutstandingCodesForIsolate(Isolate* isolate) {
DCHECK_EQ(1, isolates_.count(isolate)); DCHECK_EQ(1, isolates_.count(isolate));
code_to_log.swap(isolates_[isolate]->code_to_log); code_to_log.swap(isolates_[isolate]->code_to_log);
} }
TRACE_EVENT1("v8.wasm", "wasm.LogCode", "num_code_objects", TRACE_EVENT1("v8.wasm", "wasm.LogCode", "codeObjects", code_to_log.size());
code_to_log.size());
if (code_to_log.empty()) return; if (code_to_log.empty()) return;
for (WasmCode* code : code_to_log) { for (WasmCode* code : code_to_log) {
code->LogCode(isolate); code->LogCode(isolate);
......
...@@ -108,7 +108,7 @@ WasmStreaming::WasmStreaming(std::unique_ptr<WasmStreamingImpl> impl) ...@@ -108,7 +108,7 @@ WasmStreaming::WasmStreaming(std::unique_ptr<WasmStreamingImpl> impl)
WasmStreaming::~WasmStreaming() = default; WasmStreaming::~WasmStreaming() = default;
void WasmStreaming::OnBytesReceived(const uint8_t* bytes, size_t size) { void WasmStreaming::OnBytesReceived(const uint8_t* bytes, size_t size) {
TRACE_EVENT1("v8.wasm", "wasm.OnBytesReceived", "num_bytes", size); TRACE_EVENT1("v8.wasm", "wasm.OnBytesReceived", "bytes", size);
impl_->OnBytesReceived(bytes, size); impl_->OnBytesReceived(bytes, size);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment