[builtins] Revert tentative builtin symbol exposure

This reverts two CLs that were intended to show symbols for embedded builtins in chromecrash. The symbols never showed up, a part of this must still be missing.

Revert "[builtins] Declare builtin symbols as globals"
This reverts commit 8412353c.

Revert "[builtins] Declare builtin symbols"
This reverts commit 17ad3ae4.

TBR=yangguo@chromium.org

Bug: v8:6666, v8:7722
Change-Id: Ifcbf56a36ea51ea65de77c507886402f3663f414
Reviewed-on: https://chromium-review.googlesource.com/1195493Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55515}

src/snapshot/macros.h

@@ -39,7 +39,7 @@
 #if defined(V8_TARGET_ARCH_MIPS) || defined(V8_TARGET_ARCH_MIPS64)
 #define V8_ASM_DECLARE(NAME) ".global " V8_ASM_MANGLE_LABEL NAME "\n"
 #else
-#define V8_ASM_DECLARE(NAME) ".global " V8_ASM_MANGLE_LABEL NAME "\n"
+#define V8_ASM_DECLARE(NAME) ".local " V8_ASM_MANGLE_LABEL NAME "\n"
 #endif
 #endif
 

src/snapshot/mksnapshot.cc

@@ -190,13 +190,9 @@ class SnapshotWriter {
       // stream.
       if (is_default_variant) {
         // Create nicer symbol names for the default mode.
-        fprintf(fp, "__asm__(\"\" V8_ASM_DECLARE(\"Builtins_%s\"));\n",
-                i::Builtins::name(i));
         fprintf(fp, "__asm__(V8_ASM_LABEL(\"Builtins_%s\"));\n",
                 i::Builtins::name(i));
       } else {
-        fprintf(fp, "__asm__(\"\" V8_ASM_DECLARE(\"%s_Builtins_%s\"));\n",
-                embedded_variant, i::Builtins::name(i));
         fprintf(fp, "__asm__(V8_ASM_LABEL(\"%s_Builtins_%s\"));\n",
                 embedded_variant, i::Builtins::name(i));
       }