Better fix for --trace-ic source positions: Use HOptimizedGraphBuilderWithPositions

This reverts the changes made in r22008.

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/355823003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22012 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent addd35df
...@@ -394,7 +394,7 @@ OptimizedCompileJob::Status OptimizedCompileJob::CreateGraph() { ...@@ -394,7 +394,7 @@ OptimizedCompileJob::Status OptimizedCompileJob::CreateGraph() {
// Type-check the function. // Type-check the function.
AstTyper::Run(info()); AstTyper::Run(info());
graph_builder_ = FLAG_hydrogen_track_positions graph_builder_ = (FLAG_hydrogen_track_positions || FLAG_trace_ic)
? new(info()->zone()) HOptimizedGraphBuilderWithPositions(info()) ? new(info()->zone()) HOptimizedGraphBuilderWithPositions(info())
: new(info()->zone()) HOptimizedGraphBuilder(info()); : new(info()->zone()) HOptimizedGraphBuilder(info());
......
...@@ -6512,7 +6512,6 @@ void HOptimizedGraphBuilder::VisitAssignment(Assignment* expr) { ...@@ -6512,7 +6512,6 @@ void HOptimizedGraphBuilder::VisitAssignment(Assignment* expr) {
ASSERT(!HasStackOverflow()); ASSERT(!HasStackOverflow());
ASSERT(current_block() != NULL); ASSERT(current_block() != NULL);
ASSERT(current_block()->HasPredecessor()); ASSERT(current_block()->HasPredecessor());
if (!FLAG_hydrogen_track_positions) SetSourcePosition(expr->position());
VariableProxy* proxy = expr->target()->AsVariableProxy(); VariableProxy* proxy = expr->target()->AsVariableProxy();
Property* prop = expr->target()->AsProperty(); Property* prop = expr->target()->AsProperty();
ASSERT(proxy == NULL || prop == NULL); ASSERT(proxy == NULL || prop == NULL);
...@@ -7214,8 +7213,6 @@ void HOptimizedGraphBuilder::VisitProperty(Property* expr) { ...@@ -7214,8 +7213,6 @@ void HOptimizedGraphBuilder::VisitProperty(Property* expr) {
ASSERT(current_block() != NULL); ASSERT(current_block() != NULL);
ASSERT(current_block()->HasPredecessor()); ASSERT(current_block()->HasPredecessor());
if (!FLAG_hydrogen_track_positions) SetSourcePosition(expr->position());
if (TryArgumentsAccess(expr)) return; if (TryArgumentsAccess(expr)) return;
CHECK_ALIVE(VisitForValue(expr->obj())); CHECK_ALIVE(VisitForValue(expr->obj()));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment