Commit 0ab6cc73 authored by Tobias Tebbi's avatar Tobias Tebbi Committed by Commit Bot

[torque] disable Windows ASAN unittests

Due to bug chromium:893437, Torque has ASAN disabled on Windows, which
makes it impossible to run unittests for Torque with ASAN being enabled
in the unittests. To fix this, this skips Torque unittests in the
unsupported configuration.

Bug: chromium:893437
Change-Id: I6c8eee1448c63223af4d7336954190e649d125e9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1632214Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61891}
parent 6adb9f29
......@@ -3388,6 +3388,8 @@ v8_source_set("torque_base") {
]
if (is_win && is_asan) {
# Due to a bug in ASAN on Windows (chromium:893437), we disable ASAN for
# Torque on Windows.
remove_configs += [ "//build/config/sanitizers:default_sanitizer_flags" ]
}
......
......@@ -232,11 +232,6 @@ class Stack {
elements_.at(from_bottom.offset) = std::move(x);
}
void Push(T x) {
// Manually increasing the std::vector capacity is a workaround for an
// ASAN-container-overflow false positive.
if (elements_.size() == elements_.capacity()) {
elements_.reserve(2 * elements_.size() + 1);
}
elements_.push_back(std::move(x));
}
StackRange TopRange(size_t slot_count) const {
......
......@@ -34,4 +34,9 @@
'*': [SKIP],
}], # variant == jitless and not embedded_builtins
['system == windows and asan', {
# BUG(893437).
'Torque*': [SKIP],
}], # 'system == windows and asan'
]
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment