Commit 0a713473 authored by Sergiy Byelozyorov's avatar Sergiy Byelozyorov Committed by Commit Bot

Revert "[tools] Add benchmark owners to the config"

This reverts commit 989285b7.

Reason for revert: broke internal bots

Original change's description:
> [tools] Add benchmark owners to the config
> 
> R=​machenbach@chromium.org
> 
> No-Try: true
> Bug: chromium:826280
> Change-Id: Ic34d13170dfecdd9e791974a34c33ba0248c7a38
> Reviewed-on: https://chromium-review.googlesource.com/1053809
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53138}

TBR=machenbach@chromium.org,sergiyb@chromium.org

Change-Id: Iec3f8fa8eda77b1bcfb00274b28a12e4d233d6c4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:826280
Reviewed-on: https://chromium-review.googlesource.com/1057091Reviewed-by: 's avatarSergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53140}
parent 91ddb65d
{
"owners": ["jarin@chromium.org", "mvstanston@chromium.org"],
"name": "JSTests",
"run_count": 3,
"run_count_arm": 1,
......
{
"owners": ["jgruber@chromium.org", "yangguo@chromium.org"],
"name": "RegExp",
"run_count": 3,
"run_count_arm": 1,
......
{
"owners": ["jarin@chromium.org", "mvstanston@chromium.org"],
"name": "SixSpeed",
"run_count": 3,
"run_count_arm": 1,
......
{
"owners": ["yangguo@chromium.org"],
"name": "Memory",
"run_count": 5,
"units": "bytes",
......
......@@ -11,7 +11,6 @@ Call e.g. with tools/run-perf.py --arch ia32 some_suite.json
The suite json format is expected to be:
{
"path": <relative path chunks to perf resources and main file>,
"owners": [<list of email addresses of benchmark owners (required)>],
"name": <optional suite name, file name is default>,
"archs": [<architecture name for which this suite is run>, ...],
"binary": <name of binary to run, default "d8">,
......@@ -56,7 +55,6 @@ A suite without "tests" is considered a performance test itself.
Full example (suite with one runner):
{
"path": ["."],
"owner": ["username@chromium.org"],
"flags": ["--expose-gc"],
"test_flags": ["5"],
"archs": ["ia32", "x64"],
......@@ -76,7 +74,6 @@ Full example (suite with one runner):
Full example (suite with several runners):
{
"path": ["."],
"owner": ["username@chromium.org", "otherowner@google.com"],
"flags": ["--expose-gc"],
"archs": ["ia32", "x64"],
"run_count": 5,
......@@ -404,7 +401,6 @@ class GraphConfig(Node):
self._suite = suite
assert isinstance(suite.get("path", []), list)
assert isinstance(suite.get("owners", []), list)
assert isinstance(suite["name"], basestring)
assert isinstance(suite.get("flags", []), list)
assert isinstance(suite.get("test_flags", []), list)
......@@ -415,7 +411,6 @@ class GraphConfig(Node):
self.graphs = parent.graphs[:] + [suite["name"]]
self.flags = parent.flags[:] + suite.get("flags", [])
self.test_flags = parent.test_flags[:] + suite.get("test_flags", [])
self.owners = parent.owners[:] + suite.get("owners", [])
# Values independent of parent node.
self.resources = suite.get("resources", [])
......@@ -456,7 +451,6 @@ class TraceConfig(GraphConfig):
def __init__(self, suite, parent, arch):
super(TraceConfig, self).__init__(suite, parent, arch)
assert self.results_regexp
assert self.owners
def CreateMeasurement(self, perform_measurement):
if not perform_measurement:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment