include only stuff you need, part 1: ast.h, ast-value-factory.h.

Rebuilding (after touching certain files) is crazy slow because
includes are out of control.

Fixing it:
- Don't include stuff in headers unless necessary.
- Include the stuff you need, not some other stuff that happens to include the
stuff you need.

BUG=v8:5294

Review-Url: https://codereview.chromium.org/2246203005
Cr-Commit-Position: refs/heads/master@{#38708}

src/allocation-site-scopes.cc

@@ -3,6 +3,9 @@
 // found in the LICENSE file.
 
 #include "src/allocation-site-scopes.h"
+#include "src/factory.h"
+#include "src/isolate.h"
+#include "src/objects-inl.h"
 
 namespace v8 {
 namespace internal {

src/allocation-site-scopes.h

@@ -5,10 +5,8 @@
 #ifndef V8_ALLOCATION_SITE_SCOPES_H_
 #define V8_ALLOCATION_SITE_SCOPES_H_
 
-#include "src/ast/ast.h"
 #include "src/handles.h"
 #include "src/objects.h"
-#include "src/zone.h"
 
 namespace v8 {
 namespace internal {

src/asmjs/asm-js.cc

@@ -9,8 +9,6 @@
 #include "src/asmjs/asm-typer.h"
 #include "src/asmjs/asm-wasm-builder.h"
 #include "src/assert-scope.h"
-#include "src/ast/ast.h"
-#include "src/ast/scopes.h"
 #include "src/execution.h"
 #include "src/factory.h"
 #include "src/handles.h"

src/ast/variables.cc

@@ -4,7 +4,6 @@
 
 #include "src/ast/variables.h"
 
-#include "src/ast/ast.h"
 #include "src/ast/scopes.h"
 #include "src/globals.h"
 

src/compiler.h

@@ -8,9 +8,12 @@
 #include <memory>
 
 #include "src/allocation.h"
-#include "src/ast/ast.h"
 #include "src/bailout-reason.h"
 #include "src/compilation-dependencies.h"
+#include "src/contexts.h"
+#include "src/frames.h"
+#include "src/isolate.h"
+#include "src/objects-inl.h"
 #include "src/source-position-table.h"
 #include "src/source-position.h"
 #include "src/zone.h"

src/crankshaft/hydrogen-osr.h

@@ -5,13 +5,14 @@
 #ifndef V8_CRANKSHAFT_HYDROGEN_OSR_H_
 #define V8_CRANKSHAFT_HYDROGEN_OSR_H_
 
-#include "src/ast/ast.h"
 #include "src/crankshaft/hydrogen.h"
 #include "src/zone.h"
 
 namespace v8 {
 namespace internal {
 
+class IterationStatement;
+
 // Responsible for building graph parts related to OSR and otherwise
 // setting up the graph to do an OSR compile.
 class HOsrBuilder : public ZoneObject {

src/crankshaft/typing.h

@@ -7,8 +7,8 @@
 
 #include "src/allocation.h"
 #include "src/ast/ast-type-bounds.h"
-#include "src/ast/ast.h"
 #include "src/ast/scopes.h"
+#include "src/ast/variables.h"
 #include "src/effects.h"
 #include "src/type-info.h"
 #include "src/types.h"
@@ -17,6 +17,8 @@
 namespace v8 {
 namespace internal {
 
+class FunctionLiteral;
+
 class AstTyper final : public AstVisitor<AstTyper> {
  public:
   AstTyper(Isolate* isolate, Zone* zone, Handle<JSFunction> closure,

src/frames.cc

@@ -7,7 +7,6 @@
 #include <memory>
 #include <sstream>
 
-#include "src/ast/ast.h"
 #include "src/base/bits.h"
 #include "src/deoptimizer.h"
 #include "src/frames-inl.h"

src/isolate.cc

@@ -9,7 +9,6 @@
 #include <fstream>  // NOLINT(readability/streams)
 #include <sstream>
 
-#include "src/ast/ast.h"
 #include "src/ast/context-slot-cache.h"
 #include "src/base/platform/platform.h"
 #include "src/base/sys-info.h"

src/parsing/parameter-initializer-rewriter.h

@@ -5,11 +5,14 @@
 #ifndef V8_PARSING_PARAMETER_EXPRESSION_REWRITER_H_
 #define V8_PARSING_PARAMETER_EXPRESSION_REWRITER_H_
 
-#include "src/ast/ast.h"
+#include "src/types.h"
 
 namespace v8 {
 namespace internal {
 
+class Expression;
+class Scope;
+
 // When an extra declaration scope needs to be inserted to account for
 // a sloppy eval in a default parameter or function body, the expressions
 // needs to be in that new inner scope which was added after initial

src/regexp/jsregexp.cc

@@ -6,7 +6,6 @@
 
 #include <memory>
 
-#include "src/ast/ast.h"
 #include "src/base/platform/platform.h"
 #include "src/compilation-cache.h"
 #include "src/compiler.h"

src/runtime/runtime-literals.cc

@@ -6,7 +6,6 @@
 
 #include "src/allocation-site-scopes.h"
 #include "src/arguments.h"
-#include "src/ast/ast.h"
 #include "src/isolate-inl.h"
 #include "src/parsing/parser.h"
 #include "src/runtime/runtime.h"