Commit 09b7a8b8 authored by Alex Gough's avatar Alex Gough Committed by V8 LUCI CQ

When cet is disabled, propagate to v8_shell

Before: when cet is disabled v8_shell is marked with the
cetcompat bit, which breaks the chromium build on cet
machines.

With this CL: v8_shell is not marked as cetcompat unless
v8_enable_cet_shadow_stacks is true.

Bug: chromium:1289318
Change-Id: If8a79ac5288a9a3385bf6b692db566508cca248f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3656146
Commit-Queue: Alex Gough <ajgo@chromium.org>
Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80673}
parent e819612a
......@@ -6399,6 +6399,10 @@ if (want_v8_shell) {
":internal_config_base",
]
if (is_win && !v8_enable_cet_shadow_stack) {
v8_remove_configs += [ "//build/config/compiler:cet_shadow_stack" ]
}
deps = [
":v8",
":v8_libbase",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment