Commit 0920f176 authored by Michael Achenbach's avatar Michael Achenbach Committed by Commit Bot

[test] Update whitelisted runtime-functions for fuzzing

We should not allow runtime functions that perform extra checks in
differential fuzzing, as there we ignore crashes and dchecks entirely.

Furthermore, this change whitelists some runtime functions for getting
more coverage.

Bug: chromium:1044942
Change-Id: Ie5d90bb53bc2d2bacc6635b1dcbe466605b33e12
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2041444
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/master@{#66205}
parent 4fa45c6d
......@@ -196,20 +196,23 @@ bool Runtime::IsWhitelistedForFuzzing(FunctionId id) {
CHECK(FLAG_allow_natives_for_fuzzing);
switch (id) {
// Runtime functions whitelisted for all fuzzers. Only add functions that
// help increase coverage or that perform extra checks.
// help increase coverage.
case Runtime::kArrayBufferDetach:
case Runtime::kDeoptimizeFunction:
case Runtime::kDeoptimizeNow:
case Runtime::kEnableCodeLoggingForTesting:
case Runtime::kGetUndetectable:
case Runtime::kHeapObjectVerify:
case Runtime::kNeverOptimizeFunction:
case Runtime::kOptimizeFunctionOnNextCall:
case Runtime::kOptimizeOsr:
case Runtime::kPrepareFunctionForOptimization:
case Runtime::kSetAllocationTimeout:
case Runtime::kSimulateNewspaceFull:
return true;
// Runtime functions only permitted for non-differential fuzzers.
// This list may contain functions returning different values in the
// context of different flags passed to V8.
// This list may contain functions performing extra checks or returning
// different values in the context of different flags passed to V8.
case Runtime::kHeapObjectVerify:
case Runtime::kIsBeingInterpreted:
return !FLAG_allow_natives_for_differential_fuzzing;
default:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment