Commit 08bfc14b authored by Michael Achenbach's avatar Michael Achenbach Committed by Commit Bot

Revert "[in-place weak refs] Fix: allow weak array types in large object space."

This reverts commit 96186c4f.

Reason for revert: All gc stress bots time out:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/16361

Original change's description:
> [in-place weak refs] Fix: allow weak array types in large object space.
> 
> BUG=v8:7308,chromium:839953
> 
> Change-Id: I3738dc8169730763a587a2452421a54aff11e38e
> Reviewed-on: https://chromium-review.googlesource.com/1046645
> Commit-Queue: Marja Hölttä <marja@chromium.org>
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53016}

TBR=ulan@chromium.org,marja@chromium.org

Change-Id: I030638c27fd8990b9dab3d25a582039fb893bf78
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:7308, chromium:839953
Reviewed-on: https://chromium-review.googlesource.com/1046549Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53019}
parent 7235c851
...@@ -3472,11 +3472,14 @@ void LargeObjectSpace::Verify() { ...@@ -3472,11 +3472,14 @@ void LargeObjectSpace::Verify() {
CHECK(heap()->map_space()->Contains(map) || CHECK(heap()->map_space()->Contains(map) ||
heap()->read_only_space()->Contains(map)); heap()->read_only_space()->Contains(map));
// We have only the following types in the large object space: // We have only code, sequential strings, external strings (sequential
// strings that have been morphed into external strings), thin strings
// (sequential strings that have been morphed into thin strings), fixed
// arrays, fixed double arrays, byte arrays, feedback vectors, bigints and
// free space (right after allocation) in the large object space.
CHECK(object->IsAbstractCode() || object->IsSeqString() || CHECK(object->IsAbstractCode() || object->IsSeqString() ||
object->IsExternalString() || object->IsThinString() || object->IsExternalString() || object->IsThinString() ||
object->IsFixedArray() || object->IsFixedDoubleArray() || object->IsFixedArray() || object->IsFixedDoubleArray() ||
object->IsWeakFixedArray() || object->IsWeakArrayList() ||
object->IsPropertyArray() || object->IsByteArray() || object->IsPropertyArray() || object->IsByteArray() ||
object->IsFeedbackVector() || object->IsBigInt() || object->IsFeedbackVector() || object->IsBigInt() ||
object->IsFreeSpace()); object->IsFreeSpace());
......
// Copyright 2018 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --verify-heap
var code = '';
for (let i = 0; i < 1 << 16; i++) {
code += 'x' + i + '= function() {};\n';
}
eval(code);
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment