Skip to content

V
V8
Commit 07ada64a authored by kozyatinskiy's avatar kozyatinskiy Committed by Commit bot
Browse files
Options

[inspector] added length for scriptParsed notification 

BUG=none
R=caseq@chromium.org

Review-Url: https://codereview.chromium.org/2740623002
Cr-Commit-Position: refs/heads/master@{#43656}
parent f774d8c5
Hide whitespace changes
Inline Side-by-side
Showing with 59 additions and 4 deletions
src/inspector/js_protocol.json
View file @ 07ada64a
......@@ -712,7 +712,8 @@
{ "name": "isLiveEdit", "type": "boolean", "optional": true, "description": "True, if this script is generated as a result of the live edit operation.", "experimental": true },
{ "name": "sourceMapURL", "type": "string", "optional": true, "description": "URL of source map associated with script (if any)." },
{ "name": "hasSourceURL", "type": "boolean", "optional": true, "description": "True, if this script has sourceURL.", "experimental": true },
{ "name": "isModule", "type": "boolean", "optional": true, "description": "True, if this script is ES6 module.", "experimental": true }
{ "name": "isModule", "type": "boolean", "optional": true, "description": "True, if this script is ES6 module.", "experimental": true },
{ "name": "length", "type": "integer", "optional": true, "description": "This script length.", "experimental": true }
],
"description": "Fired when virtual machine parses script. This event is also fired for all known and uncollected scripts upon enabling debugger."
},
......@@ -730,7 +731,8 @@
{ "name": "executionContextAuxData", "type": "object", "optional": true, "description": "Embedder-specific auxiliary data." },
{ "name": "sourceMapURL", "type": "string", "optional": true, "description": "URL of source map associated with script (if any)." },
{ "name": "hasSourceURL", "type": "boolean", "optional": true, "description": "True, if this script has sourceURL.", "experimental": true },
{ "name": "isModule", "type": "boolean", "optional": true, "description": "True, if this script is ES6 module.", "experimental": true }
{ "name": "isModule", "type": "boolean", "optional": true, "description": "True, if this script is ES6 module.", "experimental": true },
{ "name": "length", "type": "integer", "optional": true, "description": "This script length.", "experimental": true }
],
"description": "Fired when virtual machine fails to parse the script."
},
......
src/inspector/v8-debugger-agent-impl.cc
View file @ 07ada64a
......@@ -1141,13 +1141,14 @@ void V8DebuggerAgentImpl::didParseSource(
scriptRef->endLine(), scriptRef->endColumn(), contextId,
scriptRef->hash(), std::move(executionContextAuxDataParam),
isLiveEditParam, std::move(sourceMapURLParam), hasSourceURLParam,
isModuleParam);
isModuleParam, scriptRef->source().length());
else
m_frontend.scriptFailedToParse(
scriptId, scriptURL, scriptRef->startLine(), scriptRef->startColumn(),
scriptRef->endLine(), scriptRef->endColumn(), contextId,
scriptRef->hash(), std::move(executionContextAuxDataParam),
std::move(sourceMapURLParam), hasSourceURLParam, isModuleParam);
std::move(sourceMapURLParam), hasSourceURLParam, isModuleParam,
scriptRef->source().length());
if (scriptURL.isEmpty() || !success) return;
......
test/inspector/debugger/es6-module-script-parsed-expected.txt
View file @ 07ada64a
......@@ -11,6 +11,7 @@ Running test: testLoadedModulesOnDebuggerEnable
hash : F8E59942466284E2766FD161CA6FFD024048A807
isLiveEdit : false
isModule : true
length : 39
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -30,6 +31,7 @@ Running test: testScriptEventsWhenDebuggerIsEnabled
hash : F8E59942466284E2766FD161CA6FFD024048A807
isLiveEdit : false
isModule : true
length : 39
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -46,6 +48,7 @@ Running test: testScriptEventsWhenDebuggerIsEnabled
hasSourceURL : false
hash : FF746120E4E4F1BA4CB5762843D429DC872EBA18
isModule : true
length : 1
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......
test/inspector/debugger/script-on-after-compile-expected.txt
View file @ 07ada64a
......@@ -11,6 +11,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 42
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -29,6 +30,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 52
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -47,6 +49,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 43
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -65,6 +68,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 46
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -83,6 +87,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 50
scriptId : <scriptId>
sourceMapURL : oneline-map
startColumn : 0
......@@ -101,6 +106,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 60
scriptId : <scriptId>
sourceMapURL : oneline-without-nl-map
startColumn : 0
......@@ -119,6 +125,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 51
scriptId : <scriptId>
sourceMapURL : twoline-map
startColumn : 0
......@@ -137,6 +144,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 54
scriptId : <scriptId>
sourceMapURL : threeline-map
startColumn : 0
......@@ -155,6 +163,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 88
scriptId : <scriptId>
sourceMapURL : source-mapping-url-map
startColumn : 0
......@@ -173,6 +182,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 89
scriptId : <scriptId>
sourceMapURL : source-mapping-url-map
startColumn : 0
......@@ -191,6 +201,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 40
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -209,6 +220,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 41
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -227,6 +239,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 18
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -245,6 +258,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 96
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -263,6 +277,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 39
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -281,6 +296,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 19
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -299,6 +315,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 20
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -317,6 +334,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 21
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -335,6 +353,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 22
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -353,6 +372,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 42
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -371,6 +391,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 52
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -389,6 +410,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 43
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -407,6 +429,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 46
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -425,6 +448,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 50
scriptId : <scriptId>
sourceMapURL : oneline-map
startColumn : 0
......@@ -443,6 +467,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 60
scriptId : <scriptId>
sourceMapURL : oneline-without-nl-map
startColumn : 0
......@@ -461,6 +486,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 51
scriptId : <scriptId>
sourceMapURL : twoline-map
startColumn : 0
......@@ -479,6 +505,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 54
scriptId : <scriptId>
sourceMapURL : threeline-map
startColumn : 0
......@@ -497,6 +524,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 88
scriptId : <scriptId>
sourceMapURL : source-mapping-url-map
startColumn : 0
......@@ -515,6 +543,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 89
scriptId : <scriptId>
sourceMapURL : source-mapping-url-map
startColumn : 0
......@@ -533,6 +562,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 40
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -551,6 +581,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 41
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -569,6 +600,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 18
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -587,6 +619,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 96
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -605,6 +638,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 39
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -622,6 +656,7 @@ scriptFailedToParse
hasSourceURL : true
hash : <hash>
isModule : false
length : 56
scriptId : <scriptId>
sourceMapURL : failed-map
startColumn : 0
......@@ -640,6 +675,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 19
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -658,6 +694,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 20
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -676,6 +713,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 21
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -694,6 +732,7 @@ scriptParsed
hash : <hash>
isLiveEdit : false
isModule : false
length : 22
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......
test/inspector/debugger/script-parsed-for-runtime-evaluate-expected.txt
View file @ 07ada64a
......@@ -10,6 +10,7 @@ Runtime.evaluate with valid expression
hash : 9D04F7335D1661503EAB9AF3EACAF92020803F34
isLiveEdit : false
isModule : false
length : 29
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -27,6 +28,7 @@ Runtime.evaluate with syntax error
hasSourceURL : true
hash : 9BCA34A10E5386925E74C1716C857BEB02821E15
isModule : false
length : 39
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -45,6 +47,7 @@ Runtime.callFunctionOn with valid functionDeclaration
hash : 9D04CEA1B54DF92A01A0498543D429DC872EBA18
isLiveEdit : false
isModule : false
length : 18
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -62,6 +65,7 @@ Runtime.callFunctionOn with syntax error
hasSourceURL : false
hash : 9D04D83251E2B7F64CB5762843D429DC872EBA18
isModule : false
length : 3
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -80,6 +84,7 @@ Runtime.compileScript with valid expression
hash : 9D04F733E4E4F1BA4CB5762843D429DC872EBA18
isLiveEdit : false
isModule : false
length : 4
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -97,6 +102,7 @@ Runtime.compileScript with syntax error
hasSourceURL : false
hash : FF746120E4E4F1BA4CB5762843D429DC872EBA18
isModule : false
length : 1
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......
test/inspector/runtime/es6-module-expected.txt
View file @ 07ada64a
......@@ -9,6 +9,7 @@ Checks basic ES6 modules support.
hash : 9C014F7249BAFA12B91017817AD15091D01A9155
isLiveEdit : false
isModule : true
length : 83
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -26,6 +27,7 @@ Checks basic ES6 modules support.
hash : 443A2FA24A6112E6B9101781E6A19B56BDC396D4
isLiveEdit : false
isModule : true
length : 84
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -43,6 +45,7 @@ Checks basic ES6 modules support.
hash : 54D834614FBF9B389082DAE06CD3EFC499BEBF13
isLiveEdit : false
isModule : true
length : 191
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......@@ -187,6 +190,7 @@ console.log(239)
hasSourceURL : false
hash : FF746120E4E4F1BA4CB5762843D429DC872EBA18
isModule : true
length : 1
scriptId : <scriptId>
sourceMapURL :
startColumn : 0
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment