Commit 07acca09 authored by Leszek Swirski's avatar Leszek Swirski Committed by V8 LUCI CQ

[sparkplug] Simplify arch-guards to ENABLE_SPARKPLUG

This means we only have to maintain the arch list in one place.

Bug: v8:11420, v8:11421
Change-Id: I1618e2ab1396ad85aca60923111e5966e547e65a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3041420
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: 's avatarPatrick Thier <pthier@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75813}
parent 4744ea8b
...@@ -5,16 +5,15 @@ ...@@ -5,16 +5,15 @@
#ifndef V8_BASELINE_BASELINE_ASSEMBLER_INL_H_ #ifndef V8_BASELINE_BASELINE_ASSEMBLER_INL_H_
#define V8_BASELINE_BASELINE_ASSEMBLER_INL_H_ #define V8_BASELINE_BASELINE_ASSEMBLER_INL_H_
#include "src/baseline/baseline-assembler.h"
// TODO(v8:11421): Remove #if once baseline compiler is ported to other // TODO(v8:11421): Remove #if once baseline compiler is ported to other
// architectures. // architectures.
#if V8_TARGET_ARCH_IA32 || V8_TARGET_ARCH_X64 || V8_TARGET_ARCH_ARM64 || \ #if ENABLE_SPARKPLUG
V8_TARGET_ARCH_ARM || V8_TARGET_ARCH_RISCV64 || V8_TARGET_ARCH_MIPS64 || \
V8_TARGET_ARCH_MIPS
#include <type_traits> #include <type_traits>
#include <unordered_map> #include <unordered_map>
#include "src/baseline/baseline-assembler.h"
#include "src/codegen/interface-descriptors-inl.h" #include "src/codegen/interface-descriptors-inl.h"
#include "src/interpreter/bytecode-register.h" #include "src/interpreter/bytecode-register.h"
#include "src/objects/feedback-cell.h" #include "src/objects/feedback-cell.h"
...@@ -142,6 +141,6 @@ SaveAccumulatorScope::~SaveAccumulatorScope() { ...@@ -142,6 +141,6 @@ SaveAccumulatorScope::~SaveAccumulatorScope() {
} // namespace internal } // namespace internal
} // namespace v8 } // namespace v8
#endif #endif // ENABLE_SPARKPLUG
#endif // V8_BASELINE_BASELINE_ASSEMBLER_INL_H_ #endif // V8_BASELINE_BASELINE_ASSEMBLER_INL_H_
...@@ -7,9 +7,8 @@ ...@@ -7,9 +7,8 @@
// TODO(v8:11421): Remove #if once baseline compiler is ported to other // TODO(v8:11421): Remove #if once baseline compiler is ported to other
// architectures. // architectures.
#if V8_TARGET_ARCH_IA32 || V8_TARGET_ARCH_X64 || V8_TARGET_ARCH_ARM64 || \ #include "src/flags/flags.h"
V8_TARGET_ARCH_ARM || V8_TARGET_ARCH_RISCV64 || V8_TARGET_ARCH_MIPS64 || \ #if ENABLE_SPARKPLUG
V8_TARGET_ARCH_MIPS
#include "src/codegen/macro-assembler.h" #include "src/codegen/macro-assembler.h"
#include "src/objects/tagged-index.h" #include "src/objects/tagged-index.h"
......
...@@ -4,14 +4,13 @@ ...@@ -4,14 +4,13 @@
// TODO(v8:11421): Remove #if once baseline compiler is ported to other // TODO(v8:11421): Remove #if once baseline compiler is ported to other
// architectures. // architectures.
#include "src/base/bits.h" #include "src/flags/flags.h"
#if V8_TARGET_ARCH_IA32 || V8_TARGET_ARCH_X64 || V8_TARGET_ARCH_ARM64 || \ #if ENABLE_SPARKPLUG
V8_TARGET_ARCH_ARM || V8_TARGET_ARCH_RISCV64 || V8_TARGET_ARCH_MIPS64 || \
V8_TARGET_ARCH_MIPS
#include <algorithm> #include <algorithm>
#include <type_traits> #include <type_traits>
#include "src/base/bits.h"
#include "src/baseline/baseline-assembler-inl.h" #include "src/baseline/baseline-assembler-inl.h"
#include "src/baseline/baseline-assembler.h" #include "src/baseline/baseline-assembler.h"
#include "src/baseline/baseline-compiler.h" #include "src/baseline/baseline-compiler.h"
...@@ -2249,4 +2248,4 @@ DEBUG_BREAK_BYTECODE_LIST(DEBUG_BREAK) ...@@ -2249,4 +2248,4 @@ DEBUG_BREAK_BYTECODE_LIST(DEBUG_BREAK)
} // namespace internal } // namespace internal
} // namespace v8 } // namespace v8
#endif #endif // ENABLE_SPARKPLUG
...@@ -7,9 +7,8 @@ ...@@ -7,9 +7,8 @@
// TODO(v8:11421): Remove #if once baseline compiler is ported to other // TODO(v8:11421): Remove #if once baseline compiler is ported to other
// architectures. // architectures.
#if V8_TARGET_ARCH_IA32 || V8_TARGET_ARCH_X64 || V8_TARGET_ARCH_ARM64 || \ #include "src/flags/flags.h"
V8_TARGET_ARCH_ARM || V8_TARGET_ARCH_RISCV64 || V8_TARGET_ARCH_MIPS64 || \ #if ENABLE_SPARKPLUG
V8_TARGET_ARCH_MIPS
#include "src/base/logging.h" #include "src/base/logging.h"
#include "src/base/threaded-list.h" #include "src/base/threaded-list.h"
...@@ -197,6 +196,6 @@ class BaselineCompiler { ...@@ -197,6 +196,6 @@ class BaselineCompiler {
} // namespace internal } // namespace internal
} // namespace v8 } // namespace v8
#endif #endif // ENABLE_SPARKPLUG
#endif // V8_BASELINE_BASELINE_COMPILER_H_ #endif // V8_BASELINE_BASELINE_COMPILER_H_
...@@ -9,9 +9,8 @@ ...@@ -9,9 +9,8 @@
// TODO(v8:11421): Remove #if once baseline compiler is ported to other // TODO(v8:11421): Remove #if once baseline compiler is ported to other
// architectures. // architectures.
#if V8_TARGET_ARCH_IA32 || V8_TARGET_ARCH_X64 || V8_TARGET_ARCH_ARM64 || \ #include "src/flags/flags.h"
V8_TARGET_ARCH_ARM || V8_TARGET_ARCH_RISCV64 || V8_TARGET_ARCH_MIPS64 || \ #if ENABLE_SPARKPLUG
V8_TARGET_ARCH_MIPS
#include "src/baseline/baseline-assembler-inl.h" #include "src/baseline/baseline-assembler-inl.h"
#include "src/baseline/baseline-compiler.h" #include "src/baseline/baseline-compiler.h"
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment