[cctest] Enable shared linking for cctest

Bug: v8:9020, chromium:676417

Change-Id: Iadb46d8877ef9f85f0e444be563a94ccf0f8209f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541054
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60706}

test/BUILD.gn

@@ -148,9 +148,7 @@ v8_header_set("common_test_headers") {
   configs = []
 
   public_deps = [
-    # We can't depend on this here, because if the "cctest" target depends on it
-    # we will get duplicate symbols.
-    #"../:v8_for_testing",
+    "../:v8_for_testing",
     "../:v8_libbase",
   ]
 

test/cctest/BUILD.gn

@@ -31,16 +31,6 @@ v8_executable("cctest") {
   #["OS=="aix"", {
   #  "ldflags": [ "-Wl,-bbigtoc" ],
   #}],
-
-  # crbug.com/676417: Suppress symbol import warning from linker.
-  if (is_win && is_component_build) {
-    ldflags += [
-      "/ignore:4217",
-      "/ignore:4049",
-    ]
-    remove_configs = [ "//build/config/win:default_incremental_linking" ]
-    configs += [ "//build/config/win:no_incremental_linking" ]
-  }
 }
 
 v8_header_set("cctest_headers") {
@@ -374,7 +364,7 @@ v8_source_set("cctest_sources") {
     ":cctest_headers",
     ":resources",
     "..:common_test_headers",
-    "../..:v8_initializers",
+    "../..:v8_for_testing",
     "../..:v8_libbase",
     "../..:v8_libplatform",
     "../..:wasm_module_runner",
@@ -386,15 +376,6 @@ v8_source_set("cctest_sources") {
     "../..:run_torque",
   ]
 
-  if (is_component_build) {
-    # cctest can't be built against a shared library, so we
-    # need to depend on the underlying static target in that case.
-    deps += [ "../..:v8_maybe_snapshot" ]
-    defines += [ "BUILDING_V8_SHARED" ]
-  } else {
-    deps += [ "../..:v8" ]
-  }
-
   if (v8_enable_i18n_support) {
     defines += [ "V8_INTL_SUPPORT" ]
     public_deps += [ "//third_party/icu" ]