Commit 071a2860 authored by hpayer's avatar hpayer Committed by Commit bot

Use nobarrier load in store buffer duplicate removal to annotate harmless race.

BUG=

Review URL: https://codereview.chromium.org/787383002

Cr-Commit-Position: refs/heads/master@{#25745}
parent 70caf05b
...@@ -109,7 +109,9 @@ void StoreBuffer::Uniq() { ...@@ -109,7 +109,9 @@ void StoreBuffer::Uniq() {
for (Address* read = old_start_; read < old_top_; read++) { for (Address* read = old_start_; read < old_top_; read++) {
Address current = *read; Address current = *read;
if (current != previous) { if (current != previous) {
if (heap_->InNewSpace(*reinterpret_cast<Object**>(current))) { Object* object = reinterpret_cast<Object*>(
base::NoBarrier_Load(reinterpret_cast<base::AtomicWord*>(current)));
if (heap_->InNewSpace(object)) {
*write++ = current; *write++ = current;
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment